Exception 2 TPs Wh2 MB1/2, BestThetaWh0, t0phi

jfernan2 · jfernan2 · commit c507605fdc3d · 2025-03-26T12:36:34.000+01:00
diff --git a/L1Trigger/DTTriggerPhase2/interface/MPThetaMatching.h b/L1Trigger/DTTriggerPhase2/interface/MPThetaMatching.h
@@ -48,8 +48,6 @@ class MPThetaMatching : public MPFilter {
   float zFE[5] = {-658.9, -393.3, 126.4, 393.3, 658.9};  //cm
   float xFE[3] = {218 / 2., 266.8 / 2., 315 / 2.};       //cm
   float ZRES_CONV = 65536. / 1500;
-  int totOUTtheta, totINtheta, totOUTphi, totINphi;
-  int nothetaOUTphi, st4OUTphi, hqOUTphi, nophiOUTtheta;
 
 private:
   // Private methods
diff --git a/L1Trigger/DTTriggerPhase2/src/MPThetaMatching.cc b/L1Trigger/DTTriggerPhase2/src/MPThetaMatching.cc
@@ -50,16 +50,7 @@ MPThetaMatching::~MPThetaMatching() { finish(); }
 // ============================================================================
 // Main methods (initialise, run, finish)
 // ============================================================================
-void MPThetaMatching::initialise(const edm::EventSetup &iEventSetup) {
-  totINphi = 0;
-  totOUTphi = 0;
-  totINtheta = 0;
-  totOUTtheta = 0;
-  st4OUTphi = 0;
-  hqOUTphi = 0;
-  nothetaOUTphi = 0;
-  nophiOUTtheta = 0;
-}
+void MPThetaMatching::initialise(const edm::EventSetup &iEventSetup) {}
 
 void MPThetaMatching::run(edm::Event &iEvent,
                           const edm::EventSetup &iEventSetup,
@@ -76,8 +67,6 @@ void MPThetaMatching::run(edm::Event &iEvent,
   else if (scenario_ == SLICE_TEST)
     shift_back = 400;
 
-  //cout<<"############NEW EVENT####"<< "inMPaths: "<<inMPaths.size()<<endl;
-
   if (th_option_ > 0) {
     auto filteredMPs = filter(inMPaths, shift_back);
     for (auto &mp : filteredMPs)
@@ -88,23 +77,9 @@ void MPThetaMatching::run(edm::Event &iEvent,
           << "MPThetaMatching: th_option can NOT be negative!!! Check settings. Saving all MPs for the moment" << endl;
     outMPaths = inMPaths;  //no filter at all
   }
-
-  //if(doLog) cout << "Before filter #TPs:" << inMPaths.size() << " after: " << outMPaths.size() << endl;
 }
 
-void MPThetaMatching::finish() {
-  totOUTphi = totOUTphi - st4OUTphi - nothetaOUTphi - nophiOUTtheta;
-  totINphi = totINphi - nothetaOUTphi - nophiOUTtheta;
-  std::cout << "Rejected rate Phi: " << 1 - float(totOUTphi) / totINphi << endl;
-  std::cout << "Rejected rate Theta: " << 1 - float(totOUTtheta) / totINtheta << endl;
-  std::cout << "Rejected rate total: " << 1 - float(totOUTphi + totOUTtheta) / (totINtheta + totINphi) << endl;
-
-  totOUTphi = totOUTphi - hqOUTphi;
-  totINphi = totINphi - hqOUTphi;
-  std::cout << "Rejected rate Phi (excluding HQ): " << 1 - float(totOUTphi) / totINphi << endl;
-  std::cout << "Rejected rate total (excluding HQ): " << 1 - float(totOUTphi + totOUTtheta) / (totINtheta + totINphi)
-            << endl;
-};
+void MPThetaMatching::finish(){};
 
 ///////////////////////////
 ///  OTHER METHODS
@@ -122,34 +97,20 @@ std::vector<metaPrimitive> MPThetaMatching::filter(std::vector<metaPrimitive> in
     if (slId.superLayer() == 2)
       thetaMPs.push_back(mp);
     else if (chId.station() == 4)  //No theta matching for MB4, save MP
-    {
       outMPs.push_back(mp);
-      st4OUTphi += 1;
-    } else if (mp.quality > th_quality_)  //don't do theta matching for q > X, save
+    else if (mp.quality > th_quality_)  //don't do theta matching for q > X, save
     {
       outMPs.push_back(mp);
       phiMPs.push_back(mp);  //keep them in the loop to filter in Theta for cases where there are no other phiMPs
-      hqOUTphi += 1;
     } else
       phiMPs.push_back(mp);
   }
 
-  bool doLog = false;
-  if (thetaMPs.size() > 0 || phiMPs.size() > 0) {
-    cout << "Initial #TPs Theta: " << thetaMPs.size() << " Phi: " << phiMPs.size() << endl;
-    doLog = true;
-  }
-
-  totINphi += phiMPs.size();
-  totINtheta += thetaMPs.size();
-
   //Order Theta MPs by quality
   std::sort(thetaMPs.begin(), thetaMPs.end(), compareMPs);
 
   //Use only best quality theta MP in chamber
-  //thetaMPs = getBestThetaMPInChamber(thetaMPs);
-  if (doLog)
-    cout << "Intermediate #TPs Theta: " << thetaMPs.size() << endl;
+  thetaMPs = getBestThetaMPInChamber(thetaMPs);
 
   // Loop on phi, save those at chamber without Theta MPs
   for (auto &mp : phiMPs) {
@@ -161,17 +122,15 @@ std::vector<metaPrimitive> MPThetaMatching::filter(std::vector<metaPrimitive> in
     int station = chId.station();
 
     if (!isThereThetaMPInChamber(sector, wheel, station, thetaMPs)) {
-      if (mp.quality <= th_quality_) {  //Has it been saved already?
-        outMPs.push_back(mp);           // No theta MPs in chamber to match, save MP
-        nothetaOUTphi += 1;
-      }
+      if (mp.quality <= th_quality_)  //Has it been saved already?
+        outMPs.push_back(mp);         // No theta MPs in chamber to match, save MP
     }
   }
 
   // Loop on theta (already ordered)
   int oldSector = 0;
   int oldStation = 0;
-  int oldWheel = 0;
+  int oldWheel = -999;
   // container to decide which theta-phi pair to save
   std::vector<std::tuple<metaPrimitive, metaPrimitive, float>>
       deltaTimePosPhiCands;  //thetaMP, phiMP, difference in TimePosition
@@ -203,15 +162,10 @@ std::vector<metaPrimitive> MPThetaMatching::filter(std::vector<metaPrimitive> in
     //    float t0 = (mpTheta.t0 - shift_back * LHC_CLK_FREQ) * ((float) TIME_TO_TDC_COUNTS / (float) LHC_CLK_FREQ);
     float t0 = ((int)round(mpTheta.t0 / (float)LHC_CLK_FREQ)) - shift_back;
     float posRefZ = zFE[wheel + 2];
-    if (doLog)
-      cout << "Theta wh se st q t0: " << wheel << " " << sector << " " << station << " " << mpTheta.quality << " "
-           << mpTheta.t0 << endl;
 
     if (wheel == 0 && (sector == 1 || sector == 4 || sector == 5 || sector == 8 || sector == 9 || sector == 12))
       posRefZ = -posRefZ;
     float posZ = abs(mpTheta.phi);
-    //cout << "t0: " << t0 << endl;
-    //cout << "posZ: " << posZ << endl;
 
     // Loop in Phis
     for (metaPrimitive &mpPhi : phiMPs) {
@@ -221,19 +175,13 @@ std::vector<metaPrimitive> MPThetaMatching::filter(std::vector<metaPrimitive> in
       int sector2 = chId2.sector();
       int wheel2 = chId2.wheel();
       int station2 = chId2.station();
-      if (doLog)
-        cout << "Phi wheel: " << wheel2 << " sector " << sector2 << " station: " << station2 << " q: " << mpPhi.quality
-             << " t0: " << mpPhi.t0 << endl;
 
       if (station2 != station || sector2 != sector || wheel2 != wheel)
         continue;
 
-      //     float t02 = (mpPhi.t0 - shift_back * LHC_CLK_FREQ) * ((float) TIME_TO_TDC_COUNTS / (float) LHC_CLK_FREQ);
       float t02 = ((int)round(mpPhi.t0 / (float)LHC_CLK_FREQ)) - shift_back;
 
-      //cout << "posRefZ: " << posRefZ << " Z: " << posZ / ZRES_CONV << endl;
       float tphi = t02 - abs(posZ / ZRES_CONV - posRefZ) / vwire;
-      //cout << "tphi: " << tphi << endl;
 
       int LR = -1;
       if (wheel == 0 && (sector == 3 || sector == 4 || sector == 7 || sector == 8 || sector == 11 || sector == 12))
@@ -242,65 +190,22 @@ std::vector<metaPrimitive> MPThetaMatching::filter(std::vector<metaPrimitive> in
         LR = pow(-1, wheel + sector + 1);
       else if (wheel < 0)
         LR = pow(-1, -wheel + sector);
-      //cout << "wh st se: " << wheel << " " << station << " " << sector << " LR: " << LR << endl;
 
       float posRefX = LR * xFE[station - 1];
       float ttheta = t0 - (mpPhi.x / 1000 - posRefX) / vwire;
-      //cout << "posRefX: " << posRefX << " X: " << mp2.x / 1000 << endl;
-      //cout << "ttheta: " << ttheta << endl;
 
       deltaTimePosPhiCands.push_back({mpTheta, mpPhi, abs(tphi - ttheta)});
-      //cout << "deltaTimePosPhiCands: " << deltaTimePosPhiCands.size() << endl;
     }  //loop in phis
 
     if (deltaTimePosPhiCands.size() == 0) {
       outMPs.push_back(mpTheta);  //save ThetaMP when there is no phi TPs
       savedThetaMPs.push_back(mpTheta);
-      nophiOUTtheta += 1;
     }
   }  // loop in thetas
 
   if (deltaTimePosPhiCands.size() > 0)
     orderAndSave(deltaTimePosPhiCands, &outMPs, &savedThetaMPs);  //do once more for last theta TP in loop
 
-  if (doLog)
-    cout << "After #TPs Theta: " << savedThetaMPs.size() << " Phi: " << outMPs.size() - savedThetaMPs.size() << endl;
-
-  if (inMPs.size() > outMPs.size())
-    cout << " ########### TP size reduced from: " << inMPs.size() << " to: " << outMPs.size()
-         << " rate: " << float(outMPs.size()) / inMPs.size() << endl;
-  else if (outMPs.size() > inMPs.size())
-    cout << " $$$$$$$$$$$$$ TP size enlarged from: " << inMPs.size() << " to: " << outMPs.size() << endl;
-
-  if (phiMPs.size() > (outMPs.size() - savedThetaMPs.size()))
-    cout << " ########### TP Phi size reduced from: " << phiMPs.size()
-         << " to: " << outMPs.size() - savedThetaMPs.size()
-         << " rate: " << float((outMPs.size() - savedThetaMPs.size())) / phiMPs.size() << endl;
-
-  if (thetaMPs.size() > savedThetaMPs.size())
-    cout << " ########### TP Theta size reduced from: " << thetaMPs.size() << " to: " << savedThetaMPs.size()
-         << " rate: " << float(savedThetaMPs.size()) / thetaMPs.size() << endl;
-
-  totOUTtheta = totOUTtheta + savedThetaMPs.size();
-  totOUTphi = totOUTphi + (outMPs.size() - savedThetaMPs.size());
-
-  for (const auto &mp1 : outMPs) {
-    cout << "FINAL OUTPUT OF WHAT IT IS SAVED" << endl;
-    DTChamberId chId1(mp1.rawId);
-    DTSuperLayerId slId1(mp1.rawId);
-
-    int sector1 = chId1.sector();
-    int wheel1 = chId1.wheel();
-    int station1 = chId1.station();
-    if (slId1.superLayer() == 2)
-      cout << "Theta wheel: " << wheel1 << " sector " << sector1 << " station1: " << station1 << " q: " << mp1.quality
-           << " t0: " << mp1.t0 << endl;
-    else
-      cout << "Phi  wheel: " << wheel1 << " sector " << sector1 << " station1: " << station1 << " q: " << mp1.quality
-           << " t0: " << mp1.t0 << endl;
-    cout << endl;
-  }
-
   return outMPs;
 };
 
@@ -329,46 +234,49 @@ std::vector<metaPrimitive> MPThetaMatching::getBestThetaMPInChamber(std::vector<
     //if there are more than 1 theta TPs in chamber, use and save only the one with highest quality
     int sector1 = chId1.sector();
     int wheel1 = chId1.wheel();
-    int station1 = chId1.station();
-    cout << "Theta wheel: " << wheel1 << " sector " << sector1 << " station1: " << station1 << " q: " << mp1.quality
-         << " t0: " << mp1.t0 << endl;
-    // Theta TPs (SL2) can be only q=1 (3hits) or q=3 (4 hits)
-    if (mp1.quality > 1) {
-      bestThetaMPs.push_back(mp1);
-      continue;
-    }
-
-    int nTPs = 0;
-    bool saved = false;
-    // if q=1
-    for (const auto &mp2 : thetaMPs) {
-      DTChamberId chId2(mp2.rawId);
-      DTSuperLayerId slId2(mp2.rawId);
-
-      int sector2 = chId2.sector();
-      int wheel2 = chId2.wheel();
-      int station2 = chId2.station();
+    if (wheel1 == 0) {  //Exception for Wheel 0 ONLY, to take into account background in other chambers
+      int station1 = chId1.station();
+      // Theta TPs (SL2) can be only q=1 (3hits) or q=3 (4 hits)
+      if (mp1.quality > 1) {
+        bestThetaMPs.push_back(mp1);
+        continue;
+      }
 
-      if (sector1 == sector2 && wheel1 == wheel2 && station1 == station2) {
-        if (mp2.quality > mp1.quality && (abs(wheel1) != 2 || station1 > 2)) {  //exception for WH+-2 MB1/2
-          saved = true;
-          break;  //there is a q=3 and it was already saved
-        } else if (mp2.quality == mp1.quality && mp2.t0 != mp1.t0) {
-          saved = true;
-          bestThetaMPs.push_back(mp1);
-          break;  //if there are more than 1 with same q=1, save both
-        } else if (abs(wheel1) == 2 && station1 < 3) {
-          saved = true;
-          bestThetaMPs.push_back(mp1);
-          break;
+      int nTPs = 0;
+      bool saved = false;
+      // if q=1
+      for (const auto &mp2 : thetaMPs) {
+        DTChamberId chId2(mp2.rawId);
+        DTSuperLayerId slId2(mp2.rawId);
+
+        int sector2 = chId2.sector();
+        int wheel2 = chId2.wheel();
+        int station2 = chId2.station();
+
+        if (sector1 == sector2 && wheel1 == wheel2 && station1 == station2) {
+          if (mp2.quality > mp1.quality && wheel1 == 0) {
+            saved = true;
+            break;  //there is a q=3 and it was already saved
+          } else if (mp2.quality == mp1.quality && mp2.t0 != mp1.t0) {
+            saved = true;
+            bestThetaMPs.push_back(mp1);
+            break;  //if there are more than 1 with same q=1, save both
+          } else if (abs(wheel1) == 2 && station1 < 3) {
+            saved = true;
+            bestThetaMPs.push_back(mp1);
+            break;
+          }
+
+          nTPs++;
         }
-
-        nTPs++;
       }
-    }
-    if (nTPs == 1 && !saved)
-      bestThetaMPs.push_back(mp1);  //only one Theta TP in chamber and it is q=1
-  }
+      if (nTPs == 1 && !saved)
+        bestThetaMPs.push_back(mp1);  //only one Theta TP in chamber and it is q=1
+    }                                 //wheel ==0
+
+    else
+      bestThetaMPs.push_back(mp1);
+  }  // loop in thetaMPs
 
   return bestThetaMPs;
 };
@@ -380,34 +288,32 @@ void MPThetaMatching::orderAndSave(std::vector<std::tuple<metaPrimitive, metaPri
   std::sort(deltaTimePosPhiCands.begin(), deltaTimePosPhiCands.end(), comparePairs);
   int count = 0;
 
-  for ( std::tuple<metaPrimitive, metaPrimitive, float> &p :
+  for (std::tuple<metaPrimitive, metaPrimitive, float> &p :
        deltaTimePosPhiCands) {  //save up to nth nearest Theta-Phi pair candidate
-    cout << "Count: " << count << " abs(tphi-ttheta): " << std::get<2>(p) << " qTheta: " << std::get<0>(p).quality
-         << " qPhi: " << std::get<1>(p).quality << endl;
     if (std::get<1>(p).quality > th_quality_)
       continue;
     DTChamberId chId(std::get<1>(p).rawId);
 
-    //if ((abs(chId.wheel()) == 2 && chId.station() < 3 && count < th_option_ + 1) ||  //save an extra pair for WH+-2MB1/2
-        if( count < th_option_) {
-      std::get<0>(p).t0 = std::get<1>(p).t0;
+    if ((abs(chId.wheel()) == 2 && chId.station() < 3 && count < th_option_ + 1) ||  //save an extra pair for WH+-2MB1/2
+        count < th_option_) {
+      std::get<0>(p).t0 = std::get<1>(p).t0;     //replace t0 by associated phi t0
       outMPs->push_back(std::get<1>(p));         //add PhiMP
       outMPs->push_back(std::get<0>(p));         //add ThetaMP
       savedThetaMPs->push_back(std::get<0>(p));  //for accounting
       count++;
     } else
-      break;  //FIXME: avoid Theta duplicates when saving more than one pair
+      break;  //avoid Theta duplicates when saving more than one pair
   }
 
-  for (std::tuple<metaPrimitive, metaPrimitive, float> &p : deltaTimePosPhiCands) {
+  for (std::tuple<metaPrimitive, metaPrimitive, float> &p :
+       deltaTimePosPhiCands) {  // save theta TP when paired Phi was above th_quality_
     DTChamberId chId(std::get<1>(p).rawId);
-    if (count < th_option_ ){ //|| (abs(chId.wheel()) == 2 && chId.station() < 3 && count < (th_option_ + 1))) {
+    if (count < th_option_ || (abs(chId.wheel()) == 2 && chId.station() < 3 && count < (th_option_ + 1))) {
       if (std::get<1>(p).quality > th_quality_) {
-        std::get<0>(p).t0 = std::get<1>(p).t0;
-        outMPs->push_back(std::get<0>(p));  //add ThetaMP
+        //if (abs(chId.wheel())!=0)
+        std::get<0>(p).t0 = std::get<1>(p).t0;  //replace t0 by associated phi t0
+        outMPs->push_back(std::get<0>(p));      //add ThetaMP
         savedThetaMPs->push_back(std::get<0>(p));
-        cout << "Count: " << count << " abs(tphi-ttheta): " << std::get<2>(p) << " qTheta: " << std::get<0>(p).quality
-             << " qPhi: " << std::get<1>(p).quality << " no Phis below qcut to match" << endl;
         count++;
       }
     } else
