Merge pull request #47939 from bsunanda/Run3-sim163

Run3-sim163 Equip the digi study with a few diagnostic statements

Author: cmsbuild

Validation/EcalDigis/test/EcalDigiStudy.cc

@@ -1,3 +1,4 @@
+
 /*
  * \file EcalDigiStudy.h
  *
@@ -267,6 +268,7 @@ void EcalDigiStudy::analyze(edm::Event const& e, edm::EventSetup const& c) {
       pedestalPreSample /= 3.;
       pedestalPreSampleAnalog /= 3.;
 
+#ifdef EDM_ML_DEBUG
       if (verbose_) {
         edm::LogVerbatim("EcalDigiStudy")
             << "Barrel Digi for EBDetId = " << ebid.rawId() << " eta,phi " << ebid.ieta() << " " << ebid.iphi();
@@ -278,6 +280,7 @@ void EcalDigiStudy::analyze(edm::Event const& e, edm::EventSetup const& c) {
         if (countsAfterGainSwitch > 0)
           edm::LogVerbatim("EcalDigiStudy") << "Counts after switch " << countsAfterGainSwitch;
       }
+#endif
       if (countsAfterGainSwitch > 0 && countsAfterGainSwitch < 5) {
         edm::LogWarning("EcalDigiStudy") << "Wrong number of counts after gain switch before next switch! "
                                          << countsAfterGainSwitch;
@@ -391,6 +394,7 @@ void EcalDigiStudy::analyze(edm::Event const& e, edm::EventSetup const& c) {
       pedestalPreSample /= 3.;
       pedestalPreSampleAnalog /= 3.;
 
+#ifdef EDM_ML_DEBUG
       edm::LogVerbatim("EcalDigiStudy") << "Endcap Digi for EEDetId = " << eeid.rawId() << " x,y " << eeid.ix() << " "
                                         << eeid.iy();
       for (int i = 0; i < 10; i++)
@@ -400,7 +404,7 @@ void EcalDigiStudy::analyze(edm::Event const& e, edm::EventSetup const& c) {
                                         << " Pedestal from pre-sample = " << pedestalPreSampleAnalog;
       if (countsAfterGainSwitch > 0)
         edm::LogVerbatim("EcalDigiStudy") << "Counts after switch " << countsAfterGainSwitch;
-
+#endif
       if (countsAfterGainSwitch > 0 && countsAfterGainSwitch < 5) {
         edm::LogWarning("EcalDigiStudy") << "Wrong number of counts after gain switch before next switch! "
                                          << countsAfterGainSwitch;

Validation/EcalDigis/test/runEcalDigiStudy_cfg.py

@@ -21,7 +21,7 @@
 
 process = cms.Process('DigiStudy')
 
-fileInput = "file:/eos/user/s/sarkar/Simulation/PUMixing/" + options.IPType + ".root"
+fileInput = "file:/eos/user/s/sarkar/Simulation/PUMixing/CMSSW_151X/" + options.IPType + ".root"
 fileName = "EC" + options.IPType + ".root"
 
 print("Input file:    ", fileInput)

Validation/HcalDigis/test/HcalDigiStudy.cc

@@ -55,6 +55,8 @@
 #include "TH1D.h"
 #include "TProfile.h"
 
+//#define EDM_ML_DEBUG
+
 class HcalDigiStudy : public edm::one::EDAnalyzer<edm::one::WatchRuns, edm::one::SharedResources> {
 public:
   explicit HcalDigiStudy(const edm::ParameterSet&);
@@ -835,7 +837,10 @@ void HcalDigiStudy::reco(const edm::Event& iEvent,
 
   // CYCLE OVER CELLS ========================================================
   int Ndig = 0;
-
+#ifdef EDM_ML_DEBUG
+  edm::LogVerbatim("HcalDiguStudy") << "Subdet " << subdet_ << " with " << digiCollection->size()
+                                    << " entries in DigiCollection";
+#endif
   for (digiItr = digiCollection->begin(); digiItr != digiCollection->end(); digiItr++) {
     HcalDetId cell(digiItr->id());
     int depth = cell.depth();
@@ -1151,6 +1156,10 @@ void HcalDigiStudy::reco(const edm::Event& iEvent,
 
   // CYCLE OVER CELLS ========================================================
   int Ndig = 0;
+#ifdef EDM_ML_DEBUG
+  edm::LogVerbatim("HcalDiguStudy") << "Subdet " << subdet_ << " with " << digiCollection->size()
+                                    << " entries in DigiCollection";
+#endif
 
   for (typename HcalDataFrameContainer<dataFrameType>::const_iterator digiItr = digiCollection->begin();
        digiItr != digiCollection->end();
@@ -1202,8 +1211,9 @@ void HcalDigiStudy::reco(const edm::Event& iEvent,
              pedWidth->getWidth(0));
 
     }  // end of event #1
-    //edm::LogVerbatim("OutputInfo") << "==== End of event noise block in cell cycle";
-
+    //#ifdef EDM_ML_DEBUG
+    //    edm::LogVerbatim("HcalDigiStudy") << "==== End of event noise block in cell cycle";
+    //#endif
     if (sub == isubdet)
       Ndig++;  // subdet number of digi
 

Validation/HcalDigis/test/runHcalDigiStudy_cfg.py

@@ -21,7 +21,8 @@
 
 process = cms.Process('DigiStudy')
 
-fileInput = "file:/eos/user/s/sarkar/Simulation/PUMixing/" + options.IPType + ".root"
+fileInput = "file:/eos/user/s/sarkar/Simulation/PUMixing/CMSSW_151X/" + options.IPType + ".root"
+#fileInput = "file:/eos/user/s/sarkar/Simulation/PUMixing/" + options.IPType + ".root"
 fileName = "HC" + options.IPType + ".root"
 
 print("Input file:    ", fileInput)
@@ -37,6 +38,8 @@
 from Configuration.AlCa.GlobalTag import GlobalTag
 process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:phase1_2023_realistic', '')
 
+process.MessageLogger.HcalDigiStudy=dict()
+
 process.source = cms.Source("PoolSource",
                             fileNames = cms.untracked.vstring(fileInput) )
 
@@ -51,6 +54,7 @@
 process.analysis_step = cms.Path(process.hcalDigiStudy)
 process.hcalDigiStudy.TestNumber = True
 #process.hcalDigiStudy.simHits = "fastSimProducer:HcalHits"
+process.hcalDigiStudy.mc = "no"
 
 # Schedule definition
 process.schedule = cms.Schedule(