Skip to content

Commit db17e7b

Browse files
committed
Test existence of source by comparing to None
Avoid implicit `if` failure which could happen if a source were to define a different criteria (such as __len__).
1 parent 365705a commit db17e7b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

FWCore/ParameterSet/python/Config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1059,9 +1059,9 @@ def dumpPython(self, options=PrintOptions()) -> str:
10591059
specialImportRegistry._reset()
10601060
header = "import FWCore.ParameterSet.Config as cms"
10611061
result = "process = cms.Process(\""+self.__name+"\")\n\n"
1062-
if self.source_():
1062+
if not self.source_() is None:
10631063
result += "process.source = "+self.source_().dumpPython(options)
1064-
if self.looper_():
1064+
if not self.looper_() is None:
10651065
result += "process.looper = "+self.looper_().dumpPython()
10661066
result+=self._dumpPythonList(self.psets, options)
10671067
result+=self._dumpPythonList(self.vpsets, options)
@@ -1103,10 +1103,10 @@ def splitPython(self, options:PrintOptions = PrintOptions()) -> dict:
11031103

11041104
result = 'process = cms.Process("' + self.__name + '")\n\n'
11051105

1106-
if self.source_():
1106+
if not self.source_() is None:
11071107
parts['source'] = (None, 'source = ' + self.source_().dumpPython(options))
11081108

1109-
if self.looper_():
1109+
if not self.looper_() is None:
11101110
parts['looper'] = (None, 'looper = ' + self.looper_().dumpPython())
11111111

11121112
parts.update(self._splitPythonList('psets', self.psets, options))

0 commit comments

Comments
 (0)