Skip to content

Commit e44ac2c

Browse files
authored
Merge pull request #46174 from perrotta/removeDeadAssignmentSiStripThreshold
Remove a dead assignment in CondFormats/SiStripObjects/src/SiStripThreshold.cc
2 parents f2ef4ee + f64ca2d commit e44ac2c

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

CondFormats/SiStripObjects/src/SiStripThreshold.cc

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,19 +143,15 @@ void SiStripThreshold::printSummary(std::stringstream& ss, const TrackerTopology
143143
minHth = 10000;
144144
minCth = 10000; //min value
145145
n = 0;
146-
firstStrip = 0;
147146
for (; it != eit; ++it) {
148147
itp = it + 1;
149148
firstStrip = it->getFirstStrip();
150149
if (itp != eit)
151150
stripRange = (itp->getFirstStrip() - firstStrip);
152151
else
153-
stripRange =
154-
firstStrip > 511
155-
? 768 - firstStrip
156-
: 512 -
157-
firstStrip; //*FIXME, I dont' know ithis class the strip number of a detector, so I assume wrongly that if the last firstStrip<511 the detector has only 512 strips. Clearly wrong. to be fixed
158-
152+
//*FIXME In this class the number of strips in the detector is not known, therefore it is (wrongly) assumed that
153+
// if the last firstStrip<511 then the detector has just 512 strips: this is clearly wrong, and it needs to be fixed
154+
stripRange = firstStrip > 511 ? 768 - firstStrip : 512 - firstStrip;
159155
addToStat(it->getLth(), stripRange, meanLth, rmsLth, minLth, maxLth);
160156
addToStat(it->getHth(), stripRange, meanHth, rmsHth, minHth, maxHth);
161157
addToStat(it->getClusth(), stripRange, meanCth, rmsCth, minCth, maxCth);

0 commit comments

Comments
 (0)