Skip to content

Commit e833ddb

Browse files
authored
Merge pull request #48563 from fwyzard/disable_ROCm_unit_tests
Disable HIP/ROCm device-side error tests
2 parents b0ea152 + 3b4b354 commit e833ddb

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

DataFormats/SoATemplate/test/SoALayoutAndView_t.hip.cc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,8 @@ int main(void) {
315315
}
316316

317317
// Validation of range checking in a kernel
318+
// Disable this test until ROCm provides a non-fatal way to assert in device code
319+
#if 0
318320
// Get a view like the default one, except for range checking
319321
RangeCheckingHostDeviceView soa1viewRangeChecking(d_soahdLayout);
320322

@@ -329,6 +331,7 @@ int main(void) {
329331
} catch (const std::runtime_error&) {
330332
std::cout << "Pass: expected range-check exception caught while executing the kernel." << std::endl;
331333
}
334+
#endif
332335

333336
std::cout << "OK" << std::endl;
334337
}

HeterogeneousCore/AlpakaInterface/test/alpaka/testBuffer.dev.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ using namespace ALPAKA_ACCELERATOR_NAMESPACE;
1414
namespace {
1515
constexpr size_t SIZE = 32;
1616

17+
// Disable this test for HIP/ROCm until ROCm or alpaka provide a non-fatal way to assert in device code.
18+
#ifndef ALPAKA_ACC_GPU_HIP_ENABLED
1719
void testDeviceSideError(Device const& device) {
1820
auto queue = Queue(device);
1921
auto buf_h = cms::alpakatools::make_host_buffer<int[]>(queue, SIZE);
@@ -43,6 +45,7 @@ namespace {
4345
alpaka::wait(queue);
4446
}
4547
}
48+
#endif // ALPAKA_ACC_GPU_HIP_ENABLED
4649
} // namespace
4750

4851
TEST_CASE("Test alpaka buffers for the " EDM_STRINGIZE(ALPAKA_ACCELERATOR_NAMESPACE) " backend",
@@ -83,9 +86,12 @@ TEST_CASE("Test alpaka buffers for the " EDM_STRINGIZE(ALPAKA_ACCELERATOR_NAMESP
8386
}
8487
}
8588

89+
// Disable this test for HIP/ROCm until ROCm or alpaka provide a non-fatal way to assert in device code.
90+
#ifndef ALPAKA_ACC_GPU_HIP_ENABLED
8691
SECTION("Buffer destruction after a device-side error") {
8792
for (auto const& device : devices) {
8893
REQUIRE_THROWS_AS(testDeviceSideError(device), std::runtime_error);
8994
}
9095
}
96+
#endif // ALPAKA_ACC_GPU_HIP_ENABLED
9197
}

0 commit comments

Comments
 (0)