Skip to content

Commit e9c2446

Browse files
committed
Add comment about setting total events to 1 since values already normalized per transaction. Fix typo in added memory description.
1 parent 8d2e3e0 commit e9c2446

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

PerfTools/AllocMonitor/scripts/edmModuleAllocJsonToCircles.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def formatToCircles(moduleTransitions):
2525
doc["resources"] += [
2626
{
2727
"name": "added %s" % transitionType,
28-
"description": "add memory per %s transition" % transitionType,
28+
"description": "added memory per %s transition" % transitionType,
2929
"title": "Amount of memory added to the process at the end of the %s transition" % transitionType,
3030
"unit": "kB"
3131
},
@@ -55,7 +55,8 @@ def formatToCircles(moduleTransitions):
5555
"unit": "kB"
5656
},
5757
]
58-
58+
# The circles code uses the "events" field to normalize the values between files with different number of events
59+
# Here we set it to 1 for the total events because the total is already normalized per transition
5960
doc["total"]["events"] = 1
6061
doc["total"]["label"] = "Job"
6162
doc["total"]["type"] = "Job"

0 commit comments

Comments
 (0)