Skip to content

Commit eaefa4c

Browse files
authored
Merge pull request #45572 from fwyzard/alpaka_make_device_view
Add specialisations of `make_device_view` with a Queue argument
2 parents a291790 + 0e26cb2 commit eaefa4c

File tree

9 files changed

+456
-57
lines changed

9 files changed

+456
-57
lines changed

DataFormats/TrackingRecHitSoA/interface/TrackingRecHitsDevice.h

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,13 @@ class TrackingRecHitDevice : public PortableDeviceCollection<TrackingRecHitLayou
2525
template <typename TQueue>
2626
explicit TrackingRecHitDevice(TQueue queue, uint32_t nHits, int32_t offsetBPIX2, uint32_t const* hitsModuleStart)
2727
: PortableDeviceCollection<TrackingRecHitLayout<TrackerTraits>, TDev>(nHits, queue), offsetBPIX2_{offsetBPIX2} {
28-
const auto device = alpaka::getDev(queue);
29-
30-
auto start_h = cms::alpakatools::make_device_view(device, hitsModuleStart, TrackerTraits::numberOfModules + 1);
28+
auto start_h = cms::alpakatools::make_device_view(queue, hitsModuleStart, TrackerTraits::numberOfModules + 1);
3129
auto start_d =
32-
cms::alpakatools::make_device_view(device, view().hitsModuleStart().data(), TrackerTraits::numberOfModules + 1);
30+
cms::alpakatools::make_device_view(queue, view().hitsModuleStart().data(), TrackerTraits::numberOfModules + 1);
3331
alpaka::memcpy(queue, start_d, start_h);
3432

3533
auto off_h = cms::alpakatools::make_host_view(offsetBPIX2_);
36-
auto off_d = cms::alpakatools::make_device_view(device, view().offsetBPIX2());
34+
auto off_d = cms::alpakatools::make_device_view(queue, view().offsetBPIX2());
3735
alpaka::memcpy(queue, off_d, off_h);
3836
}
3937

@@ -47,7 +45,7 @@ class TrackingRecHitDevice : public PortableDeviceCollection<TrackingRecHitLayou
4745
template <typename TQueue>
4846
void updateFromDevice(TQueue queue) {
4947
auto off_h = cms::alpakatools::make_host_view(offsetBPIX2_);
50-
auto off_d = cms::alpakatools::make_device_view(alpaka::getDev(queue), view().offsetBPIX2());
48+
auto off_d = cms::alpakatools::make_device_view(queue, view().offsetBPIX2());
5149
alpaka::memcpy(queue, off_h, off_d);
5250
}
5351

EventFilter/EcalRawToDigi/plugins/alpaka/EcalRawToDigiPortable.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,8 +98,8 @@ namespace ALPAKA_ACCELERATOR_NAMESPACE {
9898
OutputProduct digisDevEE{static_cast<int32_t>(config_.maxChannelsEE), queue};
9999
// reset the size scalar of the SoA
100100
// memset takes an alpaka view that is created from the scalar in a view to the device collection
101-
auto digiViewEB = cms::alpakatools::make_device_view<uint32_t>(alpaka::getDev(queue), digisDevEB.view().size());
102-
auto digiViewEE = cms::alpakatools::make_device_view<uint32_t>(alpaka::getDev(queue), digisDevEE.view().size());
101+
auto digiViewEB = cms::alpakatools::make_device_view<uint32_t>(queue, digisDevEB.view().size());
102+
auto digiViewEE = cms::alpakatools::make_device_view<uint32_t>(queue, digisDevEE.view().size());
103103
alpaka::memset(queue, digiViewEB, 0);
104104
alpaka::memset(queue, digiViewEE, 0);
105105

0 commit comments

Comments
 (0)