Merge pull request #48185 from felicepantaleo/TICL_recoToSim_Score_fix

[TICL] Reco to Sim score redefinition

Author: cmsbuild

SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByHitsProducer.cc

@@ -327,7 +327,6 @@ void AllTracksterToSimTracksterAssociatorsByHitsProducer::produce(edm::StreamID,
           unsigned int hitIndex = recoTracksterHitsAndFractions[i].index();
           const auto& recHit = rechitManager[hitIndex];
           float recoFraction = recoTracksterHitsAndFractions[i].fraction();
-          float squaredRecoFraction = recoFraction * recoFraction;
           float rechitEnergy = recHit.energy();
           float squaredRecHitEnergy = rechitEnergy * rechitEnergy;
           float recoSharedEnergy = rechitEnergy * recoFraction;
@@ -337,9 +336,15 @@ void AllTracksterToSimTracksterAssociatorsByHitsProducer::produce(edm::StreamID,
             auto simFraction = simTracksterElement.fraction();
             edm::Ref<std::vector<ticl::Trackster>> simTracksterRef(simTrackstersHandle, simTracksterIndex);
             float sharedEnergy = std::min(simFraction * rechitEnergy, recoSharedEnergy);
-            float squaredFraction =
-                std::min(squaredRecoFraction, (recoFraction - simFraction) * (recoFraction - simFraction));
-            float score = invDenominator * squaredFraction * squaredRecHitEnergy;
+            /* RecoToSim score logic:
+             - simFraction >= 0 && recoFraction == 0 : simtrackster contains non-reco associated elements : ignore in recoToSim association
+             - simFraction == 0 && recoFraction > 0 : rechits not present in sim trackster : penalty in score by recoFraction*E
+             - simFraction == 1 && recoFraction == 1 : good association
+             - 1 > recoFraction > simFraction > 0 :  sim does not contain some reco energy, penalty in score by the additional part : (recoFraction-simFraction)*E
+             - 1 > simFraction> recoFraction > 0 : consider as good association, as there is enough sim to cover the reco
+            */
+            float recoMinusSimFraction = std::max(0.f, recoFraction - simFraction);
+            float score = invDenominator * recoMinusSimFraction * recoMinusSimFraction * squaredRecHitEnergy;
             tracksterToSimTracksterMap->insert(recoTracksterRef, simTracksterRef, sharedEnergy, score);
           }
         }

SimCalorimetry/HGCalAssociatorProducers/plugins/AllTracksterToSimTracksterAssociatorsByLCsProducer.cc

@@ -225,7 +225,6 @@ void AllTracksterToSimTracksterAssociatorsByLCsProducer::produce(edm::StreamID,
           unsigned int layerClusterId = layerClustersIds[i];
           const auto& layerCluster = layerClusters[layerClusterId];
           float recoFraction = 1.f / recoTrackster.vertex_multiplicity(i);
-          float squaredRecoFraction = recoFraction * recoFraction;
           float squaredLayerClusterEnergy = layerCluster.energy() * layerCluster.energy();
           float recoSharedEnergy = layerCluster.energy() * recoFraction;
           float invLayerClusterEnergy = 1.f / layerCluster.energy();
@@ -236,9 +235,15 @@ void AllTracksterToSimTracksterAssociatorsByLCsProducer::produce(edm::StreamID,
             edm::Ref<std::vector<ticl::Trackster>> simTracksterRef(simTrackstersHandle, simTracksterIndex);
             float sharedEnergy = std::min(simSharedEnergy, recoSharedEnergy);
             float simFraction = simSharedEnergy * invLayerClusterEnergy;
-            float score = invDenominator *
-                          std::min(squaredRecoFraction, (recoFraction - simFraction) * (recoFraction - simFraction)) *
-                          squaredLayerClusterEnergy;
+            /* RecoToSim score logic:
+             - simFraction >= 0 && recoFraction == 0 : simtrackster contains non-reco associated elements : ignore in recoToSim association
+             - simFraction == 0 && recoFraction > 0 : rechits not present in sim trackster : penalty in score by recoFraction*E
+             - simFraction == 1 && recoFraction == 1 : good association
+             - 1 > recoFraction > simFraction > 0 :  sim does not contain some reco energy, penalty in score by the additional part : (recoFraction-simFraction)*E
+             - 1 > simFraction> recoFraction > 0 : consider as good association, as there is enough sim to cover the reco
+            */
+            float recoMinusSimFraction = std::max(0.f, recoFraction - simFraction);
+            float score = invDenominator * recoMinusSimFraction * recoMinusSimFraction * squaredLayerClusterEnergy;
             tracksterToSimTracksterMap->insert(recoTracksterRef, simTracksterRef, sharedEnergy, score);
           }
         }