Code check

Author: Sunanda

Calibration/HcalCalibAlgos/macros/CalibCorr.C

@@ -552,6 +552,7 @@ public:
   ~CalibThreshold() {}
 
   double threshold(unsigned int detId);
+
 private:
   double threshold(int subdet, int ieta, int depth);
   bool fileThreshold(const char* fname);
@@ -586,20 +587,21 @@ bool CalibThreshold::fileThreshold(const char* fname) {
           continue;  //ignore comment
         std::vector<std::string> items = splitString(std::string(buffer));
         if (items.size() != 7) {
-	  ++bad;
+          ++bad;
           std::cout << "Ignore  line: " << buffer << std::endl;
         } else {
           ++good;
-	  int ieta = std::atoi(items[0].c_str());
-	  int depth = std::atoi(items[2].c_str());
-	  double thr = std::atof(items[4].c_str());
-	  thresh_[std::pair<int, int>(ieta, depth)] = thr;
-	}
+          int ieta = std::atoi(items[0].c_str());
+          int depth = std::atoi(items[2].c_str());
+          double thr = std::atof(items[4].c_str());
+          thresh_[std::pair<int, int>(ieta, depth)] = thr;
+        }
       }
       fInput.close();
-      std::cout << "Reads " << all << " entries from " << fname << " with " << good << " Good and " << bad << " bad records" << std::endl;
+      std::cout << "Reads " << all << " entries from " << fname << " with " << good << " Good and " << bad
+                << " bad records" << std::endl;
       if (good > 0)
-	ok = true;
+        ok = true;
     }
   }
   return ok;
@@ -610,23 +612,19 @@ double CalibThreshold::threshold(int subdet, int ieta, int depth) {
                         {0.1, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2},
                         {0.1, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2},
                         {0.2, 0.3, 0.3, 0.3, 0.3, 0.3, 0.3}};
-  double cutHB[4][4] = {{0.1, 0.2, 0.3, 0.3}, 
-			{0.25, 0.25, 0.3, 0.3}, 
-			{0.4, 0.3, 0.3, 0.3}, 
-			{0.6, 0.4, 0.4, 0.5}};
+  double cutHB[4][4] = {{0.1, 0.2, 0.3, 0.3}, {0.25, 0.25, 0.3, 0.3}, {0.4, 0.3, 0.3, 0.3}, {0.6, 0.4, 0.4, 0.5}};
 
   double thr(0);
   if (ok_) {
     if ((form_ > 0) && (form_ <= 4)) {
       if (subdet == 2)
-	thr = cutHE[form_ - 1][depth - 1];
+        thr = cutHE[form_ - 1][depth - 1];
       else
-	thr = cutHB[form_ - 1][depth - 1];
+        thr = cutHB[form_ - 1][depth - 1];
     } else {
-      std::map<std::pair<int, int>, double>::const_iterator itr =
-	thresh_.find(std::pair<int, int>(ieta, depth));
+      std::map<std::pair<int, int>, double>::const_iterator itr = thresh_.find(std::pair<int, int>(ieta, depth));
       if (itr != thresh_.end())
-	thr = itr->second;
+        thr = itr->second;
     }
   }
   return thr;

Calibration/HcalCalibAlgos/macros/CalibFitPlots.C

@@ -536,7 +536,8 @@ results fitOneGauss(TH1D* hist, bool fitTwice, bool debug) {
     if (LowEdge < 0.5)
       LowEdge = 0.5;
     diff = Fit1->Value(1) - LowEdge;
-    HighEdge = (diff > fitrangeFactor1 * rms) ? (Fit1->Value(1) + fitrangeFactor1 * Fit1->Value(2)) : (Fit1->Value(1) + diff);
+    HighEdge =
+        (diff > fitrangeFactor1 * rms) ? (Fit1->Value(1) + fitrangeFactor1 * Fit1->Value(2)) : (Fit1->Value(1) + diff);
     if (HighEdge > 5.0)
       HighEdge = 5.0;
     if (debug)

Calibration/HcalCalibAlgos/macros/CalibMonitor.C

@@ -104,7 +104,8 @@
 //                               d: as the format for threshold application,
 //                               0: no threshold; 1: 2022 prompt data; 2:
 //                               2022 reco data; 3: 2023 prompt data; 4: 2025
-//                               Begin of Year.
+//                               Begin of Year; 5: Derived from the file
+//                               PFCuts_IOV_362975.txt.
 //                               (default = 0)
 //   etalo/etahi (int,int)     = |eta| ranges (default = 0:30)
 //   runlo  (int)              = lower value of run number to be included (+ve)

Calibration/HcalCalibAlgos/macros/CalibPlotProperties.C

@@ -103,7 +103,8 @@
 //                               d: as the format for threshold application,
 //                               0: no threshold; 1: 2022 prompt data; 2:
 //                               2022 reco data; 3: 2023 prompt data; 4: 2025
-//                               Begin of Year.
+//                               Begin of Year; 5: Derived from the file
+//                               PFCuts_IOV_362975.txt.
 //                               (default = 0)
 //   etalo/etahi (int,int)     = |eta| ranges (0:30)
 //   runlo  (int)              = lower value of run number to be included (+ve)

Calibration/HcalCalibAlgos/macros/CalibTree.C

@@ -82,7 +82,8 @@
 //                              For threshold h: the format for threshold
 //                              application, 0: no threshold; 1: 2022 prompt
 //                              data; 2: 2022 reco data; 3: 2023 prompt data;
-//                              4: 2025 Begin of Year.
+//                              4: 2025 Begin of Year; 5: Derived from the file
+//                              PFCuts_IOV_362975.txt.
 //                              (Default 0)
 //  useGen          (bool)    = use generator level momentum information (false)
 //  runlo           (int)     = lower value of run number to be included (+ve)
@@ -1241,8 +1242,8 @@ void CalibTree::writeCorrFactor(const char *corrFileName, int ietaMax) {
       int subdet, depth, zside, ieta, iphi;
       unpackDetId(detId, subdet, zside, ieta, iphi, depth);
       if (ieta <= ietaMax) {
-	double corrf = ((itr->second.first > 0.1) && (itr->second.first < 4.0)) ? itr->second.first : 1.0;
-	double dcorr = ((itr->second.first > 0.1) && (itr->second.first < 4.0)) ? itr->second.second : 0.0;
+        double corrf = ((itr->second.first > 0.1) && (itr->second.first < 4.0)) ? itr->second.first : 1.0;
+        double dcorr = ((itr->second.first > 0.1) && (itr->second.first < 4.0)) ? itr->second.second : 0.0;
         myfile << std::setw(10) << std::hex << detId << std::setw(10) << std::dec << zside * ieta << std::setw(10)
                << depth << std::setw(10) << corrf << " " << std::setw(10) << dcorr << std::endl;
         std::cout << corrf << ",";