Merge pull request #45522 from iarspider/iarspider-patch-20240722-1

[clang][cpp20] Fixed ambiguous-reversed-operator for LinearizedTrackState

Author: cmsbuild

RecoVertex/GaussianSumVertexFit/interface/PerigeeMultiLTS.h

@@ -96,7 +96,7 @@ class PerigeeMultiLTS : public LinearizedTrackState<5> {
 
   bool hasError() const override;
 
-  bool operator==(LinearizedTrackState<5>& other) const override;
+  bool operator==(const LinearizedTrackState<5>& other) const override;
 
   /** Creates the correct refitted state according to the results of the
    *  track refit.

RecoVertex/GaussianSumVertexFit/src/PerigeeMultiLTS.cc

@@ -110,7 +110,7 @@ AlgebraicSymMatrix33 PerigeeMultiLTS::predictedStateMomentumError() const {
   return collapsedStateLT->predictedStateMomentumError();
 }
 
-bool PerigeeMultiLTS::operator==(LinearizedTrackState<5>& other) const {
+bool PerigeeMultiLTS::operator==(const LinearizedTrackState<5>& other) const {
   const PerigeeMultiLTS* otherP = dynamic_cast<const PerigeeMultiLTS*>(&other);
   if (otherP == nullptr) {
     throw VertexException("PerigeeMultiLTS: don't know how to compare myself to non-perigee track state");

RecoVertex/KinematicFitPrimitives/interface/ParticleKinematicLinearizedTrackState.h

@@ -87,7 +87,7 @@ class ParticleKinematicLinearizedTrackState : public LinearizedTrackState<6> {
 
   RefCountedKinematicParticle particle() const;
 
-  bool operator==(LinearizedTrackState<6>& other) const override;
+  bool operator==(const LinearizedTrackState<6>& other) const override;
 
   bool hasError() const override;
 

RecoVertex/KinematicFitPrimitives/src/ParticleKinematicLinearizedTrackState.cc

@@ -55,7 +55,7 @@ TrackCharge ParticleKinematicLinearizedTrackState::charge() const { return part-
 
 RefCountedKinematicParticle ParticleKinematicLinearizedTrackState::particle() const { return part; }
 
-bool ParticleKinematicLinearizedTrackState::operator==(LinearizedTrackState<6>& other) const {
+bool ParticleKinematicLinearizedTrackState::operator==(const LinearizedTrackState<6>& other) const {
   const ParticleKinematicLinearizedTrackState* otherP =
       dynamic_cast<const ParticleKinematicLinearizedTrackState*>(&other);
   if (otherP == nullptr) {

RecoVertex/VertexPrimitives/interface/LinearizedTrackState.h

@@ -112,7 +112,7 @@ class LinearizedTrackState : public ReferenceCounted {
    */
   //   virtual ImpactPointMeasurement impactPointMeasurement() const = 0;
 
-  virtual bool operator==(LinearizedTrackState<N>& other) const = 0;
+  virtual bool operator==(const LinearizedTrackState<N>& other) const = 0;
 
   /** Creates the correct refitted state according to the results of the
    *  track refit.

RecoVertex/VertexTools/interface/PerigeeLinearizedTrackState.h

@@ -112,9 +112,9 @@ class PerigeeLinearizedTrackState final : public LinearizedTrackState<5> {
 
   bool hasError() const override;
 
-  bool operator==(LinearizedTrackState<5>& other) const override;
+  bool operator==(const LinearizedTrackState<5>& other) const override;
 
-  bool operator==(ReferenceCountingPointer<LinearizedTrackState<5> >& other) const;
+  bool operator==(const ReferenceCountingPointer<LinearizedTrackState<5> >& other) const;
 
   /** Creates the correct refitted state according to the results of the
    *  track refit.

RecoVertex/VertexTools/src/PerigeeLinearizedTrackState.cc

@@ -26,15 +26,15 @@ void PerigeeLinearizedTrackState::computeJacobians() const {
   jacobiansAvailable = true;
 }
 
-bool PerigeeLinearizedTrackState::operator==(LinearizedTrackState<5>& other) const {
+bool PerigeeLinearizedTrackState::operator==(const LinearizedTrackState<5>& other) const {
   const PerigeeLinearizedTrackState* otherP = dynamic_cast<const PerigeeLinearizedTrackState*>(&other);
   if (otherP == nullptr) {
     throw VertexException("PerigeeLinearizedTrackState: don't know how to compare myself to non-perigee track state");
   }
   return (otherP->track() == theTrack);
 }
 
-bool PerigeeLinearizedTrackState::operator==(ReferenceCountingPointer<LinearizedTrackState<5> >& other) const {
+bool PerigeeLinearizedTrackState::operator==(const ReferenceCountingPointer<LinearizedTrackState<5> >& other) const {
   const PerigeeLinearizedTrackState* otherP = dynamic_cast<const PerigeeLinearizedTrackState*>(other.get());
   if (otherP == nullptr) {
     throw VertexException("PerigeeLinearizedTrackState: don't know how to compare myself to non-perigee track state");