add a fillDescriptions to TrackWithVertexRefSelector

Author: mmusich

CommonTools/RecoAlgos/python/TrackWithVertexSelectorParams_cff.py

@@ -29,7 +29,4 @@
     zetaVtx = cms.double(1.0),
     rhoVtx = cms.double(0.2), ## tags used by b-tagging folks
     nSigmaDtVertex = cms.double(0),
-    # should _not_ be used for the TrackWithVertexRefSelector
-    copyExtras = cms.untracked.bool(False), ## copies also extras and rechits on RECO
-    copyTrajectories = cms.untracked.bool(False), # don't set this to true on AOD!
 )

CommonTools/UtilAlgos/interface/ObjectSelectorBase.h

@@ -14,7 +14,9 @@
 
 #include "FWCore/Framework/interface/Event.h"
 #include "FWCore/Framework/interface/ConsumesCollector.h"
+#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h"
 #include "FWCore/ParameterSet/interface/ParameterSet.h"
+#include "FWCore/ParameterSet/interface/ParameterSetDescription.h"
 #include "FWCore/Utilities/interface/InputTag.h"
 #include "CommonTools/UtilAlgos/interface/ParameterAdapter.h"
 #include <utility>
@@ -53,6 +55,10 @@ class ObjectSelectorBase : public Base {
   /// destructor
   ~ObjectSelectorBase() override {}
 
+  static void fillPSetDescription(edm::ParameterSetDescription& desc) {
+    desc.addUntracked<bool>("throwOnMissing", true);
+  };
+
 private:
   /// process one event
   bool filter(edm::Event& evt, const edm::EventSetup& es) override {

CommonTools/UtilAlgos/interface/ObjectSelectorProducer.h

@@ -4,6 +4,7 @@
 #include "FWCore/Framework/interface/Event.h"
 #include "FWCore/Framework/interface/ConsumesCollector.h"
 #include "FWCore/ParameterSet/interface/ParameterSet.h"
+#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h"
 #include "FWCore/Utilities/interface/InputTag.h"
 #include "CommonTools/UtilAlgos/interface/StoreManagerTrait.h"
 #include "CommonTools/UtilAlgos/interface/SelectedOutputCollectionTrait.h"
@@ -42,6 +43,14 @@ class ObjectSelectorProducer : public Base {
   /// destructor
   ~ObjectSelectorProducer() override {}
 
+  static void fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
+    edm::ParameterSetDescription desc;
+    desc.add<edm::InputTag>("src");
+    //Base::fillPSetDescription(desc);
+    Selector::fillPSetDescription(desc);
+    descriptions.addWithDefaultLabel(desc);
+  }
+
 private:
   /// process one event
   void produce(edm::Event& evt, const edm::EventSetup& es) override {

CommonTools/UtilAlgos/interface/SingleElementCollectionSelectorPlusEvent.h

@@ -13,6 +13,7 @@
  *
  */
 #include "FWCore/Framework/interface/ConsumesCollector.h"
+#include "FWCore/ParameterSet/interface/ConfigurationDescriptions.h"
 #include "CommonTools/UtilAlgos/interface/SelectionAdderTrait.h"
 #include "CommonTools/UtilAlgos/interface/StoreContainerTrait.h"
 #include "CommonTools/UtilAlgos/interface/ParameterAdapter.h"
@@ -44,6 +45,8 @@ struct SingleElementCollectionSelectorPlusEvent {
     }
   }
 
+  static void fillPSetDescription(edm::ParameterSetDescription &desc) { Selector::fillPSetDescription(desc); };
+
 private:
   StoreContainer selected_;
   Selector select_;

DQM/TrackingMonitorSource/python/TrackCollections2monitor_cff.py

@@ -280,10 +280,7 @@
     zetaVtx = 999.,
     #rhoVtx = 0.2, ## tags used by b-tagging folks
     rhoVtx = 999., ## tags used by b-tagging folks
-    nSigmaDtVertex = 0.,
-    # should _not_ be used for the TrackWithVertexRefSelector
-    copyExtras = False, ## copies also extras and rechits on RECO
-    copyTrajectories = False # don't set this to true on AOD!
+    nSigmaDtVertex = 0.
 )
 
 highPurityPV0p1 = trackAssociated2pvSelector.clone(

HLTrigger/Configuration/python/HLT_75e33/modules/hltTrackWithVertexRefSelectorBeforeSorting_cfi.py

@@ -1,8 +1,6 @@
 import FWCore.ParameterSet.Config as cms
 
 hltTrackWithVertexRefSelectorBeforeSorting = cms.EDProducer("TrackWithVertexRefSelector",
-    copyExtras = cms.untracked.bool(False),
-    copyTrajectories = cms.untracked.bool(False),
     d0Max = cms.double(999.0),
     dzMax = cms.double(999.0),
     etaMax = cms.double(5.0),

Validation/RecoTrack/python/TrackValidation_cff.py

@@ -1080,7 +1080,7 @@ def _uniqueFirstLayers(layerList):
 pixelTracksPt09 = trackRefSelector.clone( cut = cutstring )
 #pixelTracksPt09 = generalTracksPt09.clone(quality = ["undefQuality"], **_pixelTracksCustom)
 
-pixelTracksFromPV = generalTracksFromPV.clone(quality = "highPurity", ptMin = 0.0, ptMax = 99999., ptErrorCut = 99999., copyExtras = True, **_pixelTracksCustom)
+pixelTracksFromPV = generalTracksFromPV.clone(quality = "highPurity", ptMin = 0.0, ptMax = 99999., ptErrorCut = 99999., **_pixelTracksCustom)
 #pixelTracksFromPVPt09 = generalTracksPt09.clone(quality = ["loose","tight","highPurity"], vertexTag = "pixelVertices", src = "pixelTracksFromPV")
 pixelTracksFromPVPt09 = pixelTracksFromPV.clone(ptMin = 0.9)