From c0311c50e739bc7c9c2fcabea5a4a247a02fea55 Mon Sep 17 00:00:00 2001 From: Shahzad Malik Muzaffar Date: Wed, 26 Nov 2025 15:10:29 +0100 Subject: [PATCH] [L1] [LLVM21] Apply clang-tidy changes --- .../L1GlobalTrigger/src/L1GtfeExtWord.cc | 2 +- .../L1TRawToDigi/plugins/OmtfUnpacker.cc | 2 +- .../EMTFBlockCounters.cc | 4 +- .../implementations_stage2/EMTFBlockGEM.cc | 4 +- .../EMTFBlockHeaders.cc | 4 +- .../implementations_stage2/EMTFBlockME.cc | 4 +- .../implementations_stage2/EMTFBlockRPC.cc | 4 +- .../implementations_stage2/EMTFBlockSP.cc | 4 +- .../EMTFBlockTrailers.cc | 4 +- .../IntermediateMuonUnpacker.cc | 2 +- .../implementations_stage2/MuonUnpacker.cc | 2 +- .../RegionalMuonGMTUnpacker.cc | 2 +- EventFilter/L1TRawToDigi/src/AMC13Spec.cc | 1 + .../CSCTriggerPrimitives/src/CSCGEMMatcher.cc | 2 +- .../src/LateralityCoarsedProvider.cc | 1 + .../DTTriggerPhase2/src/MuonPathCorFitter.cc | 1 + .../DTTriggerPhase2/src/MuonPathSLFitter.cc | 7 +++- .../plugins/L1NNCaloTauEmulator.cc | 2 +- .../src/L1TCaloLayer1FetchLUTs.cc | 40 +++++++++---------- .../src/HardwareSortingMethods.cc | 4 +- .../src/PUSubtractionMethods.cc | 2 +- L1Trigger/L1TGEM/src/ME0StubAlgoPatUnit.cc | 4 +- .../L1TGlobalPrescalesVetosESProducer.cc | 1 + .../L1TGlobalPrescalesVetosFractESProducer.cc | 1 + .../plugins/backend/HGCalTowerProcessor.cc | 1 + .../plugins/backend/HGCalTowerProcessor_SA.cc | 1 + L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc | 10 ++--- .../L1TMuonOverlap/src/XMLConfigWriter.cc | 2 +- .../plugins/L1TrackJetEmulatorProducer.cc | 4 +- L1Trigger/L1TTrackMatch/src/pTFrom2Stubs.cc | 2 +- .../plugins/L1HPSPFTauProducer.cc | 2 + .../plugins/L1SeedConePFJetProducer.cc | 1 + .../src/pf/pfalgo2hgc_ref.cpp | 2 +- .../src/pf/pfalgo3_ref.cpp | 2 +- L1Trigger/TrackFindingTMTT/src/HTrphi.cc | 1 + .../TrackFindingTMTT/src/KFParamsComb.cc | 2 +- L1Trigger/TrackFindingTMTT/src/KFbase.cc | 4 +- .../src/PurgeDuplicate.cc | 2 + .../src/TTStubAlgorithm_official.cc | 1 + L1Trigger/VertexFinder/src/VertexFinder.cc | 12 +++--- .../src/L1TGlobalPrescalesVetosOnlineProd.cc | 6 +-- 41 files changed, 88 insertions(+), 71 deletions(-) diff --git a/DataFormats/L1GlobalTrigger/src/L1GtfeExtWord.cc b/DataFormats/L1GlobalTrigger/src/L1GtfeExtWord.cc index 20392efbbd880..f7ba51c61cf09 100644 --- a/DataFormats/L1GlobalTrigger/src/L1GtfeExtWord.cc +++ b/DataFormats/L1GlobalTrigger/src/L1GtfeExtWord.cc @@ -73,7 +73,7 @@ L1GtfeExtWord::~L1GtfeExtWord() { bool L1GtfeExtWord::operator==(const L1GtfeExtWord& result) const { // base class - const L1GtfeWord gtfeResult = result; + const L1GtfeWord& gtfeResult = result; const L1GtfeWord gtfeThis = *this; if (gtfeThis != gtfeResult) { diff --git a/EventFilter/L1TRawToDigi/plugins/OmtfUnpacker.cc b/EventFilter/L1TRawToDigi/plugins/OmtfUnpacker.cc index f98c19ec7d1f5..54db3a714afa6 100644 --- a/EventFilter/L1TRawToDigi/plugins/OmtfUnpacker.cc +++ b/EventFilter/L1TRawToDigi/plugins/OmtfUnpacker.cc @@ -281,7 +281,7 @@ namespace omtf { // loop over AMC's // unsigned int blockNum = 0; - for (auto amc : packetAmc13.payload()) { + for (const auto& amc : packetAmc13.payload()) { amc::BlockHeader bh = amc.blockHeader(); if (debug) { std::ostringstream str; diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockCounters.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockCounters.cc index 94f1bffb46846..478a1cae9a6d2 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockCounters.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockCounters.cc @@ -32,7 +32,7 @@ namespace l1t { namespace emtf { int CountersBlockUnpacker::checkFormat(const Block& block) { - auto payload = block.payload(); + const auto& payload = block.payload(); int errors = 0; //Check the number of 16-bit words @@ -91,7 +91,7 @@ namespace l1t { // Get the payload for this block, made up of 16-bit words (0xffff) // Format defined in MTF7Payload::getBlock() in src/Block.cc // payload[0] = bits 0-15, payload[1] = 16-31, payload[3] = 32-47, etc. - auto payload = block.payload(); + const auto& payload = block.payload(); // Check Format of Payload l1t::emtf::Counters Counters_; diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockGEM.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockGEM.cc index b2e618956e6f6..ccee6fcd0bd16 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockGEM.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockGEM.cc @@ -31,7 +31,7 @@ namespace l1t { namespace emtf { int GEMBlockUnpacker::checkFormat(const Block& block) { - auto payload = block.payload(); + const auto& payload = block.payload(); int errors = 0; // Check the number of 16-bit words @@ -125,7 +125,7 @@ namespace l1t { // Get the payload for this block, made up of 16-bit words (0xffff) // Format defined in MTF7Payload::getBlock() in src/Block.cc // payload[0] = bits 0-15, payload[1] = 16-31, payload[3] = 32-47, etc. - auto payload = block.payload(); + const auto& payload = block.payload(); // Run 3 has a different EMTF DAQ output format since August 26th // Computed as (Year - 2000)*2^9 + Month*2^5 + Day (see Block.cc and EMTFBlockTrailers.cc) diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockHeaders.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockHeaders.cc index 79d1245c092a7..f8bd24448433b 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockHeaders.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockHeaders.cc @@ -32,7 +32,7 @@ namespace l1t { namespace emtf { int HeadersBlockUnpacker::checkFormat(const Block& block) { - auto payload = block.payload(); + const auto& payload = block.payload(); int errors = 0; //Check the number of 16-bit words @@ -163,7 +163,7 @@ namespace l1t { // Get the payload for this block, made up of 16-bit words (0xffff) // Format defined in MTF7Payload::getBlock() in src/Block.cc // payload[0] = bits 0-15, payload[1] = 16-31, payload[3] = 32-47, etc. - auto payload = block.payload(); + const auto& payload = block.payload(); // Check Format of Payload l1t::emtf::AMC13Header AMC13Header_; diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc index 44d9d62a41826..c8393f52fd8d1 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc @@ -32,7 +32,7 @@ namespace l1t { namespace emtf { int MEBlockUnpacker::checkFormat(const Block& block) { - auto payload = block.payload(); + const auto& payload = block.payload(); int errors = 0; // Check the number of 16-bit words @@ -151,7 +151,7 @@ namespace l1t { // Get the payload for this block, made up of 16-bit words (0xffff) // Format defined in MTF7Payload::getBlock() in src/Block.cc // payload[0] = bits 0-15, payload[1] = 16-31, payload[3] = 32-47, etc. - auto payload = block.payload(); + const auto& payload = block.payload(); // Assign payload to 16-bit words uint16_t MEa = payload[0]; diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc index e123c7f853592..87afb84b9149d 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc @@ -33,7 +33,7 @@ namespace l1t { namespace emtf { int RPCBlockUnpacker::checkFormat(const Block& block) { - auto payload = block.payload(); + const auto& payload = block.payload(); int errors = 0; // Check the number of 16-bit words @@ -119,7 +119,7 @@ namespace l1t { // Get the payload for this block, made up of 16-bit words (0xffff) // Format defined in MTF7Payload::getBlock() in src/Block.cc // payload[0] = bits 0-15, payload[1] = 16-31, payload[3] = 32-47, etc. - auto payload = block.payload(); + const auto& payload = block.payload(); // Run 3 has a different EMTF DAQ output format since August 26th // Computed as (Year - 2000)*2^9 + Month*2^5 + Day (see Block.cc and EMTFBlockTrailers.cc) diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockSP.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockSP.cc index 17315d71b5d8e..8f23a6a728aa5 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockSP.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockSP.cc @@ -32,7 +32,7 @@ namespace l1t { namespace emtf { int SPBlockUnpacker::checkFormat(const Block& block) { - auto payload = block.payload(); + const auto& payload = block.payload(); int errors = 0; // Check the number of 16-bit words @@ -174,7 +174,7 @@ namespace l1t { // Get the payload for this block, made up of 16-bit words (0xffff) // Format defined in MTF7Payload::getBlock() in src/Block.cc // payload[0] = bits 0-15, payload[1] = 16-31, payload[3] = 32-47, etc. - auto payload = block.payload(); + const auto& payload = block.payload(); // FW version is computed as (Year - 2000)*2^9 + Month*2^5 + Day (see Block.cc and EMTFBlockTrailers.cc) bool useNNBits_ = getAlgoVersion() >= 11098; // FW versions >= 26.10.2021 diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockTrailers.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockTrailers.cc index 047ce57317a4e..6d9d833de1b68 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockTrailers.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockTrailers.cc @@ -32,7 +32,7 @@ namespace l1t { namespace emtf { int TrailersBlockUnpacker::checkFormat(const Block& block) { - auto payload = block.payload(); + const auto& payload = block.payload(); int errors = 0; //Check the number of 16-bit words @@ -128,7 +128,7 @@ namespace l1t { // Get the payload for this block, made up of 16-bit words (0xffff) // Format defined in MTF7Payload::getBlock() in src/Block.cc // payload[0] = bits 0-15, payload[1] = 16-31, payload[3] = 32-47, etc. - auto payload = block.payload(); + const auto& payload = block.payload(); // Check Format of Payload l1t::emtf::AMC13Trailer AMC13Trailer_; diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonUnpacker.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonUnpacker.cc index f72ea5205db2c..df1f156a6c08f 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonUnpacker.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonUnpacker.cc @@ -19,7 +19,7 @@ namespace l1t { return true; } - auto payload = block.payload(); + const auto& payload = block.payload(); int nBX, firstBX, lastBX; // Check if per BX zero suppression was enabled diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/MuonUnpacker.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/MuonUnpacker.cc index 1ac0e961479b3..842d735260f14 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/MuonUnpacker.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/MuonUnpacker.cc @@ -18,7 +18,7 @@ namespace l1t { return true; } - auto payload = block.payload(); + const auto& payload = block.payload(); int nBX, firstBX, lastBX; // Check if per BX zero suppression was enabled diff --git a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/RegionalMuonGMTUnpacker.cc b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/RegionalMuonGMTUnpacker.cc index 46d956f27eed1..422a2070ebe93 100644 --- a/EventFilter/L1TRawToDigi/plugins/implementations_stage2/RegionalMuonGMTUnpacker.cc +++ b/EventFilter/L1TRawToDigi/plugins/implementations_stage2/RegionalMuonGMTUnpacker.cc @@ -16,7 +16,7 @@ namespace l1t { return true; } - auto payload = block.payload(); + const auto& payload = block.payload(); int nBX, firstBX, lastBX; // Check if per BX zero suppression was enabled diff --git a/EventFilter/L1TRawToDigi/src/AMC13Spec.cc b/EventFilter/L1TRawToDigi/src/AMC13Spec.cc index ac3096846c3cd..a49969286f758 100644 --- a/EventFilter/L1TRawToDigi/src/AMC13Spec.cc +++ b/EventFilter/L1TRawToDigi/src/AMC13Spec.cc @@ -141,6 +141,7 @@ namespace amc13 { Header block_h(data++); std::vector headers; + headers.reserve(block_h.getNumberOfAMCs()); for (unsigned int i = 0; i < block_h.getNumberOfAMCs(); ++i) headers.push_back(amc::BlockHeader(data++)); diff --git a/L1Trigger/CSCTriggerPrimitives/src/CSCGEMMatcher.cc b/L1Trigger/CSCTriggerPrimitives/src/CSCGEMMatcher.cc index f308c6217ea5c..1af52d8d21d3e 100644 --- a/L1Trigger/CSCTriggerPrimitives/src/CSCGEMMatcher.cc +++ b/L1Trigger/CSCTriggerPrimitives/src/CSCGEMMatcher.cc @@ -277,7 +277,7 @@ uint16_t CSCGEMMatcher::mitigatedSlopeByConsistency(const CSCCLCTDigi& clct, const bool isME1a(station_ == 1 and clct.getKeyStrip() > CSCConstants::MAX_HALF_STRIP_ME1B); // extract hit values from CLCT hit matrix - std::vector> CLCTHitMatrix = clct.getHits(); + const std::vector>& CLCTHitMatrix = clct.getHits(); int CLCTHits[6] = {-1, -1, -1, -1, -1, -1}; for (unsigned layer = 0; layer < CLCTHitMatrix.size(); ++layer) { diff --git a/L1Trigger/DTTriggerPhase2/src/LateralityCoarsedProvider.cc b/L1Trigger/DTTriggerPhase2/src/LateralityCoarsedProvider.cc index e37281d999e24..9b8f6c08a5e71 100644 --- a/L1Trigger/DTTriggerPhase2/src/LateralityCoarsedProvider.cc +++ b/L1Trigger/DTTriggerPhase2/src/LateralityCoarsedProvider.cc @@ -249,6 +249,7 @@ std::vector> LateralityCoarsedProvider::convertString(std::st for (size_t i = 0; i < chain.size(); i += 4) { std::vector group; + group.reserve(4); for (size_t j = 0; j < 4; j++) { group.push_back(chain[i + j] - '0'); // Convert the character to integer } diff --git a/L1Trigger/DTTriggerPhase2/src/MuonPathCorFitter.cc b/L1Trigger/DTTriggerPhase2/src/MuonPathCorFitter.cc index f68d1df8cef81..954e0d356baef 100644 --- a/L1Trigger/DTTriggerPhase2/src/MuonPathCorFitter.cc +++ b/L1Trigger/DTTriggerPhase2/src/MuonPathCorFitter.cc @@ -407,6 +407,7 @@ void MuonPathCorFitter::fillLuts() { ifin2sl >> line; std::vector myNumbers; + myNumbers.reserve(line.size()); for (size_t i = 0; i < line.size(); i++) { // This converts the char into an int and pushes it into vec myNumbers.push_back(line[i] - '0'); // The digits will be in the same order as before diff --git a/L1Trigger/DTTriggerPhase2/src/MuonPathSLFitter.cc b/L1Trigger/DTTriggerPhase2/src/MuonPathSLFitter.cc index bd86e8a3b7da6..c2833414f51c0 100644 --- a/L1Trigger/DTTriggerPhase2/src/MuonPathSLFitter.cc +++ b/L1Trigger/DTTriggerPhase2/src/MuonPathSLFitter.cc @@ -68,7 +68,7 @@ void MuonPathSLFitter::run(edm::Event &iEvent, // fit per SL (need to allow for multiple outputs for a single mpath) // for (auto &muonpath : muonpaths) { if (!muonpaths.empty()) { - auto muonpath = muonpaths[0]; + const auto &muonpath = muonpaths[0]; int rawId = muonpath->primitive(0)->cameraId(); if (muonpath->primitive(0)->cameraId() == -1) { rawId = muonpath->primitive(1)->cameraId(); @@ -79,7 +79,7 @@ void MuonPathSLFitter::run(edm::Event &iEvent, for (size_t i = 0; i < muonpaths.size(); i++) { auto muonpath = muonpaths[i]; - auto lats = lateralities[i]; + const auto &lats = lateralities[i]; analyze(muonpath, lats, metaPrimitives); } } @@ -448,6 +448,7 @@ void MuonPathSLFitter::fillLuts() { ifinsl1 >> line; std::vector myNumbers; + myNumbers.reserve(line.size()); for (size_t i = 0; i < line.size(); i++) { // This converts the char into an int and pushes it into vec myNumbers.push_back(line[i] - '0'); // The digits will be in the same order as before @@ -461,6 +462,7 @@ void MuonPathSLFitter::fillLuts() { ifinsl2 >> line; std::vector myNumbers; + myNumbers.reserve(line.size()); for (size_t i = 0; i < line.size(); i++) { // This converts the char into an int and pushes it into vec myNumbers.push_back(line[i] - '0'); // The digits will be in the same order as before @@ -474,6 +476,7 @@ void MuonPathSLFitter::fillLuts() { ifinsl3 >> line; std::vector myNumbers; + myNumbers.reserve(line.size()); for (size_t i = 0; i < line.size(); i++) { // This converts the char into an int and pushes it into vec myNumbers.push_back(line[i] - '0'); // The digits will be in the same order as before diff --git a/L1Trigger/L1CaloTrigger/plugins/L1NNCaloTauEmulator.cc b/L1Trigger/L1CaloTrigger/plugins/L1NNCaloTauEmulator.cc index f69d30d151e8c..5bd2774559452 100644 --- a/L1Trigger/L1CaloTrigger/plugins/L1NNCaloTauEmulator.cc +++ b/L1Trigger/L1CaloTrigger/plugins/L1NNCaloTauEmulator.cc @@ -789,7 +789,7 @@ void L1NNCaloTauEmulator::produce(edm::Event& iEvent, const edm::EventSetup& eSe for (int clNxMIdx = 0; clNxMIdx < Nclusters_CE; clNxMIdx++) { // Indexing of cl3ds is the same as the one of clNxMs - InputHGCluster HGClu = HGClusters[clNxMIdx]; + const InputHGCluster& HGClu = HGClusters[clNxMIdx]; // Fill inputs for Tensorflow inference for (int eta = 0; eta < IEta_dim; ++eta) { diff --git a/L1Trigger/L1TCaloLayer1/src/L1TCaloLayer1FetchLUTs.cc b/L1Trigger/L1TCaloLayer1/src/L1TCaloLayer1FetchLUTs.cc index 19b699d7d7f91..db2b262b9c348 100644 --- a/L1Trigger/L1TCaloLayer1/src/L1TCaloLayer1FetchLUTs.cc +++ b/L1Trigger/L1TCaloLayer1/src/L1TCaloLayer1FetchLUTs.cc @@ -27,15 +27,15 @@ using namespace l1tcalo; bool L1TCaloLayer1FetchLUTs( - const L1TCaloLayer1FetchLUTsTokens &iTokens, - const edm::EventSetup &iSetup, - std::vector, nCalSideBins>, nCalEtaBins> > &eLUT, - std::vector, nCalSideBins>, nCalEtaBins> > &hLUT, - std::vector, nHfEtaBins> > &hfLUT, - std::vector &hcalFBLUT, - std::vector &ePhiMap, - std::vector &hPhiMap, - std::vector &hfPhiMap, + const L1TCaloLayer1FetchLUTsTokens& iTokens, + const edm::EventSetup& iSetup, + std::vector, nCalSideBins>, nCalEtaBins> >& eLUT, + std::vector, nCalSideBins>, nCalEtaBins> >& hLUT, + std::vector, nHfEtaBins> >& hfLUT, + std::vector& hcalFBLUT, + std::vector& ePhiMap, + std::vector& hPhiMap, + std::vector& hfPhiMap, bool useLSB, bool useCalib, bool useECALLUT, @@ -44,7 +44,7 @@ bool L1TCaloLayer1FetchLUTs( bool useHCALFBLUT, int fwVersion) { int hfValid = 1; - const HcalTrigTowerGeometry &pG = iSetup.getData(iTokens.geom_); + const HcalTrigTowerGeometry& pG = iSetup.getData(iTokens.geom_); if (!pG.use1x1()) { edm::LogError("L1TCaloLayer1FetchLUTs") << "Using Stage2-Layer1 but HCAL Geometry has use1x1 = 0! HF will be suppressed. Check Global Tag, etc."; @@ -71,7 +71,7 @@ bool L1TCaloLayer1FetchLUTs( // etBin = size of Real ET Bins vector // phiBin = max(Real Phi Bins vector) // So, index = phiBin*etBin*28+etBin*28+ieta - auto ecalScaleETBins = caloParams.layer1ECalScaleETBins(); + const auto& ecalScaleETBins = caloParams.layer1ECalScaleETBins(); auto ecalScalePhiBins = caloParams.layer1ECalScalePhiBins(); if (ecalScalePhiBins.empty()) { // Backwards-compatibility (no phi binning) @@ -81,14 +81,14 @@ bool L1TCaloLayer1FetchLUTs( return false; } size_t numEcalPhiBins = (*std::max_element(ecalScalePhiBins.begin(), ecalScalePhiBins.end())) + 1; - auto ecalSF = caloParams.layer1ECalScaleFactors(); - auto ecalZSF = caloParams.layer1ECalZSFactors(); + const auto& ecalSF = caloParams.layer1ECalScaleFactors(); + const auto& ecalZSF = caloParams.layer1ECalZSFactors(); if (ecalSF.size() != ecalScaleETBins.size() * numEcalPhiBins * 28) { edm::LogError("L1TCaloLayer1FetchLUTs") << "caloParams.layer1ECalScaleFactors().size() != " "caloParams.layer1ECalScaleETBins().size()*numEcalPhiBins*28 !!"; return false; } - auto hcalScaleETBins = caloParams.layer1HCalScaleETBins(); + const auto& hcalScaleETBins = caloParams.layer1HCalScaleETBins(); auto hcalScalePhiBins = caloParams.layer1HCalScalePhiBins(); if (hcalScalePhiBins.empty()) { hcalScalePhiBins.resize(36, 0); @@ -97,8 +97,8 @@ bool L1TCaloLayer1FetchLUTs( return false; } size_t numHcalPhiBins = (*std::max_element(hcalScalePhiBins.begin(), hcalScalePhiBins.end())) + 1; - auto hcalSF = caloParams.layer1HCalScaleFactors(); - auto hcalZSF = caloParams.layer1HCalZSFactors(); + const auto& hcalSF = caloParams.layer1HCalScaleFactors(); + const auto& hcalZSF = caloParams.layer1HCalZSFactors(); if (hcalSF.size() != hcalScaleETBins.size() * numHcalPhiBins * 28) { edm::LogError("L1TCaloLayer1FetchLUTs") << "caloParams.layer1HCalScaleFactors().size() != " "caloParams.layer1HCalScaleETBins().size()*numHcalPhiBins*28 !!"; @@ -110,7 +110,7 @@ bool L1TCaloLayer1FetchLUTs( // etBin = size of Real ET Bins vector // phiBin = max(Real Phi Bins vector) // So, index = phiBin*etBin*12+etBin*12+ieta - auto hfScaleETBins = caloParams.layer1HFScaleETBins(); + const auto& hfScaleETBins = caloParams.layer1HFScaleETBins(); auto hfScalePhiBins = caloParams.layer1HFScalePhiBins(); if (hfScalePhiBins.empty()) { hfScalePhiBins.resize(36, 0); @@ -119,7 +119,7 @@ bool L1TCaloLayer1FetchLUTs( return false; } size_t numHFPhiBins = (*std::max_element(hfScalePhiBins.begin(), hfScalePhiBins.end())) + 1; - auto hfSF = caloParams.layer1HFScaleFactors(); + const auto& hfSF = caloParams.layer1HFScaleFactors(); if (hfSF.size() != hfScaleETBins.size() * numHFPhiBins * 12) { edm::LogError("L1TCaloLayer1FetchLUTs") << "caloParams.layer1HFScaleFactors().size() != caloParams.layer1HFScaleETBins().size()*numHFPhiBins*12 !!"; @@ -136,8 +136,8 @@ bool L1TCaloLayer1FetchLUTs( // HCAL FB LUT will be a 1*28 array: // ieta = 28 eta scale factors (1 .. 28) // So, index = ieta - auto fbLUTUpper = caloParams.layer1HCalFBLUTUpper(); - auto fbLUTLower = caloParams.layer1HCalFBLUTLower(); + const auto& fbLUTUpper = caloParams.layer1HCalFBLUTUpper(); + const auto& fbLUTLower = caloParams.layer1HCalFBLUTLower(); // Only check for HCAL FB LUT if useHCALFBLUT = true if (useHCALFBLUT) { if (fbLUTUpper.size() != nCalEtaBins) { diff --git a/L1Trigger/L1TCalorimeter/src/HardwareSortingMethods.cc b/L1Trigger/L1TCalorimeter/src/HardwareSortingMethods.cc index 5e975ce4d4ed8..afb8604098d2c 100644 --- a/L1Trigger/L1TCalorimeter/src/HardwareSortingMethods.cc +++ b/L1Trigger/L1TCalorimeter/src/HardwareSortingMethods.cc @@ -544,8 +544,8 @@ namespace l1t { super_sort_matrix_rows(non_iso_stage2_row_sorted_matrix_sig, N_EGAMMA_SECOND_GROUP_SIZE, N_KEEP_EGAMMA); //Prepare output - std::vector sorted_iso_egammas = iso_stage2_super_sorted_matrix_sig[0]; - std::vector sorted_noniso_egammas = non_iso_stage2_super_sorted_matrix_sig[0]; + const std::vector& sorted_iso_egammas = iso_stage2_super_sorted_matrix_sig[0]; + const std::vector& sorted_noniso_egammas = non_iso_stage2_super_sorted_matrix_sig[0]; //verbose = false; diff --git a/L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc b/L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc index 104c7a62cd825..c4cafadb39d38 100644 --- a/L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc +++ b/L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc @@ -69,7 +69,7 @@ namespace l1t { void RegionCorrection(const std::vector ®ions, std::vector *subRegions, CaloParamsHelper const *params) { - std::string regionPUSType = params->regionPUSType(); + const std::string ®ionPUSType = params->regionPUSType(); if (regionPUSType == "None") { for (std::vector::const_iterator notCorrectedRegion = regions.begin(); diff --git a/L1Trigger/L1TGEM/src/ME0StubAlgoPatUnit.cc b/L1Trigger/L1TGEM/src/ME0StubAlgoPatUnit.cc index fb2137aa8ba84..beaabc078066e 100644 --- a/L1Trigger/L1TGEM/src/ME0StubAlgoPatUnit.cc +++ b/L1Trigger/L1TGEM/src/ME0StubAlgoPatUnit.cc @@ -17,7 +17,7 @@ std::pair, double> l1t::me0::calculateCentroids( std::vector bxs; for (int ly = 0; ly < static_cast(maskedData.size()); ++ly) { auto data = maskedData[ly]; - auto bxData = partitionBxData[ly]; + const auto& bxData = partitionBxData[ly]; const auto temp = findCentroid(data); double curCentroid = temp.first; std::vector hitsIndices = temp.second; @@ -199,4 +199,4 @@ ME0StubPrimitive l1t::me0::patUnit(const std::vector& data, best.updateQuality(); return best; -} \ No newline at end of file +} diff --git a/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosESProducer.cc b/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosESProducer.cc index 2d4825b32bf42..0c5c5a62bd823 100644 --- a/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosESProducer.cc +++ b/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosESProducer.cc @@ -237,6 +237,7 @@ L1TGlobalPrescalesVetosESProducer::L1TGlobalPrescalesVetosESProducer(const edm:: // veto mask // Setting veto mask to default 0 (no veto) + triggerVetoMasks.reserve(m_numberPhysTriggers); for (unsigned int iAlg = 0; iAlg < m_numberPhysTriggers; iAlg++) triggerVetoMasks.push_back(0); diff --git a/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosFractESProducer.cc b/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosFractESProducer.cc index be4c7876fdb64..13135b1117ff1 100644 --- a/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosFractESProducer.cc +++ b/L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosFractESProducer.cc @@ -237,6 +237,7 @@ L1TGlobalPrescalesVetosFractESProducer::L1TGlobalPrescalesVetosFractESProducer(c // veto mask // Setting veto mask to default 0 (no veto) + triggerVetoMasks.reserve(m_numberPhysTriggers); for (unsigned int iAlg = 0; iAlg < m_numberPhysTriggers; iAlg++) triggerVetoMasks.push_back(0); diff --git a/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor.cc b/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor.cc index c726d2b337206..84d90fc5b2ecd 100644 --- a/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor.cc +++ b/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor.cc @@ -30,6 +30,7 @@ class HGCalTowerProcessor : public HGCalTowerProcessorBase { /* create a persistent vector of pointers to the towerMaps */ std::vector> towerMapsPtrs; + towerMapsPtrs.reserve(towerMapCollHandle->size()); for (unsigned i = 0; i < towerMapCollHandle->size(); ++i) { towerMapsPtrs.emplace_back(towerMapCollHandle, i); } diff --git a/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor_SA.cc b/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor_SA.cc index cf269f7d1904d..d071b6538cda1 100644 --- a/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor_SA.cc +++ b/L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor_SA.cc @@ -26,6 +26,7 @@ class HGCalTowerProcessorSA : public HGCalTowerProcessorBase { /* create a persistent vector of pointers to the towerMaps */ std::vector> towerMapsPtrs; + towerMapsPtrs.reserve(towerMapCollHandle->size()); for (unsigned i = 0; i < towerMapCollHandle->size(); ++i) { towerMapsPtrs.emplace_back(towerMapCollHandle, i); } diff --git a/L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc b/L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc index 8fe42153e0897..21aebd4c68fbe 100644 --- a/L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc +++ b/L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc @@ -12,12 +12,12 @@ /////////////////////////////////////////////////////// /////////////////////////////////////////////////////// AlgoMuon OMTFSorter::sortSingleResult(const OMTFResult& aResult) { - OMTFResult::vector1D pdfValsVec = aResult.getSummaryVals(); + const OMTFResult::vector1D& pdfValsVec = aResult.getSummaryVals(); OMTFResult::vector1D nHitsVec = aResult.getSummaryHits(); - OMTFResult::vector1D refPhiVec = aResult.getRefPhis(); - OMTFResult::vector1D refEtaVec = aResult.getRefEtas(); - OMTFResult::vector1D hitsVec = aResult.getHitsWord(); - OMTFResult::vector1D refPhiRHitVec = aResult.getRefPhiRHits(); + const OMTFResult::vector1D& refPhiVec = aResult.getRefPhis(); + const OMTFResult::vector1D& refEtaVec = aResult.getRefEtas(); + const OMTFResult::vector1D& hitsVec = aResult.getHitsWord(); + const OMTFResult::vector1D& refPhiRHitVec = aResult.getRefPhiRHits(); assert(pdfValsVec.size() == nHitsVec.size()); diff --git a/L1Trigger/L1TMuonOverlap/src/XMLConfigWriter.cc b/L1Trigger/L1TMuonOverlap/src/XMLConfigWriter.cc index 8ecca8ab9ba94..e3f6c98719058 100644 --- a/L1Trigger/L1TMuonOverlap/src/XMLConfigWriter.cc +++ b/L1Trigger/L1TMuonOverlap/src/XMLConfigWriter.cc @@ -311,7 +311,7 @@ void XMLConfigWriter::writeResultsData(xercesc::DOMElement* aTopElement, unsigned int iRegion, const Key& aKey, const OMTFResult& aResult) { - OMTFResult::vector2D results = aResult.getResults(); + const OMTFResult::vector2D& results = aResult.getResults(); std::ostringstream stringStr; ///Write GP key parameters diff --git a/L1Trigger/L1TTrackMatch/plugins/L1TrackJetEmulatorProducer.cc b/L1Trigger/L1TTrackMatch/plugins/L1TrackJetEmulatorProducer.cc index da0f083a0e171..e4194de7a8090 100644 --- a/L1Trigger/L1TTrackMatch/plugins/L1TrackJetEmulatorProducer.cc +++ b/L1Trigger/L1TTrackMatch/plugins/L1TrackJetEmulatorProducer.cc @@ -190,8 +190,8 @@ void L1TrackJetEmulatorProducer::produce(Event &iEvent, const EventSetup &iSetup // logic: loop over z bins find tracks in this bin and arrange them in a 2D eta-phi matrix for (unsigned int zbin = 0; zbin < zmins.size(); ++zbin) { // initialize matrices for every z bin - z0_intern zmin = zmins[zbin]; - z0_intern zmax = zmaxs[zbin]; + const z0_intern &zmin = zmins[zbin]; + const z0_intern &zmax = zmaxs[zbin]; TrackJetEmulationEtaPhiBin epbins[phiBins_][etaBins_]; diff --git a/L1Trigger/L1TTrackMatch/src/pTFrom2Stubs.cc b/L1Trigger/L1TTrackMatch/src/pTFrom2Stubs.cc index fee8fbf978cc7..ee0b51693f3e7 100644 --- a/L1Trigger/L1TTrackMatch/src/pTFrom2Stubs.cc +++ b/L1Trigger/L1TTrackMatch/src/pTFrom2Stubs.cc @@ -23,7 +23,7 @@ namespace pTFrom2Stubs { //loop over L1Track's stubs int rsize = vecStubRefs.size(); for (int j = 0; j < rsize; ++j) { - edm::Ref >, TTStub > stubRef = + const edm::Ref >, TTStub >& stubRef = vecStubRefs.at(j); const TTStub* stub = &(*stubRef); MeasurementPoint localPos = stub->clusterRef(0)->findAverageLocalCoordinates(); diff --git a/L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cc b/L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cc index c1a0dddd150be..4f25d7380c669 100644 --- a/L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cc +++ b/L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cc @@ -76,12 +76,14 @@ void L1HPSPFTauProducer::produce(edm::StreamID, edm::Event& iEvent, const edm::E //adding collection std::vector> particles; + particles.reserve((*l1PFCandidates).size()); for (unsigned i = 0; i < (*l1PFCandidates).size(); i++) { particles.push_back(edm::Ptr(l1PFCandidates, i)); } //get the jets std::vector> jets; + jets.reserve((*l1PFJets).size()); for (unsigned int i = 0; i < (*l1PFJets).size(); i++) { jets.push_back(edm::Ptr(l1PFJets, i)); // diff --git a/L1Trigger/Phase2L1ParticleFlow/plugins/L1SeedConePFJetProducer.cc b/L1Trigger/Phase2L1ParticleFlow/plugins/L1SeedConePFJetProducer.cc index 7ca6334fe5615..5f366b04fafd2 100644 --- a/L1Trigger/Phase2L1ParticleFlow/plugins/L1SeedConePFJetProducer.cc +++ b/L1Trigger/Phase2L1ParticleFlow/plugins/L1SeedConePFJetProducer.cc @@ -80,6 +80,7 @@ void L1SeedConePFJetProducer::produce(edm::StreamID /*unused*/, edm::Handle l1PFCandidates; iEvent.getByToken(l1PFToken, l1PFCandidates); std::vector> particles; + particles.reserve((*l1PFCandidates).size()); for (unsigned i = 0; i < (*l1PFCandidates).size(); i++) { particles.push_back(edm::Ptr(l1PFCandidates, i)); } diff --git a/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo2hgc_ref.cpp b/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo2hgc_ref.cpp index 6869a84f224cc..f396f3f224fae 100644 --- a/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo2hgc_ref.cpp +++ b/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo2hgc_ref.cpp @@ -205,7 +205,7 @@ void l1ct::PFAlgo2HGCEmulator::run(const PFInputRegion& in, OutputRegion& out) c for (unsigned int ic = 0; ic < nCALO; ++ic) { if (calo_sumtk[ic] > 0) { pt_t ptdiff = in.hadcalo[ic].hwPt - calo_sumtk[ic]; - pt2_t sigmamult = + const pt2_t& sigmamult = calo_sumtkErr2[ic]; // + (calo_sumtkErr2[ic] >> 1)); // this multiplies by 1.5 = sqrt(1.5)^2 ~ (1.2)^2 if (debug_ && (in.hadcalo[ic].hwPt > 0)) { dbgPrintf( diff --git a/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo3_ref.cpp b/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo3_ref.cpp index 0bb6ff36d4cc6..b3b108a53bb58 100644 --- a/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo3_ref.cpp +++ b/L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo3_ref.cpp @@ -461,7 +461,7 @@ void l1ct::PFAlgo3Emulator::run(const PFInputRegion& in, OutputRegion& out) cons for (unsigned int ic = 0; ic < nCALO; ++ic) { if (calo_sumtk[ic] > 0) { dpt_t ptdiff = dpt_t(hadcalo_subem[ic].hwPt) - dpt_t(calo_sumtk[ic]); - pt2_t sigmamult = calo_sumtkErr2 + const pt2_t& sigmamult = calo_sumtkErr2 [ic]; // before we did (calo_sumtkErr2[ic] + (calo_sumtkErr2[ic] >> 1)); to multiply by 1.5 = sqrt(1.5)^2 ~ (1.2)^2 if (debug_ && (hadcalo_subem[ic].hwPt > 0)) { dbgPrintf( diff --git a/L1Trigger/TrackFindingTMTT/src/HTrphi.cc b/L1Trigger/TrackFindingTMTT/src/HTrphi.cc index 36554015c700d..6a20dda6551af 100644 --- a/L1Trigger/TrackFindingTMTT/src/HTrphi.cc +++ b/L1Trigger/TrackFindingTMTT/src/HTrphi.cc @@ -166,6 +166,7 @@ namespace tmtt { cellCenters_.clear(); for (unsigned int m = 0; m < nBinsQoverPtAxis_; m++) { std::vector > binCenters; + binCenters.reserve(nBinsPhiTrkAxis_); for (unsigned int c = 0; c < nBinsPhiTrkAxis_; c++) binCenters.push_back(this->helix2Dhough(m, c)); cellCenters_.push_back(binCenters); diff --git a/L1Trigger/TrackFindingTMTT/src/KFParamsComb.cc b/L1Trigger/TrackFindingTMTT/src/KFParamsComb.cc index 119f6969c8eb8..ec20962d2657b 100644 --- a/L1Trigger/TrackFindingTMTT/src/KFParamsComb.cc +++ b/L1Trigger/TrackFindingTMTT/src/KFParamsComb.cc @@ -185,7 +185,7 @@ namespace tmtt { /* Get physical helix params */ TVectorD KFParamsComb::trackParams(const KalmanState* state) const { - TVectorD vecX = state->vectorX(); + const TVectorD& vecX = state->vectorX(); TVectorD vecY(nHelixPar_); vecY[QOVERPT] = 2. * vecX[INV2R] / settings_->invPtToInvR(); vecY[PHI0] = reco::deltaPhi(vecX[PHI0] + sectorPhi(), 0.); diff --git a/L1Trigger/TrackFindingTMTT/src/KFbase.cc b/L1Trigger/TrackFindingTMTT/src/KFbase.cc index afff3cbc7709c..f3abda950ef7b 100644 --- a/L1Trigger/TrackFindingTMTT/src/KFbase.cc +++ b/L1Trigger/TrackFindingTMTT/src/KFbase.cc @@ -407,8 +407,8 @@ namespace tmtt { numUpdateCalls_++; // For monitoring, count calls to updator per track. // Helix params & their covariance. - TVectorD vecX = state->vectorX(); - TMatrixD matC = state->matrixC(); + const TVectorD &vecX = state->vectorX(); + const TMatrixD &matC = state->matrixC(); if (state->barrel() && !stub->barrel()) { if (settings_->kalmanDebugLevel() >= 4) { PrintL1trk() << "STATE BARREL TO ENDCAP BEFORE "; diff --git a/L1Trigger/TrackFindingTracklet/src/PurgeDuplicate.cc b/L1Trigger/TrackFindingTracklet/src/PurgeDuplicate.cc index b64f81e99d30f..7750615bfcfbb 100644 --- a/L1Trigger/TrackFindingTracklet/src/PurgeDuplicate.cc +++ b/L1Trigger/TrackFindingTracklet/src/PurgeDuplicate.cc @@ -340,9 +340,11 @@ void PurgeDuplicate::execute(std::vector& outputtracks, unsigned int iSec std::vector stubsTrk2 = inputstublists_[rejetrk]; std::vector stubsTrk1indices; std::vector stubsTrk2indices; + stubsTrk1indices.reserve(stubsTrk1.size()); for (unsigned int stub1it = 0; stub1it < stubsTrk1.size(); stub1it++) { stubsTrk1indices.push_back(stubsTrk1[stub1it]->l1tstub()->uniqueIndex()); } + stubsTrk2indices.reserve(stubsTrk2.size()); for (unsigned int stub2it = 0; stub2it < stubsTrk2.size(); stub2it++) { stubsTrk2indices.push_back(stubsTrk2[stub2it]->l1tstub()->uniqueIndex()); } diff --git a/L1Trigger/TrackTrigger/src/TTStubAlgorithm_official.cc b/L1Trigger/TrackTrigger/src/TTStubAlgorithm_official.cc index 8b83787528ca4..c7b35034d54f2 100644 --- a/L1Trigger/TrackTrigger/src/TTStubAlgorithm_official.cc +++ b/L1Trigger/TrackTrigger/src/TTStubAlgorithm_official.cc @@ -169,6 +169,7 @@ float TTStubAlgorithm_official::degradeBend(bool psModul // Then you alternate large-small-large-small....large. In the middle, you // put either large or small, depending if group size is odd or not + groups.reserve(numLargeGroups / 2); for (unsigned int i = 0; i < numLargeGroups / 2; i++) groups.push_back(inLargeGroup); for (unsigned int i = 0; i < numSmallGroups / 2; i++) diff --git a/L1Trigger/VertexFinder/src/VertexFinder.cc b/L1Trigger/VertexFinder/src/VertexFinder.cc index e8f4178dd3672..e52aa896ec546 100644 --- a/L1Trigger/VertexFinder/src/VertexFinder.cc +++ b/L1Trigger/VertexFinder/src/VertexFinder.cc @@ -285,7 +285,7 @@ namespace l1tVertexFinder { } if (removing) { - const L1Track badTrack = *badTrackIt; + const L1Track& badTrack = *badTrackIt; if (settings_->debug() > 2) edm::LogInfo("VertexFinder") << "PVR::Removing track " << badTrack.z0() << " at distance " << oldDistance; discardedTracks.push_back(badTrack); @@ -321,13 +321,13 @@ namespace l1tVertexFinder { start = false; discardedTracks2.clear(); FitTrackCollection::iterator it = discardedTracks.begin(); - const L1Track track = *it; + const L1Track& track = *it; acceptedTracks.push_back(track); float z0sum = track.z0(); for (FitTrackCollection::iterator it2 = discardedTracks.begin(); it2 < discardedTracks.end(); ++it2) { if (it2 != it) { - const L1Track secondTrack = *it2; + const L1Track& secondTrack = *it2; // Calculate new vertex z0 adding this track z0sum += secondTrack.z0(); float z0vertex = z0sum / (acceptedTracks.size() + 1); @@ -533,9 +533,9 @@ namespace l1tVertexFinder { out.push_back(std::string(intervalswidth + valueswidth + 2, ' ') + scale); out.push_back(capstone); for (int i = 0; i < tableSize; i++) { - std::string interval = intervals[i]; - std::string value = values[i]; - data_type x = data[i]; + const std::string& interval = intervals[i]; + const std::string& value = values[i]; + const data_type& x = data[i]; std::fill_n(line.begin(), plotwidth, ' '); int pos = std::round((float(x) - minimum) * norm); diff --git a/L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc b/L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc index c36d8d932609c..4a6f3824f4cb3 100644 --- a/L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc +++ b/L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc @@ -224,7 +224,7 @@ std::unique_ptr L1TGlobalPrescalesVetosOnlin settings_prescale.at("prescales").getTableColumn(col.first.c_str()); for (unsigned int row = 0; row < prescalesForSet.size(); row++) { double prescale = prescalesForSet[row]; - std::string algoName = algoNames[row]; + const std::string &algoName = algoNames[row]; unsigned int algoBit = algoName2bit[algoName]; prescales[iSet][algoBit] = prescale; } @@ -276,7 +276,7 @@ std::unique_ptr L1TGlobalPrescalesVetosOnlin triggerMasks.push_back(default_finor_mask); for (unsigned int row = 0; row < algo_mask_finor.size(); row++) { - std::string algoName = algo_mask_finor[row]; + const std::string &algoName = algo_mask_finor[row]; if (strcasecmp("all", algoName.c_str()) == 0) continue; unsigned int algoBit = algoName2bit[algoName]; @@ -328,7 +328,7 @@ std::unique_ptr L1TGlobalPrescalesVetosOnlin triggerVetoMasks.push_back(default_veto_mask); for (unsigned int row = 0; row < algo_mask_veto.size(); row++) { - std::string algoName = algo_mask_veto[row]; + const std::string &algoName = algo_mask_veto[row]; if (strcasecmp("all", algoName.c_str()) == 0) continue; unsigned int algoBit = algoName2bit[algoName];