-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[DAQ] Fix DTH input readout with multiple source IDs #49552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49552/47068 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
795e5df to
2cb3855
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49552/47069 |
|
A new Pull Request was created by @smorovic for master. It involves the following packages:
@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 2 errors in the following unit tests: ---> test TestRNTupleTempEventHistory had ERRORS ---> test TestIOPoolInputSchemaEvolution had ERRORS Comparison SummarySummary:
|
|
please test |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 2 errors in the following unit tests: ---> test TestRNTupleTempEventHistory had ERRORS ---> test TestIOPoolInputSchemaEvolution had ERRORS Comparison SummarySummary:
|
|
test are failures not related to this patch. |
|
+daq |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
PR description:
Fixes buffer size accounting with multiple source IDs read when using DTH input mode.
Also improve text message when one input file has too few events.
PR validation:
Tested manually with a sample of three files provided by subdetector experts.