bugfix for MIME

Author: terapyon

net_vis/netvis.py

@@ -11,9 +11,10 @@
 import json
 from typing import Dict, Any, Optional, Sequence
 
-from ipywidgets import DOMWidget, ValueWidget, register
-from traitlets import Unicode, validate, TraitError
-from ._frontend import module_name, module_version
+# Temporarily disable widget imports for MIME renderer migration
+# from traitlets import Unicode, validate, TraitError
+# from ipywidgets import DOMWidget, ValueWidget, register
+# from ._frontend import module_name, module_version
 from ._version import __version__
 
 
@@ -25,44 +26,47 @@ def is_invalid_json(data):
         return True
 
 
-@register
-class NetVis(DOMWidget, ValueWidget):
+# @register - Temporarily disabled for MIME renderer
+# class NetVis(DOMWidget, ValueWidget):
+class NetVis:
     """NetVis widget.
-    This widget show Network Visualization.
+    This widget show Network Visualization using MIME renderer.
     """
 
-    _model_name = Unicode("NetVisModel").tag(sync=True)
-    _model_module = Unicode(module_name).tag(sync=True)
-    _model_module_version = Unicode(module_version).tag(sync=True)
-    _view_name = Unicode("NetVisView").tag(sync=True)
-    _view_module = Unicode(module_name).tag(sync=True)
-    _view_module_version = Unicode(module_version).tag(sync=True)
+    # Widget traits temporarily disabled for MIME renderer migration
+    # _model_name = Unicode("NetVisModel").tag(sync=True)
+    # _model_module = Unicode(module_name).tag(sync=True)
+    # _model_module_version = Unicode(module_version).tag(sync=True)
+    # _view_name = Unicode("NetVisView").tag(sync=True)
+    # _view_module = Unicode(module_name).tag(sync=True)
+    # _view_module_version = Unicode(module_version).tag(sync=True)
 
-    value = Unicode().tag(sync=True)
+    # value = Unicode().tag(sync=True)
 
-    def __init__(self, **kwargs):
+    # Using regular Python attribute for now
+    value = ""
+
+    def __init__(self, value=None, **kwargs):
         """
         Initialize NetVis object with graph data validation.
 
         Args:
-            value (str): JSON string containing graph data with 'nodes' and 'links' (passed via kwargs)
+            value (str): JSON string containing graph data with 'nodes' and 'links'
 
         Raises:
             ValueError: If JSON is invalid, nodes/links are missing, or data is inconsistent
         """
-        # Pre-validate 'value' in kwargs to raise ValueError (not TraitError)
-        # This ensures the API contract is met
-        if 'value' in kwargs:
-            value = kwargs['value']
-            if value is not None and value != "":
+        # Handle value parameter
+        if value is not None:
+            if value != "":
                 # Type check
                 if not isinstance(value, str):
                     raise ValueError(f"Value must be a string, not {type(value).__name__}")
                 # GraphData validation
                 self._validate_graph_data(value)
-
-        # Now call parent init, which will also run _valid_value validator
-        super().__init__(**kwargs)
+            self.value = value
+        else:
+            self.value = ""
 
     def _validate_graph_data(self, data: str) -> None:
         """
@@ -159,26 +163,27 @@ def _repr_mimebundle_(
             'text/plain': 'NetVis Graph'
         }
 
-    @validate("value")
-    def _valid_value(self, proposal):
-        _data = proposal["value"]
-
-        # Type check: only string is allowed (reject dict/list)
-        if not isinstance(_data, str):
-            raise TraitError(f"Value must be a string, not {type(_data).__name__}")
-
-        # Allow empty string (default value)
-        if _data == "":
-            return _data
-
-        # Validate JSON format
-        if is_invalid_json(_data):
-            raise TraitError("Invalid JSON value: it must be JSON string")
-
-        # Validate GraphData structure (convert ValueError to TraitError)
-        try:
-            self._validate_graph_data(_data)
-        except ValueError as e:
-            raise TraitError(str(e))
-
-        return _data
+    # Traitlet validator temporarily disabled for MIME renderer migration
+    # @validate("value")
+    # def _valid_value(self, proposal):
+    #     _data = proposal["value"]
+    #
+    #     # Type check: only string is allowed (reject dict/list)
+    #     if not isinstance(_data, str):
+    #         raise TraitError(f"Value must be a string, not {type(_data).__name__}")
+    #
+    #     # Allow empty string (default value)
+    #     if _data == "":
+    #         return _data
+    #
+    #     # Validate JSON format
+    #     if is_invalid_json(_data):
+    #         raise TraitError("Invalid JSON value: it must be JSON string")
+    #
+    #     # Validate GraphData structure (convert ValueError to TraitError)
+    #     try:
+    #         self._validate_graph_data(_data)
+    #     except ValueError as e:
+    #         raise TraitError(str(e))
+    #
+    #     return _data

package.json

@@ -85,6 +85,8 @@
     "ts-jest": "^29.1.2",
     "ts-loader": "^9.5.1",
     "typescript": "~5.4.0",
+    "url-loader": "^4.1.1",
+    "svg-url-loader": "^8.0.0",
     "webpack": "^5.90.0",
     "webpack-cli": "^5.1.4"
   },

webpack.config.js

@@ -5,7 +5,8 @@ const version = require('./package.json').version;
 const rules = [
   { test: /\.ts$/, loader: 'ts-loader' },
   { test: /\.js$/, loader: 'source-map-loader' },
-  { test: /\.css$/, use: ['style-loader', 'css-loader']}
+  { test: /\.css$/, use: ['style-loader', 'css-loader']},
+  { test: /\.svg$/, loader: 'svg-url-loader' }
 ];
 
 // Packages that shouldn't be bundled but loaded at runtime

yarn.lock

@@ -3927,6 +3927,14 @@ file-entry-cache@^6.0.1:
   dependencies:
     flat-cache "^3.0.4"
 
+file-loader@~6.2.0:
+  version "6.2.0"
+  resolved "https://registry.yarnpkg.com/file-loader/-/file-loader-6.2.0.tgz#baef7cf8e1840df325e4390b4484879480eebe4d"
+  integrity sha512-qo3glqyTa61Ytg4u73GultjHGjdRyig3tG6lPtyX/jOEJvHif9uB0/OCI2Kif6ctF3caQTW2G5gym21oAsI4pw==
+  dependencies:
+    loader-utils "^2.0.0"
+    schema-utils "^3.0.0"
+
 fill-range@^7.1.1:
   version "7.1.1"
   resolved "https://registry.yarnpkg.com/fill-range/-/fill-range-7.1.1.tgz#44265d3cac07e3ea7dc247516380643754a05292"
@@ -6592,6 +6600,13 @@ supports-preserve-symlinks-flag@^1.0.0:
   resolved "https://registry.yarnpkg.com/supports-preserve-symlinks-flag/-/supports-preserve-symlinks-flag-1.0.0.tgz#6eda4bd344a3c94aea376d4cc31bc77311039e09"
   integrity sha512-ot0WnXS9fgdkgIcePe6RHNk1WA8+muPa6cSjeR3V8K27q9BB1rTE3R1p7Hv0z1ZyAc8s6Vvv8DIyWf681MAt0w==
 
+svg-url-loader@^8.0.0:
+  version "8.0.0"
+  resolved "https://registry.yarnpkg.com/svg-url-loader/-/svg-url-loader-8.0.0.tgz#05d57af5b19d7caa39624a88e3cd535243634991"
+  integrity sha512-5doSXvl18hY1fGsRLdhWAU5jgzgxJ06/gc/26cpuDnN0xOz1HmmfhkpL29SSrdIvhtxQ1UwGzmk7wTT/l48mKw==
+  dependencies:
+    file-loader "~6.2.0"
+
 symbol-tree@^3.2.4:
   version "3.2.4"
   resolved "https://registry.yarnpkg.com/symbol-tree/-/symbol-tree-3.2.4.tgz#430637d248ba77e078883951fb9aa0eed7c63fa2"
@@ -6879,6 +6894,15 @@ uri-js@^4.2.2:
   dependencies:
     punycode "^2.1.0"
 
+url-loader@^4.1.1:
+  version "4.1.1"
+  resolved "https://registry.yarnpkg.com/url-loader/-/url-loader-4.1.1.tgz#28505e905cae158cf07c92ca622d7f237e70a4e2"
+  integrity sha512-3BTV812+AVHHOJQO8O5MkWgZ5aosP7GnROJwvzLS9hWDj00lZ6Z0wNak423Lp9PBZN05N+Jk/N5Si8jRAlGyWA==
+  dependencies:
+    loader-utils "^2.0.0"
+    mime-types "^2.1.27"
+    schema-utils "^3.0.0"
+
 url-parse@^1.5.3, url-parse@~1.5.4:
   version "1.5.10"
   resolved "https://registry.yarnpkg.com/url-parse/-/url-parse-1.5.10.tgz#9d3c2f736c1d75dd3bd2be507dcc111f1e2ea9c1"