comment and sample from Japanese to English and remove some coment in

code

Author: terapyon

CHANGES.md

@@ -1,8 +1,8 @@
 # Changelog
 
-## 0.4.0 (2025-XX-XX)
+## 0.4.0 (2025-11-21)
 
-**Major Release: Migration to MIME Renderer Architecture**
+**Major Release: Migration to MIME Renderer Architecture** (terapyon)
 
 ### Breaking Changes
 

net_vis/tests/test_netvis.py

@@ -28,7 +28,6 @@ def test_netvis_creation_with_str():
     assert w.value == data
 
 
-# T010: MIME bundle tests
 def test_netvis_mimebundle():
     """Test that NetVis returns correct MIME bundle for JupyterLab."""
     data = '{"nodes": [{"id": "A"}], "links": []}'
@@ -56,7 +55,6 @@ def test_netvis_mimebundle():
     assert isinstance(bundle["text/plain"], str)
 
 
-# T011: Error handling tests
 def test_netvis_invalid_json():
     """Test that invalid JSON raises ValueError."""
     with pytest.raises(ValueError, match="Invalid JSON format"):
@@ -91,7 +89,6 @@ def test_netvis_missing_links():
         NetVis(value=data)
 
 
-# T020: Empty data handling test
 def test_empty_data_handling():
     """Test that NetVis can be created with empty string and returns correct MIME bundle."""
     # Create NetVis with empty string
@@ -108,7 +105,6 @@ def test_empty_data_handling():
     assert "version" in mime_data
 
 
-# T032: MIME bundle structure validation (enhanced from existing test_netvis_mimebundle)
 def test_repr_mimebundle_structure():
     """Test that _repr_mimebundle_() returns correct structure with all required fields."""
     data = '{"nodes": [{"id": "A"}, {"id": "B"}], "links": [{"source": "A", "target": "B"}]}'
@@ -133,7 +129,6 @@ def test_repr_mimebundle_structure():
     assert mime_data["version"] == __version__
 
 
-# T033: Plain text fallback test
 def test_plain_text_fallback():
     """Test that MIME bundle includes text/plain fallback for environments without custom renderer."""
     data = '{"nodes": [{"id": "A"}], "links": []}'
@@ -150,7 +145,6 @@ def test_plain_text_fallback():
     assert "NetVis" in bundle["text/plain"]
 
 
-# T034: Multiple instances independence test
 def test_multiple_instances():
     """Test that multiple NetVis instances maintain independent state."""
     data1 = '{"nodes": [{"id": "A"}], "links": []}'
@@ -178,7 +172,6 @@ def test_multiple_instances():
     assert w2.value == data2  # w2 unchanged
 
 
-# T069: Large graph test (SC-008: 1000 nodes/2000 links)
 def test_large_graph():
     """Test that NetVis can handle large graphs without crashing (1000 nodes, 2000 links)."""
     # Generate large graph data
@@ -213,15 +206,14 @@ def test_large_graph():
     assert len(parsed_data["links"]) == 2000
 
 
-# T070: Special characters and Unicode in node IDs
 def test_special_characters_in_node_id():
     """Test that NetVis handles special characters and Unicode in node IDs."""
     # Test various special characters and Unicode
     test_cases = [
         # Special characters
         '{"nodes": [{"id": "node-with-dash"}, {"id": "node_with_underscore"}], "links": [{"source": "node-with-dash", "target": "node_with_underscore"}]}',
-        # Unicode characters (Japanese)
-        '{"nodes": [{"id": "ノードA"}, {"id": "ノードB"}], "links": [{"source": "ノードA", "target": "ノードB"}]}',
+        # Unicode characters (non-ASCII)
+        '{"nodes": [{"id": "Nöde_Ä"}, {"id": "Nöde_Ö"}], "links": [{"source": "Nöde_Ä", "target": "Nöde_Ö"}]}',
         # Unicode characters (Emoji)
         '{"nodes": [{"id": "🔴"}, {"id": "🔵"}], "links": [{"source": "🔴", "target": "🔵"}]}',
         # Mixed alphanumeric and symbols

src/__tests__/graph.test.ts

@@ -1,4 +1,3 @@
-// T050-T051: D3.js interaction tests for graph.ts
 // Note: Full D3.js DOM manipulation testing requires integration tests in JupyterLab.
 // These tests verify the API and error handling.
 
@@ -18,7 +17,6 @@ describe('D3.js Graph Interactions', () => {
     document.body.removeChild(container);
   });
 
-  // T050: D3.js simulation initialization test
   describe('force simulation initialization', () => {
     it('should initialize D3 force simulation without errors', () => {
       const graphData: GraphData = {
@@ -55,7 +53,6 @@ describe('D3.js Graph Interactions', () => {
     });
   });
 
-  // T051: Drag event handler tests
   describe('drag and interaction handlers', () => {
     it('should successfully render graph with nodes for drag interaction', () => {
       const graphData: GraphData = {

src/__tests__/mimePlugin.test.ts

@@ -1,5 +1,3 @@
-// Phase 2 TypeScript tests for MIME renderer helper functions (T021-T023)
-
 import { parseGraphData, validateVersion, MIME_TYPE } from '../mimePlugin';
 
 describe('parseGraphData', () => {
@@ -172,8 +170,8 @@ describe('mimeExtension plugin', () => {
   it('should have correct extension properties', async () => {
     const mimeExtension = (await import('../mimePlugin')).default;
 
-    // JupyterLab 4のIExtensionにはautoStartプロパティなし
-    // 正しいインターフェースプロパティのみテスト
+    // JupyterLab 4 IExtension does not have autoStart property
+    // Test only the correct interface properties
     expect(mimeExtension.id).toBe('net_vis:mime');
     expect(mimeExtension.rendererFactory).toBeDefined();
     expect(mimeExtension.dataType).toBe('json');

src/__tests__/renderer.test.ts

@@ -1,5 +1,3 @@
-// T012: TypeScript renderer tests
-
 import { NetVisRenderer } from '../renderer';
 import { IRenderMime } from '@jupyterlab/rendermime-interfaces';
 
@@ -230,7 +228,6 @@ describe('NetVisRenderer', () => {
     });
   });
 
-  // T037: Node and link rendering tests
   // Note: These tests verify that the renderer can process node and link data without errors.
   // Full SVG element verification requires integration tests in JupyterLab environment.
   describe('node and link rendering', () => {
@@ -320,7 +317,6 @@ describe('NetVisRenderer', () => {
     });
   });
 
-  // T071: Large graph rendering test
   describe('large graph performance', () => {
     it('should handle large graph (100 nodes, 200 links) without crashing', async () => {
       const renderer = new NetVisRenderer({

src/__tests__/utils.ts

@@ -1,6 +1,3 @@
-// Copyright (c) Jupyter Development Team.
-// Distributed under the terms of the Modified BSD License.
-
 import * as widgets from '@jupyter-widgets/base';
 import * as baseManager from '@jupyter-widgets/base-manager';
 import * as services from '@jupyterlab/services';

src/graph.ts

@@ -35,7 +35,7 @@ function adjustLinkPath(d: any) {
   const dy = d.target.y - d.source.y;
   const distance = Math.sqrt(dx * dx + dy * dy);
 
-  // 各ノードが持つ半径を取得（存在しない場合はデフォルト値を設定）
+  // Get node radius (default to 5 if not specified)
   const sourceRadius = d.source.radius || 5;
   const targetRadius = d.target.radius || 5;
 
@@ -82,15 +82,15 @@ function Graph(svg: any, { nodes, links }: { nodes: Node[]; links: Link[] }) {
     .append('marker')
     .attr('id', markerId)
     .attr('viewBox', '0 0 10 10')
-    .attr('refX', 10) // 矢印の位置調整（重要）
+    .attr('refX', 10) // Arrow position adjustment (important)
     .attr('refY', 5)
     .attr('markerWidth', 10)
     .attr('markerHeight', 10)
-    .attr('orient', 'auto'); // 通常の 'auto' でもOK
+    .attr('orient', 'auto'); // Standard 'auto' works fine
   marker
     .append('path')
-    .attr('d', 'M 0 0 L 10 5 L 0 10 z') // 矢印の形
-    .attr('fill', 'black'); // 見やすく
+    .attr('d', 'M 0 0 L 10 5 L 0 10 z') // Arrow shape
+    .attr('fill', 'black'); // For visibility
 
   const link = g
     .selectAll('path')
@@ -100,14 +100,14 @@ function Graph(svg: any, { nodes, links }: { nodes: Node[]; links: Link[] }) {
     .attr('stroke', 'black')
     .attr('stroke-width', 1)
     .attr('fill', 'none')
-    .attr('marker-end', `url(#${markerId})`) // 矢印のIDを指定
+    .attr('marker-end', `url(#${markerId})`) // Reference arrow marker
     .attr('d', adjustLinkPath);
 
   const node = g
     .selectAll('g')
     .data(nodes)
     .enter()
-    .append('g') // グループ要素を追加
+    .append('g') // Add group element
     .classed('node-group', true);
 
   node
@@ -131,16 +131,16 @@ function Graph(svg: any, { nodes, links }: { nodes: Node[]; links: Link[] }) {
     )
     .classed('circle', true);
 
-  // テキスト（最初は非表示）を追加
+  // Add text labels (initially hidden)
   node
     .append('text')
     .text((d: any) => (d.name ? d.name : d.id))
-    .attr('y', -20) // ノードの上に表示
+    .attr('y', -20) // Display above the node
     .attr('text-anchor', 'middle')
     .style('font-size', '12px')
     .style('display', 'none');
 
-  // ノードのクリックイベントを統合
+  // Node click event handling
   node
     .on('mouseover', function (this: SVGGElement, event: any, d: any) {
       console.log('mouseover', d);
@@ -153,15 +153,15 @@ function Graph(svg: any, { nodes, links }: { nodes: Node[]; links: Link[] }) {
       }
     })
     .on('click', function (this: SVGGElement, event: any, d: any) {
-      console.log('click', this, d); // thisが正しい要素を指しているか確認
+      console.log('click', this, d); // Verify this points to the correct element
       const isClicked = d3.select(this).classed('clicked');
-      console.log('isClicked:', isClicked); // 現在の状態を確認
-      d3.select(this).classed('clicked', !isClicked); // クラスのトグル
+      console.log('isClicked:', isClicked); // Check current state
+      d3.select(this).classed('clicked', !isClicked); // Toggle class
       d3.select(this)
         .select('text')
-        .style('display', isClicked ? 'none' : 'block'); // 表示状態をトグル
+        .style('display', isClicked ? 'none' : 'block'); // Toggle visibility
 
-      // ドラッグ解除の処理
+      // Release drag fixing
       if (isClicked) {
         delete d.fx;
         delete d.fy;
@@ -172,7 +172,7 @@ function Graph(svg: any, { nodes, links }: { nodes: Node[]; links: Link[] }) {
   simulation.on('tick', () => {
     link.attr('d', adjustLinkPath);
     // node.attr('cx', (d: any) => d.x).attr('cy', (d: any) => d.y);
-    node.attr('transform', (d: any) => `translate(${d.x},${d.y})`); // グループ全体を移動
+    node.attr('transform', (d: any) => `translate(${d.x},${d.y})`); // Move entire group
   });
 
   const width = 800;
@@ -199,7 +199,7 @@ function Graph(svg: any, { nodes, links }: { nodes: Node[]; links: Link[] }) {
   node.call(drag);
 
   function dragstart() {
-    // ドラッグ開始時の処理（必要に応じて追加）
+    // Drag start handler (add logic as needed)
   }
 
   function dragged(event: any, d: any) {

src/mimePlugin.ts

@@ -1,6 +1,3 @@
-// Copyright (c) Manabu TERADA
-// Distributed under the terms of the Modified BSD License.
-
 import { IRenderMime } from '@jupyterlab/rendermime-interfaces';
 import { Widget } from '@lumino/widgets';
 

src/renderer.ts

@@ -1,6 +1,3 @@
-// Copyright (c) Manabu TERADA
-// Distributed under the terms of the Modified BSD License.
-
 import { Widget } from '@lumino/widgets';
 import { IRenderMime } from '@jupyterlab/rendermime-interfaces';
 import { renderGraph } from './graph';

src/version.ts

@@ -1,6 +1,3 @@
-// Copyright (c) Manabu TERADA
-// Distributed under the terms of the Modified BSD License.
-
 // eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 // eslint-disable-next-line @typescript-eslint/no-var-requires