Skip to content

Commit 852d6cd

Browse files
committed
[FIX] improve the tests
1 parent 0607431 commit 852d6cd

File tree

3 files changed

+24
-23
lines changed

3 files changed

+24
-23
lines changed

parquet-variant-compute/src/field_operations.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -449,13 +449,13 @@ mod tests {
449449

450450
fn create_test_object() -> (Vec<u8>, Vec<u8>) {
451451
let mut builder = VariantBuilder::new();
452-
{
453-
let mut obj = builder.new_object();
454-
obj.insert("name", "Alice");
455-
obj.insert("age", 30i32);
456-
obj.insert("city", "NYC");
457-
obj.finish().unwrap();
458-
}
452+
builder
453+
.new_object()
454+
.with_field("name", "Alice")
455+
.with_field("age", 30i32)
456+
.with_field("city", "NYC")
457+
.finish()
458+
.unwrap();
459459
builder.finish()
460460
}
461461

parquet-variant-compute/src/variant_array.rs

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -394,24 +394,24 @@ mod test {
394394

395395
// Create variant 1: {"name": "Alice", "age": 30}
396396
let mut builder1 = VariantBuilder::new();
397-
{
398-
let mut obj = builder1.new_object();
399-
obj.insert("name", "Alice");
400-
obj.insert("age", 30i32);
401-
obj.finish().unwrap();
402-
}
397+
builder1
398+
.new_object()
399+
.with_field("name", "Alice")
400+
.with_field("age", 30i32)
401+
.finish()
402+
.unwrap();
403403
let (metadata1, value1) = builder1.finish();
404404
builder.append_variant_buffers(&metadata1, &value1);
405405

406406
// Create variant 2: {"name": "Bob", "age": 25, "city": "NYC"}
407407
let mut builder2 = VariantBuilder::new();
408-
{
409-
let mut obj = builder2.new_object();
410-
obj.insert("name", "Bob");
411-
obj.insert("age", 25i32);
412-
obj.insert("city", "NYC");
413-
obj.finish().unwrap();
414-
}
408+
builder2
409+
.new_object()
410+
.with_field("name", "Bob")
411+
.with_field("age", 25i32)
412+
.with_field("city", "NYC")
413+
.finish()
414+
.unwrap();
415415
let (metadata2, value2) = builder2.finish();
416416
builder.append_variant_buffers(&metadata2, &value2);
417417

parquet-variant-compute/src/variant_array_builder.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,10 @@ use std::sync::Arc;
4848
/// // append a pre-constructed metadata and value buffers
4949
/// let (metadata, value) = {
5050
/// let mut vb = VariantBuilder::new();
51-
/// let mut obj = vb.new_object();
52-
/// obj.insert("foo", "bar");
53-
/// obj.finish().unwrap();
51+
/// vb.new_object()
52+
/// .with_field("foo", "bar")
53+
/// .finish()
54+
/// .unwrap();
5455
/// vb.finish()
5556
/// };
5657
/// builder.append_variant_buffers(&metadata, &value);

0 commit comments

Comments
 (0)