[REMOVE] revert field_operations.rs

Author: carpecodeum

parquet-variant-compute/benches/variant_kernels.rs

@@ -19,7 +19,8 @@ use arrow::array::{Array, ArrayRef, StringArray};
 use arrow::util::test_util::seedable_rng;
 use criterion::{criterion_group, criterion_main, Criterion};
 use parquet_variant::{Variant, VariantBuilder};
-use parquet_variant_compute::{batch_json_string_to_variant, variant_get, GetOptions, VariantArray, VariantArrayBuilder};
+use parquet_variant_compute::variant_get::{variant_get, GetOptions};
+use parquet_variant_compute::{batch_json_string_to_variant, VariantArray, VariantArrayBuilder};
 use rand::distr::Alphanumeric;
 use rand::rngs::StdRng;
 use rand::Rng;

parquet-variant-compute/src/field_operations.rs

@@ -17,7 +17,6 @@
 
 //! Parquet variant compute functions
 
-pub mod field_operations;
 pub mod from_json;
 pub mod to_json;
 pub mod variant_array;

parquet-variant-compute/src/lib.rs

@@ -118,12 +118,7 @@ impl VariantParser {
         let length = (header_byte >> 2) as usize;
 
         // Short strings can be up to 64 bytes (6-bit value: 0-63)
-        if length > 63 {
-            return Err(ArrowError::InvalidArgumentError(format!(
-                "Short string length {} exceeds maximum of 63",
-                length
-            )));
-        }
+        // Note: Since header_byte is u8, header_byte >> 2 can never exceed 63, so no bounds check needed
 
         Ok(ShortStringHeader { length })
     }
@@ -335,7 +330,7 @@ mod tests {
             ShortStringHeader { length: 63 }
         );
 
-        // Test that all values 0-63 are valid
+        // Test that all values 0-63 are valid (these are all possible values since u8 >> 2 max is 63)
         for length in 0..=63 {
             let header_byte = (length << 2) | 1; // short string type
             assert!(VariantParser::parse_short_string_header(header_byte as u8).is_ok());

parquet-variant-compute/src/variant_parser.rs

@@ -30,6 +30,7 @@ readme = "README.md"
 edition = { workspace = true }
 rust-version = { workspace = true }
 
+
 [dependencies]
 arrow-schema = { workspace = true }
 chrono = { workspace = true }