Skip to content

Commit c370656

Browse files
authored
Add some devcontainer fixups for running docker in docker (#597)
Slight tweaks to allow running docker inside the devcontainer again.
1 parent f5fe17c commit c370656

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.devcontainer/devcontainer.json

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,15 @@
2525
"--env-file=.env"
2626
],
2727
"features": {
28-
"ghcr.io/devcontainers/features/docker-outside-of-docker": {},
29-
"ghcr.io/stuartleeks/dev-container-features/shell-history": {}
28+
"ghcr.io/devcontainers/features/docker-outside-of-docker": {
29+
"moby": true,
30+
"installDockerBuildx": true,
31+
"installDockerComposeSwitch": true,
32+
"version": "latest",
33+
"dockerDashComposeVersion": "v2"
34+
},
35+
"ghcr.io/stuartleeks/dev-container-features/shell-history": {},
36+
"ghcr.io/devcontainers/features/git": {}
3037
},
3138
"containerEnv": {
3239
"http_proxy": "${localEnv:http_proxy}",

docker/benchbase/devcontainer/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ ARG CONTAINERUSER_GID=1000
1717
RUN groupadd --non-unique --gid ${CONTAINERUSER_GID} containergroup \
1818
&& useradd --non-unique --create-home --no-user-group --comment 'Container User' \
1919
--uid ${CONTAINERUSER_UID} --gid ${CONTAINERUSER_GID} containeruser \
20+
&& echo 'ubuntu ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers \
2021
&& echo 'containeruser ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers
2122
RUN mkdir -p /benchbase/results && chown -R containeruser:containergroup /benchbase/
2223
USER containeruser

0 commit comments

Comments
 (0)