fix: bustub shell memory leak (#660)

skyzh · web-flow · commit 09bed9d791fe · 2023-11-13T13:51:33.000-05:00
Signed-off-by: Alex Chi &lt;iskyzh@gmail.com&gt;
diff --git a/tools/shell/shell.cpp b/tools/shell/shell.cpp
@@ -83,11 +83,11 @@ auto main(int argc, char **argv) -> int {
           return 0;
         }
         query += query_c_str;
+        linenoiseFree(query_c_str);
         if (bustub::StringUtil::EndsWith(query, ";") || bustub::StringUtil::StartsWith(query, "\\")) {
           break;
         }
         query += " ";
-        linenoiseFree(query_c_str);
       } else {
         std::string query_line;
         std::cout << line_prompt;

Original file line number	Diff line number	Diff line change
`@@ -83,11 +83,11 @@ auto main(int argc, char **argv) -> int {`
`83`	`83`	`return 0;`
`84`	`84`	`}`
`85`	`85`	`query += query_c_str;`
	`86`	`+ linenoiseFree(query_c_str);`
`86`	`87`	`if (bustub::StringUtil::EndsWith(query, ";") \|\| bustub::StringUtil::StartsWith(query, "\\")) {`
`87`	`88`	`break;`
`88`	`89`	`}`
`89`	`90`	`query += " ";`
`90`		`- linenoiseFree(query_c_str);`
`91`	`91`	`} else {`
`92`	`92`	`std::string query_line;`
`93`	`93`	`std::cout << line_prompt;`