Skip to content

Commit 6327570

Browse files
authored
use const for table heap extra functions (#671)
Signed-off-by: Alex Chi <[email protected]>
1 parent 8b2e8a2 commit 6327570

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/include/storage/table/table_heap.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ class TableHeap {
124124

125125
void UpdateTupleInPlaceWithLockAcquired(const TupleMeta &meta, const Tuple &tuple, RID rid, TablePage *page);
126126

127-
auto GetTupleWithLockAcquired(RID rid, TablePage *page) -> std::pair<TupleMeta, Tuple>;
127+
auto GetTupleWithLockAcquired(RID rid, const TablePage *page) -> std::pair<TupleMeta, Tuple>;
128128

129-
auto GetTupleMetaWithLockAcquired(RID rid, TablePage *page) -> TupleMeta;
129+
auto GetTupleMetaWithLockAcquired(RID rid, const TablePage *page) -> TupleMeta;
130130

131131
private:
132132
/** Used for binder tests */

src/storage/table/table_heap.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,14 @@ void TableHeap::UpdateTupleInPlaceWithLockAcquired(const TupleMeta &meta, const
145145
page->UpdateTupleInPlaceUnsafe(meta, tuple, rid);
146146
}
147147

148-
auto TableHeap::GetTupleWithLockAcquired(RID rid, TablePage *page) -> std::pair<TupleMeta, Tuple> {
148+
auto TableHeap::GetTupleWithLockAcquired(RID rid, const TablePage *page) -> std::pair<TupleMeta, Tuple> {
149149
auto [meta, tuple] = page->GetTuple(rid);
150150
tuple.rid_ = rid;
151151
return std::make_pair(meta, std::move(tuple));
152152
}
153153

154-
auto TableHeap::GetTupleMetaWithLockAcquired(RID rid, TablePage *page) -> TupleMeta { return page->GetTupleMeta(rid); }
154+
auto TableHeap::GetTupleMetaWithLockAcquired(RID rid, const TablePage *page) -> TupleMeta {
155+
return page->GetTupleMeta(rid);
156+
}
155157

156158
} // namespace bustub

0 commit comments

Comments
 (0)