Skip to content

Commit bd62db0

Browse files
authored
fix: fix page guard sample test (#695)
* fix page guard sample test * add upgraderead & upgradewrite method
1 parent b6cc751 commit bd62db0

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/storage/page/page_guard.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ auto BasicPageGuard::operator=(BasicPageGuard &&that) noexcept -> BasicPageGuard
1111

1212
BasicPageGuard::~BasicPageGuard(){}; // NOLINT
1313

14+
auto BasicPageGuard::UpgradeRead() -> ReadPageGuard { return {bpm_, page_}; }
15+
16+
auto BasicPageGuard::UpgradeWrite() -> WritePageGuard { return {bpm_, page_}; }
17+
1418
ReadPageGuard::ReadPageGuard(BufferPoolManager *bpm, Page *page) {}
1519

1620
ReadPageGuard::ReadPageGuard(ReadPageGuard &&that) noexcept = default;

test/storage/page_guard_test.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ TEST(PageGuardTest, DISABLED_SampleTest) {
4545

4646
{
4747
auto *page2 = bpm->NewPage(&page_id_temp);
48-
page2->RLatch();
4948
auto guard2 = ReadPageGuard(bpm.get(), page2);
5049
}
5150

0 commit comments

Comments
 (0)