Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Commit 7807449

Browse files
authored
Remove terrier from issue template (#1424)
1 parent 8a6f19a commit 7807449

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

.github/ISSUE_TEMPLATE/noisepage-issue-template.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,16 @@ To address the bug, especially if it environment specific, we need to know what
5050

5151
## Steps to Reproduce
5252
Whenever possible, retrace how you came about the problem and describe so here. An [example](https://github.com/cmu-db/noisepage/issues/1117) from an issue by @jkosh44 follows:
53-
1. Compile with the following args: -DCMAKE_BUILD_TYPE=Debug -DTERRIER_USE_ASAN=ON
54-
2. Run terrier with parallel execution turned off terrier -parallel_execution=false
53+
1. Compile with the following args: -DCMAKE_BUILD_TYPE=Debug -DNOISEPAGE_USE_ASAN=ON
54+
2. Run NoisePage with parallel execution turned off noisepage -parallel_execution=false
5555
3. Run a built in function with an empty string (ex: SELECT STARTS_WITH('HELLO', '');)
5656

5757
If you have an understanding of why the bug occurred, that would be awesome to include as well! In this case, be as descriptive as you can and provide references to lines of code in the code whenever possible! An [example](https://github.com/cmu-db/noisepage/issues/1158) from an issue by @tanujnay112 follows:
5858

5959
`Insert into select` currently doesn't insert anything and does not generate code to do so for a few reasons.
6060
1. InsertTranslator doesn't call prepare on its children if such children exist.
6161
2. The InsertPlanNode needs to have DerivedValueExpressions in its values_ vector to signify tuples that are derived from its children for insertion. This should be done in plan_generator.cpp. Otherwise, there is nothing in the values_ vector during INSERT INTO SELECT and the insert translator generates nothing.
62-
3. Also, in order for the children of the insert node to pass up tuples the InsertSelect node needs to request the required columns from the descendant scan node [here](https://github.com/cmu-db/terrier/blob/d60db2a543eed2c0463d2fae02eb4bc39628b4f8/src/optimizer/input_column_deriver.cpp#L233). Currently this just passes down required columns from above which is incorrect. You can't request columns from an Insert node. Also, at this point we must generate the required columns to request from the children. In the event that we have a INSERT INTO yyy SELECT * FROM xxx;, we can easily just query all the columns oids in xxx and request those columns. The tableoid of xxx is stored in the child of the concerned InsertSelect node.
62+
3. Also, in order for the children of the insert node to pass up tuples the InsertSelect node needs to request the required columns from the descendant scan node [here](https://github.com/cmu-db/noisepage/blob/d60db2a543eed2c0463d2fae02eb4bc39628b4f8/src/optimizer/input_column_deriver.cpp#L233). Currently this just passes down required columns from above which is incorrect. You can't request columns from an Insert node. Also, at this point we must generate the required columns to request from the children. In the event that we have a INSERT INTO yyy SELECT * FROM xxx;, we can easily just query all the columns oids in xxx and request those columns. The tableoid of xxx is stored in the child of the concerned InsertSelect node.
6363
4. The information stored in InsertSelect is incomplete. While the vanilla Insert physical operator node has this that allows us to know which columns we are inserting into, the InsertSelect operator has no equivalent even though this information is necessary.
6464

6565
### Expected Behavior
@@ -95,21 +95,21 @@ Fill in the behavior you actually observed for our system.
9595

9696
Useful things to include here are code snippets showing the command run and the output observed and screenshots of issues. An [example](https://github.com/cmu-db/noisepage/issues/1150) from an issue by @lmwnshn follows:
9797
```SQL
98-
terrier=# create table foo (a int);
98+
noisepage=# create table foo (a int);
9999
CREATE TABLE
100-
terrier=# insert into foo values (1);
100+
noisepage=# insert into foo values (1);
101101
INSERT 0 1
102-
terrier=# insert into foo values (1);
102+
noisepage=# insert into foo values (1);
103103
INSERT 0 1
104-
terrier=# insert into foo values (2);
104+
noisepage=# insert into foo values (2);
105105
INSERT 0 1
106-
terrier=# select a, sum(a) from foo group by a;
106+
noisepage=# select a, sum(a) from foo group by a;
107107
a | ?column?
108108
---+----------
109109
1 | 2
110110
2 | 2
111111
(2 rows)
112-
terrier=# select a, sum(a) from foo group by a order by a;
112+
noisepage=# select a, sum(a) from foo group by a order by a;
113113
a | ?column?
114114
---+----------
115115
(0 rows)

0 commit comments

Comments
 (0)