Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Commit f45d0ed

Browse files
authored
Switch lightgbm to random forest in modeling_test (#1442)
1 parent 615dcd1 commit f45d0ed

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/self_driving/model_server/model_server_manager.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,12 @@ void ModelServerManager::StartModelServer(const std::string &model_path) {
8787
}
8888

8989
// Fork success
90+
// TODO(lin): The LightGBM (Python) library has a known hanging issue when multithreading and using forking in
91+
// Linux at the same time:
92+
// https://lightgbm.readthedocs.io/en/latest/FAQ
93+
// .html#lightgbm-hangs-when-multithreading-openmp-and-using-forking-in-linux-at-the-same-time
94+
// So this may cause a subsequent command that issues a model training using LightGBM under multi-threading to
95+
// hang (not always). Don't have a good solution right now.
9096
if (py_pid_ > 0) {
9197
// Parent Process Routine
9298
MODEL_SERVER_LOG_INFO("Model Server Process running at : {}", py_pid_);

test/self_driving_e2e/modeling_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ TEST_F(ModelServerTest, PipelineTest) {
7979
std::string msg = "ModelServerTest";
8080
ms_manager->PrintMessage(msg);
8181

82-
// Perform a training of the opunit models with {lr, gbm} as training methods.
83-
std::vector<std::string> methods{"lr", "gbm"};
82+
// Perform a training of the opunit models with {lr, rf} as training methods.
83+
std::vector<std::string> methods{"lr", "rf"};
8484
std::string save_path = "model_server_test.pickle";
8585

8686
ModelServerFuture<std::string> future;

0 commit comments

Comments
 (0)