Skip to content

Commit 2c9240f

Browse files
committed
Add important tricky todo
1 parent a8f92c3 commit 2c9240f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

optd-cost-model/src/cost/filter/comp_op.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ impl<S: CostModelStorageManager> CostModelImpl<S> {
179179
cast_node = attr_ref_expr.into_pred_node();
180180
// The "invert" cast is to invert the cast so that we're casting the
181181
// non_cast_node to the attribute's original type.
182-
// TODO(migration): double check
183182
// TODO: Consider attribute info is None.
183+
// **TODO**: What if this attribute is a derived attribute?
184184
let attribute_info = self
185185
.storage_manager
186186
.get_attribute_info(table_id, attr_ref_idx as i32)

optd-cost-model/src/storage/persistent.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ impl<S: CostModelStorageLayer + Send + Sync> CostModelStorageManager
3030
///
3131
/// TODO: if we have memory cache,
3232
/// we should add the reference. (&Attr)
33+
/// TODO(IMPORTANT): what if table is a derived (temporary) table? And what if
34+
/// the attribute is a derived attribute?
3335
async fn get_attribute_info(
3436
&self,
3537
table_id: TableId,
@@ -58,6 +60,9 @@ impl<S: CostModelStorageLayer + Send + Sync> CostModelStorageManager
5860
///
5961
/// TODO: Shall we pass in an epoch here to make sure that the statistics are from the same
6062
/// epoch?
63+
///
64+
/// TODO(IMPORTANT): what if table is a derived (temporary) table? And what if
65+
/// the attribute is a derived attribute?
6166
async fn get_attributes_comb_statistics(
6267
&self,
6368
table_id: TableId,

0 commit comments

Comments
 (0)