Skip to content

Commit 36b93b9

Browse files
committed
make CostModelStorageManagerImpl::get_attribute_info unimplemented
1 parent 68b2885 commit 36b93b9

File tree

1 file changed

+2
-16
lines changed

1 file changed

+2
-16
lines changed

optd-cost-model/src/storage/persistent.rs

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use std::sync::Arc;
44
use optd_persistent::{cost_model::interface::StatType, CostModelStorageLayer};
55

66
use crate::{
7-
common::{predicates::constant_pred::ConstantType, properties::Attribute, types::TableId},
7+
common::{properties::Attribute, types::TableId},
88
stats::{utilities::counter::Counter, AttributeCombValueStats, Distribution, MostCommonValues},
99
CostModelResult,
1010
};
@@ -26,26 +26,12 @@ impl<S: CostModelStorageLayer + Send + Sync> CostModelStorageManagerImpl<S> {
2626
impl<S: CostModelStorageLayer + Send + Sync> CostModelStorageManager
2727
for CostModelStorageManagerImpl<S>
2828
{
29-
/// Gets the attribute information for a given table and attribute base index.
30-
///
31-
/// TODO: if we have memory cache,
32-
/// we should add the reference. (&Attr)
33-
/// TODO(IMPORTANT): what if table is a derived (temporary) table? And what if
34-
/// the attribute is a derived attribute?
3529
async fn get_attribute_info(
3630
&self,
3731
table_id: TableId,
3832
attr_base_index: u64,
3933
) -> CostModelResult<Option<Attribute>> {
40-
Ok(self
41-
.backend_manager
42-
.get_attribute(table_id.into(), attr_base_index as i32)
43-
.await?
44-
.map(|attr| Attribute {
45-
name: attr.name,
46-
typ: ConstantType::from_persistent_attr_type(attr.attr_type),
47-
nullable: attr.nullable,
48-
}))
34+
unimplemented!()
4935
}
5036

5137
/// Gets the latest statistics for a given table.

0 commit comments

Comments
 (0)