Skip to content

Commit 7a8d4df

Browse files
committed
Rebase on main
1 parent 6f97425 commit 7a8d4df

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

optd-persistent/Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

optd-persistent/src/cost_model/orm.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,9 @@ impl CostModelStorageLayer for BackendManager {
318318
.await?;
319319

320320
// TODO(lanlou): consider the update conflict for latest_epoch_id in multiple threads
321+
// Assume the txn fails to commit, and the epoch_id is updated. But the epoch_id
322+
// is always increasing and won't be overwritten even if the record is deleted, it
323+
// might be fine.
321324
if insert_new_epoch {
322325
self.latest_epoch_id
323326
.store(epoch_id as usize, std::sync::atomic::Ordering::Relaxed);

0 commit comments

Comments
 (0)