File tree Expand file tree Collapse file tree 2 files changed +3
-1
lines changed
Expand file tree Collapse file tree 2 files changed +3
-1
lines changed Original file line number Diff line number Diff line change @@ -179,8 +179,8 @@ impl<S: CostModelStorageManager> CostModelImpl<S> {
179179 cast_node = attr_ref_expr. into_pred_node ( ) ;
180180 // The "invert" cast is to invert the cast so that we're casting the
181181 // non_cast_node to the attribute's original type.
182- // TODO(migration): double check
183182 // TODO: Consider attribute info is None.
183+ // **TODO**: What if this attribute is a derived attribute?
184184 let attribute_info = self
185185 . storage_manager
186186 . get_attribute_info ( table_id, attr_ref_idx as i32 )
Original file line number Diff line number Diff line change @@ -30,6 +30,8 @@ impl<S: CostModelStorageLayer + Send + Sync> CostModelStorageManager
3030 ///
3131 /// TODO: if we have memory cache,
3232 /// we should add the reference. (&Attr)
33+ /// TODO(IMPORTANT): what if table is a derived (temporary) table? And what if
34+ /// the attribute is a derived attribute?
3335 async fn get_attribute_info (
3436 & self ,
3537 table_id : TableId ,
You can’t perform that action at this time.
0 commit comments