chore: remove latest epoch id and add some todo documentation comments #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lanlou1554
commented
Nov 9, 2024
lanlou1554
commented
- Remove latest_epoch_id in backend_manager since it is useless.
- Add some todo documentation comments for cost model piece
connortsui20
approved these changes
Nov 9, 2024
Member
connortsui20
left a comment
connortsui20
left a comment
There was a problem hiding this comment.
LGTM (just add the lazy cell from the other PR to fix the conflict)
lanlou1554
force-pushed
the
remove-latest-epoch-id
branch
from
ef1d482 to
beb6e60
Compare
lanlou1554
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.