fix(adv-cost): clippy warnings (#223)

Signed-off-by: Alex Chi <[email protected]>

Author: skyzh

optd-core/src/nodes.rs

@@ -190,13 +190,13 @@ impl Value {
             }),
             DataType::Int64 => Value::Int64(match self {
                 Value::Int64(i64) => *i64,
-                Value::Int32(i32) => (*i32).try_into().unwrap(),
+                Value::Int32(i32) => (*i32).into(),
                 _ => panic!("{self} could not be converted into an Int64"),
             }),
             DataType::UInt64 => Value::UInt64(match self {
                 Value::Int64(i64) => (*i64).try_into().unwrap(),
                 Value::UInt64(i64) => *i64,
-                Value::UInt32(i32) => (*i32).try_into().unwrap(),
+                Value::UInt32(i32) => (*i32).into(),
                 _ => panic!("{self} could not be converted into an UInt64"),
             }),
             DataType::Date32 => Value::Date32(match self {

optd-datafusion-repr-adv-cost/src/adv_stats.rs

@@ -26,6 +26,7 @@ const DEFAULT_INEQ_SEL: f64 = 0.3333333333333333;
 // Default n-distinct estimate for derived columns or columns lacking statistics
 const DEFAULT_NUM_DISTINCT: u64 = 200;
 // Default selectivity if we have no information
+#[allow(dead_code)]
 const DEFAULT_UNK_SEL: f64 = 0.005;
 
 // A placeholder for unimplemented!() for codepaths which are accessed by plannertest
@@ -317,7 +318,7 @@ mod tests {
     pub fn in_list(col_ref_idx: u64, list: Vec<Value>, negated: bool) -> InListPred {
         InListPred::new(
             col_ref(col_ref_idx),
-            ListPred::new(list.into_iter().map(|v| cnst(v)).collect_vec()),
+            ListPred::new(list.into_iter().map(cnst).collect_vec()),
             negated,
         )
     }

optd-datafusion-repr-adv-cost/src/adv_stats/agg.rs

@@ -1,4 +1,3 @@
-use optd_core::cascades::{CascadesOptimizer, RelNodeContext};
 use serde::{de::DeserializeOwned, Serialize};
 
 use crate::adv_stats::{
@@ -7,12 +6,10 @@ use crate::adv_stats::{
 };
 use optd_datafusion_repr::{
     plan_nodes::{ArcDfPredNode, DfReprPredNode, ListPred},
-    properties::column_ref::{
-        BaseTableColumnRef, ColumnRef, ColumnRefPropertyBuilder, GroupColumnRefs,
-    },
+    properties::column_ref::{BaseTableColumnRef, ColumnRef, GroupColumnRefs},
 };
 
-use super::{AdvStats, DEFAULT_UNK_SEL};
+use super::AdvStats;
 
 impl<
         M: MostCommonValues + Serialize + DeserializeOwned,

optd-datafusion-repr-adv-cost/src/adv_stats/filter.rs

@@ -1,6 +1,5 @@
 use std::ops::Bound;
 
-use optd_core::cascades::{CascadesOptimizer, RelNodeContext};
 use serde::{de::DeserializeOwned, Serialize};
 
 use crate::adv_stats::{
@@ -13,16 +12,13 @@ use optd_datafusion_repr::{
         DfReprPredNode, InListPred, LikePred, LogOpType, UnOpType,
     },
     properties::{
-        column_ref::{
-            BaseTableColumnRef, BaseTableColumnRefs, ColumnRef, ColumnRefPropertyBuilder,
-            GroupColumnRefs,
-        },
-        schema::{Schema, SchemaPropertyBuilder},
+        column_ref::{BaseTableColumnRef, BaseTableColumnRefs, ColumnRef, GroupColumnRefs},
+        schema::Schema,
     },
     Value,
 };
 
-use super::{stats::ColumnCombValue, AdvStats, DEFAULT_EQ_SEL, DEFAULT_INEQ_SEL, DEFAULT_UNK_SEL};
+use super::{stats::ColumnCombValue, AdvStats, DEFAULT_EQ_SEL, DEFAULT_INEQ_SEL};
 
 mod in_list;
 mod like;

optd-datafusion-repr-adv-cost/src/adv_stats/join.rs

@@ -1,7 +1,7 @@
 use std::collections::HashSet;
 
 use itertools::Itertools;
-use optd_core::cascades::{CascadesOptimizer, RelNodeContext};
+
 use serde::{de::DeserializeOwned, Serialize};
 
 use crate::adv_stats::{
@@ -15,20 +15,21 @@ use optd_datafusion_repr::{
     },
     properties::{
         column_ref::{
-            BaseTableColumnRef, BaseTableColumnRefs, ColumnRef, ColumnRefPropertyBuilder,
-            EqBaseTableColumnSets, EqPredicate, GroupColumnRefs, SemanticCorrelation,
+            BaseTableColumnRef, BaseTableColumnRefs, ColumnRef, EqBaseTableColumnSets, EqPredicate,
+            GroupColumnRefs, SemanticCorrelation,
         },
-        schema::{Schema, SchemaPropertyBuilder},
+        schema::Schema,
     },
 };
 
-use super::{AdvStats, DEFAULT_UNK_SEL};
+use super::AdvStats;
 
 impl<
         M: MostCommonValues + Serialize + DeserializeOwned,
         D: Distribution + Serialize + DeserializeOwned,
     > AdvStats<M, D>
 {
+    #[allow(clippy::too_many_arguments)]
     pub(crate) fn get_nlj_row_cnt(
         &self,
         join_typ: JoinType,
@@ -55,6 +56,7 @@ impl<
         (left_row_cnt * right_row_cnt * selectivity).max(1.0)
     }
 
+    #[allow(clippy::too_many_arguments)]
     pub(crate) fn get_hash_join_row_cnt(
         &self,
         join_typ: JoinType,