Fixed formatting and requested changes

Author: GustavoAngulo

src/optimizer/rule_impls.cpp

@@ -111,10 +111,8 @@ void InnerJoinAssociativity::Transform(
 
   // Get Alias sets
   auto &memo = context->metadata->memo;
-
-  auto middle_group_id =
-      children[0]->Children()[1]->Op().As<LeafOperator>()->origin_group;
-  auto right_group_id = children[1]->Op().As<LeafOperator>()->origin_group;
+  auto middle_group_id = middle->Op().As<LeafOperator>()->origin_group;
+  auto right_group_id = right->Op().As<LeafOperator>()->origin_group;
 
   const auto &middle_group_aliases_set =
       memo.GetGroupByID(middle_group_id)->GetTableAliases();
@@ -144,10 +142,11 @@ void InnerJoinAssociativity::Transform(
   std::vector<AnnotatedExpression> new_parent_join_predicates;
 
   for (auto predicate : predicates) {
-    if (util::IsSubset(right_join_aliases_set, predicate.table_alias_set))
+    if (util::IsSubset(right_join_aliases_set, predicate.table_alias_set)) {
       new_child_join_predicates.emplace_back(predicate);
-    else
+    } else {
       new_parent_join_predicates.emplace_back(predicate);
+    }
   }
 
   // Construct new child join operator

test/optimizer/optimizer_rule_test.cpp

@@ -90,11 +90,11 @@ TEST_F(OptimizerRuleTests, SimpleAssociativeRuleTest) {
       LogicalGet::make(2, {}, nullptr, "test3"));
 
   auto left_get_group = optimizer.metadata_.memo.InsertExpression(
-      optimizer.metadata_.MakeGroupExpression(left_get), true);
+      optimizer.metadata_.MakeGroupExpression(left_get), false);
   auto middle_get_group = optimizer.metadata_.memo.InsertExpression(
-      optimizer.metadata_.MakeGroupExpression(middle_get), true);
+      optimizer.metadata_.MakeGroupExpression(middle_get), false);
   auto right_get_group = optimizer.metadata_.memo.InsertExpression(
-      optimizer.metadata_.MakeGroupExpression(right_get), true);
+      optimizer.metadata_.MakeGroupExpression(right_get), false);
 
   auto left_leaf = std::make_shared<OperatorExpression>(
       LeafOperator::make(left_get_group->GetGroupID()));
@@ -186,11 +186,11 @@ TEST_F(OptimizerRuleTests, SimpleAssociativeRuleTest2) {
 
   // Create Groups for Get Operators
   auto left_get_group = memo.InsertExpression(
-      optimizer.metadata_.MakeGroupExpression(left_get), true);
+      optimizer.metadata_.MakeGroupExpression(left_get), false);
   auto middle_get_group = memo.InsertExpression(
-      optimizer.metadata_.MakeGroupExpression(middle_get), true);
+      optimizer.metadata_.MakeGroupExpression(middle_get), false);
   auto right_get_group = memo.InsertExpression(
-      optimizer.metadata_.MakeGroupExpression(right_get), true);
+      optimizer.metadata_.MakeGroupExpression(right_get), false);
 
   auto left_leaf = std::make_shared<OperatorExpression>(
       LeafOperator::make(left_get_group->GetGroupID()));