Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Commit 3bb1334

Browse files
committed
Small fixes
1 parent 2f9bb9d commit 3bb1334

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

src/optimizer/optimizer_task.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,7 @@ void OptimizeExpression::execute() {
9595

9696
std::sort(valid_rules.begin(), valid_rules.end());
9797
LOG_TRACE("OptimizeExpression::execute() op %d, valid rules : %lu",
98-
static_cast<int>(group_expr_->Op().type()), valid_rules.size());
99-
98+
static_cast<int>(group_expr_->Op().GetType()), valid_rules.size());
10099
// Apply rule
101100
for (auto &r : valid_rules) {
102101
PushTask(new ApplyRule(group_expr_, r.rule, context_));

src/optimizer/plan_generator.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,6 @@ void PlanGenerator::BuildAggregatePlan(
458458
const std::vector<std::shared_ptr<expression::AbstractExpression>>
459459
*groupby_cols,
460460
std::unique_ptr<expression::AbstractExpression> having_predicate) {
461-
LOG_DEBUG("Generating Aggregate Plan");
462461
vector<planner::AggregatePlan::AggTerm> aggr_terms;
463462
vector<catalog::Column> output_schema_columns;
464463
DirectMapList dml;

test/sql/optimizer_sql_test.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -799,6 +799,7 @@ TEST_F(OptimizerSQLTests, NestedQueryWithAggregationTest) {
799799
}
800800

801801
TEST_F(OptimizerSQLTests, NestedQueryInHavingTest) {
802+
// 4 previously inserted tuples
802803
// TestingSQLUtil::ExecuteSQLQuery("INSERT INTO test VALUES (1, 22, 333);");
803804
// TestingSQLUtil::ExecuteSQLQuery("INSERT INTO test VALUES (2, 11, 000);");
804805
// TestingSQLUtil::ExecuteSQLQuery("INSERT INTO test VALUES (3, 33, 444);");

0 commit comments

Comments
 (0)