Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Commit 3cfcc3b

Browse files
committed
Cleanup comments
1 parent f4f2c97 commit 3cfcc3b

File tree

1 file changed

+21
-15
lines changed

1 file changed

+21
-15
lines changed

src/include/executor/plan_executor.h

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,23 @@
1414

1515
#include "common/internal_types.h"
1616
#include "common/statement.h"
17-
#include "executor/abstract_executor.h"
17+
#include "executor/logical_tile.h"
1818

1919
namespace peloton {
2020

2121
namespace concurrency {
2222
class TransactionContext;
23-
}
23+
} // namespace concurrency
2424

25-
namespace executor {
25+
namespace type {
26+
class Value;
27+
} // namespace type
2628

27-
//===----------------------------------------------------------------------===//
28-
// Plan Executor
29-
//===----------------------------------------------------------------------===//
29+
namespace executor {
3030

31+
/**
32+
* The result of the execution of a query/
33+
*/
3134
struct ExecutionResult {
3235
ResultType m_result;
3336

@@ -46,14 +49,16 @@ struct ExecutionResult {
4649

4750
class PlanExecutor {
4851
public:
49-
PlanExecutor() = default;
50-
DISALLOW_COPY_AND_MOVE(PlanExecutor);
51-
52-
/*
53-
* @brief Use std::vector<type::Value> as params to make it more elegant
54-
* for network
55-
* Before ExecutePlan, a node first receives value list, so we should
56-
* pass value list directly rather than passing Postgres's ParamListInfo
52+
/**
53+
* This function executes a single query in a transactional context. The
54+
* provided callback is called with the results of the execution with it
55+
* completes.
56+
*
57+
* @param plan The physical query plan that will be run
58+
* @param txn The transactional context the query will run in
59+
* @param params All parameters the query references
60+
* @param result_format No idea ...
61+
* @param on_complete The callback function to invoke when the query finishes.
5762
*/
5863
static void ExecutePlan(
5964
std::shared_ptr<planner::AbstractPlan> plan,
@@ -63,8 +68,9 @@ class PlanExecutor {
6368
std::function<void(executor::ExecutionResult,
6469
std::vector<ResultValue> &&)> on_complete);
6570

66-
/*
71+
/**
6772
* @brief When a peloton node recvs a query plan, this function is invoked
73+
*
6874
* @param plan and params
6975
* @return the number of tuple it executes and logical_tile_list
7076
*/

0 commit comments

Comments
 (0)