Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Commit 60162f5

Browse files
author
Erik Sargent
committed
Stable version with commented out lines in bind_node_visitor.cpp
1 parent f45abea commit 60162f5

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/binder/bind_node_visitor.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,10 @@ void BindNodeVisitor::Visit(expression::TupleValueExpression *expr) {
259259
// memory error, but then this prevents the is_not_null flag of a tuple expression from being
260260
// populated in some cases (specifically, when the expression's table name is initially empty).
261261

262-
// if (table_obj == nullptr) {
263-
// BinderContext::GetRegularTableObj(context_, table_name, table_obj, depth);
264-
// }
262+
//if (table_obj == nullptr) {
263+
// LOG_DEBUG("Extracting regular table object");
264+
// BinderContext::GetRegularTableObj(context_, table_name, table_obj, depth);
265+
//}
265266

266267
if (table_obj != nullptr) {
267268
expr->SetIsNotNull(table_obj->GetColumnCatalogEntry(std::get<2>(col_pos_tuple), false)->IsNotNull());

src/include/expression/tuple_value_expression.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ class TupleValueExpression : public AbstractExpression {
9898
}
9999

100100
AbstractExpression *Copy() const override {
101-
TupleValueExpression *t = new TupleValueExpression(*this);
102-
t->SetIsNotNull(GetIsNotNull());
103-
return t;
101+
return new TupleValueExpression(*this);
104102
}
105103

106104
virtual bool operator==(const AbstractExpression &rhs) const override {
@@ -195,7 +193,8 @@ class TupleValueExpression : public AbstractExpression {
195193
value_idx_(other.value_idx_),
196194
tuple_idx_(other.tuple_idx_),
197195
table_name_(other.table_name_),
198-
col_name_(other.col_name_) {}
196+
col_name_(other.col_name_),
197+
is_not_null_(other.is_not_null_) {}
199198

200199
// Bound flag
201200
bool is_bound_ = false;

0 commit comments

Comments
 (0)