Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Commit 7169099

Browse files
committed
Remove superfluous includes; forward declare wherever possible
1 parent ad5c873 commit 7169099

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

src/include/network/postgres_protocol_handler.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include "common/statement.h"
2525
#include "common/statement_cache.h"
2626
#include "traffic_cop/traffic_cop.h"
27-
#include "parser/postgresparser.h"
2827
#include "protocol_handler.h"
2928
#include "traffic_cop/traffic_cop.h"
3029

@@ -33,6 +32,10 @@
3332

3433
namespace peloton {
3534

35+
namespace parser {
36+
class ExplainStatement;
37+
}
38+
3639
namespace network {
3740

3841
typedef std::vector<std::unique_ptr<OutputPacket>> ResponseBuffer;

src/include/parser/explain_statement.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,12 @@
1212

1313
#pragma once
1414

15-
#include "common/logger.h"
16-
#include "common/sql_node_visitor.h"
17-
#include "expression/abstract_expression.h"
1815
#include "parser/sql_statement.h"
19-
#include "parser/table_ref.h"
2016

2117
namespace peloton {
18+
19+
class SqlNodeVisitor;
20+
2221
namespace parser {
2322

2423
/**
@@ -31,7 +30,7 @@ class ExplainStatement : public SQLStatement {
3130
: SQLStatement(StatementType::EXPLAIN) {}
3231
virtual ~ExplainStatement() {}
3332

34-
virtual void Accept(SqlNodeVisitor* /*v*/) override { }
33+
virtual void Accept(UNUSED_ATTRIBUTE SqlNodeVisitor* v) override { }
3534

3635
std::unique_ptr<parser::SQLStatement> real_sql_stmt;
3736
};

src/network/postgres_protocol_handler.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "network/postgres_protocol_handler.h"
2424
#include "network/peloton_server.h"
2525
#include "parser/postgresparser.h"
26+
#include "parser/statements.h"
2627
#include "planner/abstract_plan.h"
2728
#include "planner/delete_plan.h"
2829
#include "planner/insert_plan.h"

0 commit comments

Comments
 (0)