Fix trace level build

Compile with LOG_LEVEL trace and build fails

Author: pranavk

src/binder/binder_context.cpp

@@ -82,21 +82,16 @@ bool BinderContext::GetColumnPosTuple(
     const std::string &col_name,
     std::shared_ptr<catalog::TableCatalogObject> table_obj,
     std::tuple<oid_t, oid_t, oid_t> &col_pos_tuple, type::TypeId &value_type) {
-  try {
-    auto column_object = table_obj->GetColumnObject(col_name);
-    if (column_object == nullptr) {
-      return false;
-    }
-
-    oid_t col_pos = column_object->GetColumnId();
-    col_pos_tuple = std::make_tuple(table_obj->GetDatabaseOid(),
-                                    table_obj->GetTableOid(), col_pos);
-    value_type = column_object->GetColumnType();
-    return true;
-  } catch (CatalogException &e) {
-    LOG_TRACE("Can't find table %d! Return false", std::get<1>(table_id_tuple));
+  auto column_object = table_obj->GetColumnObject(col_name);
+  if (column_object == nullptr) {
     return false;
   }
+
+  oid_t col_pos = column_object->GetColumnId();
+  col_pos_tuple = std::make_tuple(table_obj->GetDatabaseOid(),
+                                  table_obj->GetTableOid(), col_pos);
+  value_type = column_object->GetColumnType();
+  return true;
 }
 
 bool BinderContext::GetColumnPosTuple(

src/executor/create_executor.cpp

@@ -94,7 +94,7 @@ bool CreateExecutor::CreateDatabase(const planner::CreatePlan &node) {
       database_name, txn);
   txn->SetResult(result);
   LOG_TRACE("Result is: %s",
-            ResultTypeToString(current_txn->GetResult()).c_str());
+            ResultTypeToString(txn->GetResult()).c_str());
   return (true);
 }
 

src/optimizer/group.cpp

@@ -58,7 +58,7 @@ GroupExpression *Group::GetBestExpression(
     return std::get<1>(it->second);
   }
   LOG_TRACE("Didn't get best expression with properties %s",
-            properties.ToString().c_str());
+            properties->ToString().c_str());
   return nullptr;
 }
 

src/optimizer/rule_impls.cpp

@@ -260,9 +260,10 @@ void GetToIndexScan::Transform(
                   value_expr)
                   ->GetValue());
           LOG_TRACE("Value Type: %d",
-                    reinterpret_cast<expression::ConstantValueExpression *>(
+                    static_cast<int>(
+                      reinterpret_cast<expression::ConstantValueExpression *>(
                         expr->GetModifiableChild(1))
-                        ->GetValueType());
+                        ->GetValueType()));
         } else {
           value_list.push_back(
               type::ValueFactory::GetParameterOffsetValue(
@@ -271,7 +272,7 @@ void GetToIndexScan::Transform(
                       ->GetValueIdx())
                   .Copy());
           LOG_TRACE("Parameter offset: %s",
-                    (*values.rbegin()).GetInfo().c_str());
+                    (*value_list.rbegin()).GetInfo().c_str());
         }
       }
     }  // Loop predicates end

src/optimizer/util.cpp

@@ -154,9 +154,10 @@ void GetPredicateColumns(const catalog::Schema *schema,
                 expression->GetModifiableChild(1))
                 ->GetValue());
         LOG_TRACE("Value Type: %d",
+                static_cast<int>(
                   reinterpret_cast<expression::ConstantValueExpression *>(
                       expression->GetModifiableChild(1))
-                      ->GetValueType());
+                      ->GetValueType()));
       } else
         values.push_back(
             type::ValueFactory::GetParameterOffsetValue(
@@ -185,9 +186,10 @@ void GetPredicateColumns(const catalog::Schema *schema,
                 expression->GetModifiableChild(1))
                 ->GetValue());
         LOG_TRACE("Value Type: %d",
+                static_cast<int>(
                   reinterpret_cast<expression::ConstantValueExpression *>(
                       expression->GetModifiableChild(0))
-                      ->GetValueType());
+                      ->GetValueType()));
       } else
         values.push_back(
             type::ValueFactory::GetParameterOffsetValue(

src/traffic_cop/traffic_cop.cpp

@@ -212,7 +212,7 @@ void TrafficCop::ExecuteStatementPlanGetResult() {
       txn_result == ResultType::FAILURE) {
     LOG_TRACE(
         "About to commit: single stmt: %d, init_failure: %d, txn_result: %s",
-        is_single_statement_txn_, init_failure,
+        single_statement_txn_, init_failure,
         ResultTypeToString(txn_result).c_str());
     switch (txn_result) {
       case ResultType::SUCCESS: