Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Commit bac11dd

Browse files
committed
addressing pooja's comments
1 parent 7f7fc44 commit bac11dd

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

test/optimizer/optimizer_rule_test.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include "expression/abstract_expression.h"
2525
#include "expression/operator_expression.h"
2626

27-
#define private public
2827
#include "optimizer/operator_expression.h"
2928
#include "optimizer/operators.h"
3029
#include "optimizer/optimizer.h"

test/sql/testing_sql_util.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,11 @@ void TestingSQLUtil::ExecuteSQLQueryAndCheckResult(
249249
// Execute query
250250
TestingSQLUtil::ExecuteSQLQuery(std::move(query), result, tuple_descriptor,
251251
rows_changed, error_message);
252-
unsigned int rows = tuple_descriptor.size() == 0
253-
? result.size()
254-
: result.size() / tuple_descriptor.size();
252+
if (tuple_descriptor.size() == 0) {
253+
PELOTON_ASSERT(result.size() == 0);
254+
return;
255+
}
256+
unsigned int rows = result.size() / tuple_descriptor.size();
255257

256258
// Build actual result as set of rows for comparison
257259
std::vector<std::string> actual_result(rows);

0 commit comments

Comments
 (0)