Skip to content
This repository was archived by the owner on Sep 27, 2019. It is now read-only.

Commit dcabc33

Browse files
committed
Address comments
1 parent a8b1a6b commit dcabc33

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

src/binder/bind_node_visitor.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,9 +75,8 @@ void BindNodeVisitor::Visit(parser::SelectStatement *node) {
7575
}
7676
select_element->DeriveSubqueryFlag();
7777

78-
// Recursively deduce expression value type
78+
// Traverse the expression to deduce expression value type and name
7979
select_element->DeduceExpressionType();
80-
// Recursively deduce expression name
8180
select_element->DeduceExpressionName();
8281
new_select_list.push_back(std::move(select_element));
8382
}

src/include/expression/expression_util.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ class ExpressionUtil {
428428
++tuple_idx) {
429429
if (child_expr->GetExpressionType() != ExpressionType::VALUE_TUPLE &&
430430
child_expr_maps[tuple_idx].count(child_expr)) {
431-
// EvaluateExpression({child_expr_map}, child_expr);
432431
expr->SetChild(i, new TupleValueExpression(
433432
child_expr->GetValueType(), tuple_idx,
434433
child_expr_maps[tuple_idx][child_expr]));

src/optimizer/query_to_operator_transformer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ bool QueryToOperatorTransformer::IsSupportedConjunctivePredicate(
406406
auto expr_type = expr->GetExpressionType();
407407
// Subquery with IN
408408
if (expr_type == ExpressionType::COMPARE_IN &&
409+
expr->GetChild(0)->GetExpressionType() != ExpressionType::ROW_SUBQUERY &&
409410
expr->GetChild(1)->GetExpressionType() == ExpressionType::ROW_SUBQUERY) {
410411
return true;
411412
}

0 commit comments

Comments
 (0)