Changing variables default values in order to fix issue #1

Author: jnonino

README.md

@@ -34,11 +34,10 @@ Check the section "Other modules that you may need to use this module" for detai
 * region: AWS Region the infrastructure is hosted in.
 * ecs_cluster_arn: The ECS Cluster where the scheduled task will run.
 * event_rule_name: The rule's name.
-* ecs_execution_task_role_arn: The task definition execution role.
+* event_target_ecs_target_subnets: The subnets associated with the task or service.
+* event_target_ecs_target_task_definition_arn: The ARN of the task definition to use if the event target is an Amazon ECS cluster.
 * event_rule_schedule_expression: (Required, if event_pattern isn't specified) The scheduling expression. For example, cron(0 20 * * ? *) or rate(5 minutes).
 * event_rule_event_pattern: (Required, if schedule_expression isn't specified) Event pattern described a JSON object. See full documentation of CloudWatch Events and Event Patterns for details.
-* event_target_ecs_target_task_definition_arn: The ARN of the task definition to use if the event target is an Amazon ECS cluster.
-* event_target_ecs_target_subnets: The subnets associated with the task or service.
 * event_rule_description: (Optional) The description of the rule.
 * event_rule_role_arn: (Optional) The Amazon Resource Name (ARN) associated with the role that is used for target invocation.
 * event_rule_is_enabled: (Optional) Whether the rule should be enabled (defaults to true).

files/iam/ecs_task_execution_iam_role.json

@@ -0,0 +1,13 @@
+{
+    "Version": "2012-10-17",
+    "Statement": [
+        {
+            "Effect": "Allow",
+            "Principal": {
+                "Service": "ecs-tasks.amazonaws.com"
+            },
+            "Action": "sts:AssumeRole",
+            "Sid": ""
+        }
+    ]
+}

main.tf

@@ -6,6 +6,19 @@ provider "aws" {
   region  = var.region
 }
 
+# ---------------------------------------------------------------------------------------------------------------------
+# AWS ECS Task Execution Role
+# ---------------------------------------------------------------------------------------------------------------------
+resource "aws_iam_role" "ecs_task_execution_role" {
+  name               = "${var.name_preffix}-ecs-task-execution-role"
+  assume_role_policy = file("${path.module}/files/iam/ecs_task_execution_iam_role.json")
+}
+
+resource "aws_iam_role_policy_attachment" "ecs_task_execution_role_policy_attach" {
+  role       = aws_iam_role.ecs_task_execution_role.name
+  policy_arn = "arn:aws:iam::aws:policy/service-role/AmazonECSTaskExecutionRolePolicy"
+}
+
 # ---------------------------------------------------------------------------------------------------------------------
 # CLOUDWATCH EVENT ROLE
 # ---------------------------------------------------------------------------------------------------------------------
@@ -17,7 +30,7 @@ resource "aws_iam_role" "scheduled_task_cw_event_role" {
 data "template_file" "scheduled_task_cw_event_role_cloudwatch_policy" {
   template = "${file("${path.module}/files/iam/scheduled_task_cw_event_role_cloudwatch_policy.json")}"
   vars     = {
-    TASK_EXECUTION_ROLE_ARN = var.ecs_execution_task_role_arn
+    TASK_EXECUTION_ROLE_ARN = aws_iam_role.ecs_task_execution_role.arn
   }
 }
 

variables.tf

@@ -23,21 +23,24 @@ variable "event_rule_name" {
   description = "The rule's name."
 }
 
-variable "event_rule_description" {
-  description = "(Optional) The description of the rule."
-}
-
 variable "event_rule_schedule_expression" {
   description = "(Required, if event_pattern isn't specified) The scheduling expression. For example, cron(0 20 * * ? *) or rate(5 minutes)."
+  default     = null
 }
 
 variable "event_rule_event_pattern" {
   description = "(Required, if schedule_expression isn't specified) Event pattern described a JSON object. See full documentation of CloudWatch Events and Event Patterns for details."
+  default     = null
+}
+
+variable "event_rule_description" {
+  description = "(Optional) The description of the rule."
+  default     = null
 }
 
 variable "event_rule_role_arn" {
   description = "(Optional) The Amazon Resource Name (ARN) associated with the role that is used for target invocation."
-  default     = ""
+  default     = null
 }
 
 variable "event_rule_is_enabled" {
@@ -53,28 +56,28 @@ variable "ecs_cluster_arn" {
   description = "The ECS Cluster where the scheduled task will run"
 }
 
+variable "event_target_ecs_target_subnets" {
+  description = "The subnets associated with the task or service."
+  type        = list
+}
+
+variable "event_target_ecs_target_task_definition_arn" {
+  description = "(Required) The ARN of the task definition to use if the event target is an Amazon ECS cluster."
+}
+
 variable "event_target_target_id" {
   description = "(Optional) The unique target assignment ID. If missing, will generate a random, unique id."
-  default     = ""
+  default     = null
 }
 
 variable "event_target_input" {
   description = "(Optional) Valid JSON text passed to the target."
-  default     = ""
+  default     = null
 }
 
 variable "event_target_input_path" {
   description = "(Optional) The value of the JSONPath that is used for extracting part of the matched event when passing it to the target."
-  default     = ""
-}
-
-variable "event_target_ecs_target_task_definition_arn" {
-  description = "(Required) The ARN of the task definition to use if the event target is an Amazon ECS cluster."
-}
-
-variable "event_target_ecs_target_subnets" {
-  description = "The subnets associated with the task or service."
-  type        = list
+  default     = null
 }
 
 variable "event_target_ecs_target_security_groups" {
@@ -102,10 +105,5 @@ variable "event_target_ecs_target_platform_version" {
 
 variable "event_target_ecs_target_group" {
   description = "(Optional) Specifies an ECS task group for the task. The maximum length is 255 characters."
-  default     = ""
+  default     = null
 }
-
-variable "ecs_execution_task_role_arn" {
-  description = "The task definition execution role"
-}
-