Updating to Terraform 0.13

Author: jnonino

.circleci/config.yml

@@ -2,14 +2,14 @@ version: 2
 jobs:
   check-format:
     docker:
-      - image: hashicorp/terraform:0.12.29
+      - image: hashicorp/terraform
     steps:
       - checkout
       - run:
           command: terraform fmt -check -recursive -diff
   validate:
     docker:
-      - image: hashicorp/terraform:0.12.29
+      - image: hashicorp/terraform
     steps:
       - checkout
       - run:

autoscaling.tf

@@ -2,12 +2,12 @@
 # AWS ECS Auto Scale Role
 #------------------------------------------------------------------------------
 resource "aws_iam_role" "ecs_autoscale_role" {
-  name               = "${var.name_preffix}-ecs-autoscale-role"
+  name               = "${var.name_prefix}-ecs-autoscale-role"
   assume_role_policy = file("${path.module}/files/iam/ecs_autoscale_iam_role.json")
 }
 
 resource "aws_iam_role_policy" "ecs_autoscale_role_policy" {
-  name = "${var.name_preffix}-ecs-autoscale-role-policy"
+  name = "${var.name_prefix}-ecs-autoscale-role-policy"
   role = aws_iam_role.ecs_autoscale_role.id
   policy = file(
     "${path.module}/files/iam/ecs_autoscale_iam_role_policy.json",
@@ -18,7 +18,7 @@ resource "aws_iam_role_policy" "ecs_autoscale_role_policy" {
 # AWS Auto Scaling - CloudWatch Alarm CPU High
 #------------------------------------------------------------------------------
 resource "aws_cloudwatch_metric_alarm" "cpu_high" {
-  alarm_name          = "${var.name_preffix}-cpu-high"
+  alarm_name          = "${var.name_prefix}-cpu-high"
   comparison_operator = "GreaterThanOrEqualToThreshold"
   evaluation_periods  = var.max_cpu_evaluation_period
   metric_name         = "CPUUtilization"
@@ -37,7 +37,7 @@ resource "aws_cloudwatch_metric_alarm" "cpu_high" {
 # AWS Auto Scaling - CloudWatch Alarm CPU Low
 #------------------------------------------------------------------------------
 resource "aws_cloudwatch_metric_alarm" "cpu_low" {
-  alarm_name          = "${var.name_preffix}-cpu-low"
+  alarm_name          = "${var.name_prefix}-cpu-low"
   comparison_operator = "LessThanOrEqualToThreshold"
   evaluation_periods  = var.min_cpu_evaluation_period
   metric_name         = "CPUUtilization"
@@ -56,7 +56,7 @@ resource "aws_cloudwatch_metric_alarm" "cpu_low" {
 # AWS Auto Scaling - Scaling Up Policy
 #------------------------------------------------------------------------------
 resource "aws_appautoscaling_policy" "scale_up_policy" {
-  name               = "${var.name_preffix}-scale-up-policy"
+  name               = "${var.name_prefix}-scale-up-policy"
   depends_on         = [aws_appautoscaling_target.scale_target]
   service_namespace  = "ecs"
   resource_id        = "service/${var.ecs_cluster_name}/${aws_ecs_service.service.name}"
@@ -76,7 +76,7 @@ resource "aws_appautoscaling_policy" "scale_up_policy" {
 # AWS Auto Scaling - Scaling Down Policy
 #------------------------------------------------------------------------------
 resource "aws_appautoscaling_policy" "scale_down_policy" {
-  name               = "${var.name_preffix}-scale-down-policy"
+  name               = "${var.name_prefix}-scale-down-policy"
   depends_on         = [aws_appautoscaling_target.scale_target]
   service_namespace  = "ecs"
   resource_id        = "service/${var.ecs_cluster_name}/${aws_ecs_service.service.name}"

examples/test/main.tf

@@ -4,14 +4,14 @@ provider "aws" {
 
 module "cluster" {
   source  = "cn-terraform/ecs-cluster/aws"
-  version = "1.0.5"
+  version = "1.0.6"
   name    = "test-cluster"
 }
 
 module "base-network" {
   source                                      = "cn-terraform/networking/aws"
-  version                                     = "2.0.7"
-  name_preffix                                = "test-networking"
+  version                                     = "2.0.10"
+  name_prefix                                 = "test-networking"
   vpc_cidr_block                              = "192.168.0.0/16"
   availability_zones                          = ["us-east-1a", "us-east-1b", "us-east-1c", "us-east-1d"]
   public_subnets_cidrs_per_availability_zone  = ["192.168.0.0/19", "192.168.32.0/19", "192.168.64.0/19", "192.168.96.0/19"]
@@ -20,24 +20,24 @@ module "base-network" {
 
 module "load_balancer" {
   source          = "cn-terraform/ecs-alb/aws"
-  version         = "1.0.2"
-  name_preffix    = "test-alb"
+  version         = "1.0.5"
+  name_prefix     = "test-alb"
   vpc_id          = module.base-network.vpc_id
   private_subnets = module.base-network.private_subnets_ids
   public_subnets  = module.base-network.public_subnets_ids
 }
 
 module "td" {
   source          = "cn-terraform/ecs-fargate-task-definition/aws"
-  version         = "1.0.11"
-  name_preffix    = "test-td"
+  version         = "1.0.15"
+  name_prefix     = "test-td"
   container_image = "ubuntu"
   container_name  = "test"
 }
 
 module "service" {
   source                  = "../../"
-  name_preffix            = "test-service"
+  name_prefix             = "test-service"
   vpc_id                  = module.base-network.vpc_id
   ecs_cluster_arn         = module.cluster.aws_ecs_cluster_cluster_arn
   task_definition_arn     = module.td.aws_ecs_task_definition_td_arn

main.tf

@@ -30,7 +30,7 @@ data "aws_lb_listener" "lb_https_listeners" {
 # AWS ECS SERVICE
 #------------------------------------------------------------------------------
 resource "aws_ecs_service" "service" {
-  name = "${var.name_preffix}-service"
+  name = "${var.name_prefix}-service"
   # capacity_provider_strategy - (Optional) The capacity provider strategy to use for the service. Can be one or more. Defined below.
   cluster                            = var.ecs_cluster_arn
   deployment_maximum_percent         = var.deployment_maximum_percent
@@ -88,15 +88,15 @@ resource "aws_ecs_service" "service" {
   }
   task_definition = var.task_definition_arn
   tags = {
-    Name = "${var.name_preffix}-ecs-tasks-sg"
+    Name = "${var.name_prefix}-ecs-tasks-sg"
   }
 }
 
 #------------------------------------------------------------------------------
 # AWS SECURITY GROUP - ECS Tasks, allow traffic only from Load Balancer
 #------------------------------------------------------------------------------
 resource "aws_security_group" "ecs_tasks_sg" {
-  name        = "${var.name_preffix}-ecs-tasks-sg"
+  name        = "${var.name_prefix}-ecs-tasks-sg"
   description = "Allow inbound access from the LB only"
   vpc_id      = var.vpc_id
   egress {
@@ -106,7 +106,7 @@ resource "aws_security_group" "ecs_tasks_sg" {
     cidr_blocks = ["0.0.0.0/0"]
   }
   tags = {
-    Name = "${var.name_preffix}-ecs-tasks-sg"
+    Name = "${var.name_prefix}-ecs-tasks-sg"
   }
 }
 

outputs.tf

@@ -25,22 +25,22 @@ output "aws_ecs_service_service_desired_count" {
 # AWS SECURITY GROUPS
 #------------------------------------------------------------------------------
 output "ecs_tasks_sg_id" {
-  description = "$${var.name_preffix} ECS Tasks Security Group - The ID of the security group"
+  description = "$${var.name_prefix} ECS Tasks Security Group - The ID of the security group"
   value       = aws_security_group.ecs_tasks_sg.id
 }
 
 output "ecs_tasks_sg_arn" {
-  description = "$${var.name_preffix} ECS Tasks Security Group - The ARN of the security group"
+  description = "$${var.name_prefix} ECS Tasks Security Group - The ARN of the security group"
   value       = aws_security_group.ecs_tasks_sg.arn
 }
 
 output "ecs_tasks_sg_name" {
-  description = "$${var.name_preffix} ECS Tasks Security Group - The name of the security group"
+  description = "$${var.name_prefix} ECS Tasks Security Group - The name of the security group"
   value       = aws_security_group.ecs_tasks_sg.name
 }
 
 output "ecs_tasks_sg_description" {
-  description = "$${var.name_preffix} ECS Tasks Security Group - The description of the security group"
+  description = "$${var.name_prefix} ECS Tasks Security Group - The description of the security group"
   value       = aws_security_group.ecs_tasks_sg.description
 }
 

variables.tf

@@ -1,8 +1,8 @@
 #------------------------------------------------------------------------------
 # Misc
 #------------------------------------------------------------------------------
-variable "name_preffix" {
-  description = "Name preffix for resources on AWS"
+variable "name_prefix" {
+  description = "Name prefix for resources on AWS"
 }
 
 #------------------------------------------------------------------------------

versions.tf

@@ -1,4 +1,9 @@
 
 terraform {
-  required_version = ">= 0.12"
+  required_version = ">= 0.13"
+  required_providers {
+    aws = {
+      source = "hashicorp/aws"
+    }
+  }
 }