Using a module to create Cloudwatch logs resources

Author: jnonino

logs.tf

@@ -1,16 +1,11 @@
 # ---------------------------------------------------------------------------------------------------------------------
 # AWS Cloudwatch Logs
 # ---------------------------------------------------------------------------------------------------------------------
-resource "aws_cloudwatch_log_group" "log_group" {
-  name              = local.log_options["awslogs-group"]
-  retention_in_days = "7"
-  tags = {
-    Name = local.log_options["awslogs-group"]
-  }
-}
-
-resource "aws_cloudwatch_log_stream" "log_stream" {
-  name           = local.log_options["awslogs-group"]
-  log_group_name = aws_cloudwatch_log_group.log_group.name
+module "aws_cw_logs" {
+  source  = "jnonino/cloudwatch-logs/aws"
+  version = "1.0.2"
+  logs_path                   = local.log_options["awslogs-group"]
+  profile                     = var.profile
+  region                      = var.region
 }
 

server.tf

@@ -43,11 +43,6 @@ resource "aws_ecs_task_definition" "td" {
   dynamic "placement_constraints" {
     for_each = var.placement_constraints
     content {
-      # TF-UPGRADE-TODO: The automatic upgrade tool can't predict
-      # which keys might be set in maps assigned here, so it has
-      # produced a comprehensive set here. Consider simplifying
-      # this after confirming which keys can be set in practice.
-
       expression = lookup(placement_constraints.value, "expression", null)
       type       = placement_constraints.value.type
     }
@@ -58,11 +53,6 @@ resource "aws_ecs_task_definition" "td" {
   dynamic "proxy_configuration" {
     for_each = var.proxy_configuration
     content {
-      # TF-UPGRADE-TODO: The automatic upgrade tool can't predict
-      # which keys might be set in maps assigned here, so it has
-      # produced a comprehensive set here. Consider simplifying
-      # this after confirming which keys can be set in practice.
-
       container_name = proxy_configuration.value.container_name
       properties     = lookup(proxy_configuration.value, "properties", null)
       type           = lookup(proxy_configuration.value, "type", null)