Merge pull request #7 from mxfactorial/feature/vpc-endpoint

jnonino · web-flow · commit b35dc8508671 · 2020-02-24T09:13:01.000Z
vpc endpoint user delight
diff --git a/main.tf b/main.tf
@@ -52,7 +52,7 @@ resource "aws_ecs_service" "service" {
       field = lookup(ordered_placement_strategy.value, "field", null)
     }
   }
-  health_check_grace_period_seconds  = var.health_check_grace_period_seconds
+  health_check_grace_period_seconds = var.health_check_grace_period_seconds
   dynamic "placement_constraints" {
     for_each = var.placement_constraints
     content {
@@ -70,7 +70,7 @@ resource "aws_ecs_service" "service" {
     }
   }
   network_configuration {
-    security_groups  =[aws_security_group.ecs_tasks_sg.id]
+    security_groups  = concat([aws_security_group.ecs_tasks_sg.id], var.security_groups)
     subnets          = var.private_subnets
     assign_public_ip = var.assign_public_ip
   }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ resource "aws_ecs_service" "service" {`
`52`	`52`	`field = lookup(ordered_placement_strategy.value, "field", null)`
`53`	`53`	`}`
`54`	`54`	`}`
`55`		`- health_check_grace_period_seconds = var.health_check_grace_period_seconds`
	`55`	`+ health_check_grace_period_seconds = var.health_check_grace_period_seconds`
`56`	`56`	`dynamic "placement_constraints" {`
`57`	`57`	`for_each = var.placement_constraints`
`58`	`58`	`content {`
`@@ -70,7 +70,7 @@ resource "aws_ecs_service" "service" {`
`70`	`70`	`}`
`71`	`71`	`}`
`72`	`72`	`network_configuration {`
`73`		`- security_groups =[aws_security_group.ecs_tasks_sg.id]`
	`73`	`+ security_groups = concat([aws_security_group.ecs_tasks_sg.id], var.security_groups)`
`74`	`74`	`subnets = var.private_subnets`
`75`	`75`	`assign_public_ip = var.assign_public_ip`
`76`	`76`	`}`