Fixing error with subnets

Author: jnonino

README.md

@@ -17,7 +17,7 @@ Check valid versions on:
 
         module "ecs-fargate-service" {
             source              = "cn-terraform/ecs-fargate-service/aws"
-            version             = "1.0.5"
+            version             = "1.0.6"
             name_preffix        = var.name_preffix
             profile             = var.profile
             region              = var.region
@@ -26,7 +26,8 @@ Check valid versions on:
             container_port      = module.td.container_port
             ecs_cluster_name    = module.ecs-cluster.aws_ecs_cluster_cluster_name
             ecs_cluster_arn     = module.ecs-cluster.aws_ecs_cluster_cluster_arn
-            subnets             = module.networking.private_subnets_ids
+            private_subnets     = module.networking.private_subnets_ids
+            public_subnets      = module.networking.public_subnets_ids
         }
 
 Check the section "Other modules that you may need to use this module" for details about modules mentioned in the usage example.

main.tf

@@ -80,7 +80,7 @@ resource "aws_ecs_service" "service" {
   }
   network_configuration {
     security_groups  =[aws_security_group.ecs_tasks_sg.id]
-    subnets          = var.subnets
+    subnets          = var.private_subnets
     assign_public_ip = var.assign_public_ip
   }
   load_balancer {
@@ -227,7 +227,7 @@ resource "aws_lb" "lb" {
   name                             = "${var.name_preffix}-lb"
   internal                         = false
   load_balancer_type               = "application"
-  subnets                          = var.subnets
+  subnets                          = var.public_subnets
   security_groups                  = [aws_security_group.lb_sg.id]
   enable_deletion_protection       = false
   enable_cross_zone_load_balancing = true

variables.tf

@@ -38,8 +38,13 @@ variable "ecs_cluster_arn" {
   description = "ARN of an ECS cluster"
 }
 
-variable "subnets" {
-  description = "The subnets associated with the task or service."
+variable "private_subnets" {
+  description = "The private subnets associated with the task or service."
+  type        = list
+}
+
+variable "public_subnets" {
+  description = "The public subnets associated with the task or service."
   type        = list
 }