Skip to content

Commit 0f1b457

Browse files
committed
Removing extra variables.
1 parent 77a3aff commit 0f1b457

File tree

4 files changed

+1
-67
lines changed

4 files changed

+1
-67
lines changed

README.md

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -14,60 +14,3 @@ This Terraform module creates an AWS ECS Fargate task definition.
1414
Check versions for this module on:
1515
* Github Releases: <https://github.com/cn-terraform/terraform-aws-ecs-fargate-task-definition/releases>
1616
* Terraform Module Registry: <https://registry.terraform.io/modules/cn-terraform/ecs-fargate-task-definition/aws>
17-
18-
module "td" {
19-
source = "cn-terraform/ecs-fargate-task-definition/aws"
20-
version = "1.0.9"
21-
name_preffix = var.name_preffix
22-
profile = var.profile
23-
region = var.region
24-
container_name = "${var.name_preffix}-<NAME>"
25-
container_image = "<IMAGE_NAME>:<IMAGE_TAG>"
26-
container_port = <PORT>
27-
}
28-
29-
## Input values
30-
31-
* container_port: Port on which the container is listening.
32-
* container_image: The image used to start the container.
33-
* container_name: The name of the container. Up to 255 characters ([a-z], [A-Z], [0-9], -, _ allowed).
34-
* command: (Optional) The command that is passed to the container.
35-
* container_cpu: (Optional) The number of cpu units to reserve for the container. This is optional for tasks using Fargate launch type and the total amount of container_cpu of all containers in a task will need to be lower than the task-level cpu value.
36-
* container_depends_on: (Optional) The dependencies defined for container startup and shutdown. A container can contain multiple dependencies. When a dependency is defined for container startup, for container shutdown it is reversed.
37-
* container_memory: (Optional) The amount of memory (in MiB) to allow the container to use. This is a hard limit, if the container attempts to exceed the container_memory, the container is killed. This field is optional for Fargate launch type and the total amount of container_memory of all containers in a task will need to be lower than the task memory value.
38-
* container_memory_reservation: (Optional) The amount of memory (in MiB) to reserve for the container. If container needs to exceed this threshold, it can do so up to the set container_memory hard limit.
39-
* dns_servers: (Optional) Container DNS servers. This is a list of strings specifying the IP addresses of the DNS servers.
40-
* entrypoint: (Optional) The entry point that is passed to the container.
41-
* environment: (Optional) The environment variables to pass to the container. This is a list of maps. Each map should contain `name` and `value`.
42-
* essential: (Optional) Determines whether all other containers in a task are stopped, if this container fails or stops for any reason. Due to how Terraform type casts booleans in json it is required to double quote this value.
43-
* healthcheck: (Optional) A map containing command (string), interval (duration in seconds), retries (1-10, number of times to retry before marking container unhealthy, and startPeriod (0-300, optional grace period to wait, in seconds, before failed healthchecks count toward retries).
44-
* links: (Optional) List of container names this container can communicate with without port mappings.
45-
* mount_points: (Optional) Container mount points. This is a list of maps, where each map should contain a `containerPath` and `sourceVolume`.
46-
* readonly_root_filesystem: (Optional) Determines whether a container is given read-only access to its root filesystem. Due to how Terraform type casts booleans in json it is required to double quote this value.
47-
* repository_credentials: (Optional) Container repository credentials; required when using a private repo. This map currently supports a single key; "credentialsParameter", which should be the ARN of a Secrets Manager's secret holding the credentials.
48-
* secrets: (Optional) The secrets to pass to the container. This is a list of maps.
49-
* start_timeout: (Optional) Time duration (in seconds) to wait before giving up on resolving dependencies for a container.
50-
* stop_timeout: (Optional) Timeout in seconds between sending SIGTERM and SIGKILL to container.
51-
* ulimits: (Optional) Container ulimit settings. This is a list of maps, where each map should contain "name", "hardLimit" and "softLimit".
52-
* user: (Optional) The user to run as inside the container. Can be any of these formats: user, user:group, uid, uid:gid, user:gid, uid:group.
53-
* volumes_from: (Optional) A list of VolumesFrom maps which contain "sourceContainer" (name of the container that has the volumes to mount) and "readOnly" (whether the container can write to the volume).
54-
* working_directory: (Optional) The working directory to run commands inside the container.
55-
* placement_constraints: (Optional) A set of placement constraints rules that are taken into consideration during task placement. Maximum number of placement_constraints is 10. This is a list of maps, where each map should contain "type" and "expression".
56-
* proxy_configuration: (Optional) The proxy configuration details for the App Mesh proxy. This is a list of maps, where each map should contain "container_name", "properties" and "type"
57-
* system_controls: A list of namespaced kernel parameters to set in the container, mapping to the --sysctl option to docker run. This is a list of maps: { namespace = \"\", value = \"\"}"
58-
* firelens_configuration: The FireLens configuration for the container. This is used to specify and configure a log router for container logs. For more details, see https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_FirelensConfiguration.html
59-
* log_configuration: Log configuration options to send to a custom log driver for the container. For more details, see https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_LogConfiguration.html
60-
61-
## Output values
62-
63-
* aws_iam_role_ecs_task_execution_role_arn - The Amazon Resource Name (ARN) specifying the role.
64-
* aws_iam_role_ecs_task_execution_role_create_date - The creation date of the IAM role.
65-
* aws_iam_role_ecs_task_execution_role_description - The description of the role.
66-
* aws_iam_role_ecs_task_execution_role_id - The name of the role.
67-
* aws_iam_role_ecs_task_execution_role_name - The name of the role.
68-
* aws_iam_role_ecs_task_execution_role_unique_id - The stable and unique string identifying the role.
69-
* aws_ecs_task_definition_td_arn - Full ARN of the Task Definition (including both family and revision).
70-
* aws_ecs_task_definition_td_family - The family of the Task Definition.
71-
* aws_ecs_task_definition_td_revision - The revision of the task in a particular family.
72-
* container_port: Port on which the container is listening
73-

main.tf

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,5 @@ resource "aws_ecs_task_definition" "td" {
111111
}
112112
}
113113

114-
115-
114+
# TODO - Add this missing parameter
116115
# inference_accelerator - (Optional) Configuration block(s) with Inference Accelerators settings. Detailed below.

outputs.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ output "aws_ecs_task_definition_td_revision" {
4343
description = "The revision of the task in a particular family."
4444
value = aws_ecs_task_definition.td.revision
4545
}
46-
output "container_port" {
47-
description = "Port on which the container is listening"
48-
value = var.container_port
49-
}
5046
output "container_name" {
5147
description = "Name of the container"
5248
value = var.container_name

variables.tf

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ variable "region" {
1919
# ---------------------------------------------------------------------------------------------------------------------
2020
# AWS ECS Container Definition Variables
2121
# ---------------------------------------------------------------------------------------------------------------------
22-
variable "container_port" {
23-
description = "Port on which the container is listening"
24-
}
25-
2622
variable "container_image" {
2723
description = "The image used to start the container."
2824
}

0 commit comments

Comments
 (0)