Merge pull request #130 from cnblogs/use-ThrottlingFailurePolicy

Use ThrottlingFailurePolicy as default failure policy

Author: cnblogs-dudu

Enyim.Caching/Configuration/MemcachedClientConfiguration.cs

@@ -82,6 +82,8 @@ public MemcachedClientConfiguration(
                 _logger.LogInformation($"{nameof(SocketPool.QueueTimeout)}: {SocketPool.QueueTimeout}");
 
                 SocketPool.InitPoolTimeout = options.SocketPool.InitPoolTimeout;
+
+                SocketPool.FailurePolicyFactory = options.SocketPool.FailurePolicyFactory;
             }
 
             Protocol = options.Protocol;

Enyim.Caching/Configuration/MemcachedClientOptions.cs

@@ -69,6 +69,7 @@ public class SocketPoolOptions
         public TimeSpan DeadTimeout { get; set; } = new TimeSpan(0, 0, 10);
         public TimeSpan QueueTimeout { get; set; } = new TimeSpan(0, 0, 0, 0, 100);
         public TimeSpan InitPoolTimeout { get; set; } = new TimeSpan(0, 1, 0);
+        public INodeFailurePolicyFactory FailurePolicyFactory { get; set; } = new ThrottlingFailurePolicyFactory(5, TimeSpan.FromMilliseconds(2000));
 
         public void CheckPoolSize()
         {

Enyim.Caching/Configuration/SocketPoolConfiguration.cs

@@ -15,7 +15,7 @@ public class SocketPoolConfiguration : ISocketPoolConfiguration
         private TimeSpan deadTimeout = new TimeSpan(0, 0, 10);
         private TimeSpan queueTimeout = new TimeSpan(0, 0, 0, 0, 100);
         private TimeSpan _initPoolTimeout = new TimeSpan(0, 1, 0);
-        private INodeFailurePolicyFactory policyFactory = new FailImmediatelyPolicyFactory();
+        private INodeFailurePolicyFactory FailurePolicyFactory = new ThrottlingFailurePolicyFactory(5, TimeSpan.FromMilliseconds(2000));
 
         int ISocketPoolConfiguration.MinPoolSize
         {
@@ -96,13 +96,13 @@ TimeSpan ISocketPoolConfiguration.DeadTimeout
 
         INodeFailurePolicyFactory ISocketPoolConfiguration.FailurePolicyFactory
         {
-            get { return this.policyFactory; }
+            get { return this.FailurePolicyFactory; }
             set
             {
                 if (value == null)
                     throw new ArgumentNullException("value");
 
-                this.policyFactory = value;
+                this.FailurePolicyFactory = value;
             }
         }
     }

Enyim.Caching/Memcached/MemcachedNode.cs

@@ -87,7 +87,7 @@ public bool IsAlive
 
         /// <summary>
         /// Gets a value indicating whether the server is working or not.
-        /// 
+        ///
         /// If the server is back online, we'll ercreate the internal socket pool and mark the server as alive so operations can target it.
         /// </summary>
         /// <returns>true if the server is alive; false otherwise.</returns>
@@ -263,7 +263,7 @@ private class InternalPoolImpl : IDisposable
             /// <summary>
             /// A list of already connected but free to use sockets
             /// </summary>
-            private InterlockedStack<PooledSocket> freeItems;
+            private InterlockedStack<PooledSocket> _freeItems;
 
             private bool isDisposed;
             private bool isAlive;
@@ -300,7 +300,7 @@ internal InternalPoolImpl(
                 this.maxItems = config.MaxPoolSize;
 
                 _semaphore = new SemaphoreSlim(maxItems, maxItems);
-                this.freeItems = new InterlockedStack<PooledSocket>();
+                _freeItems = new InterlockedStack<PooledSocket>();
 
                 _logger = logger;
                 _isDebugEnabled = _logger.IsEnabled(LogLevel.Debug);
@@ -314,7 +314,14 @@ internal void InitPool()
                     {
                         for (int i = 0; i < this.minItems; i++)
                         {
-                            this.freeItems.Push(this.CreateSocket());
+                            try
+                            {
+                                _freeItems.Push(CreateSocket());
+                            }
+                            catch (Exception ex)
+                            {
+                                _logger.LogError(ex, $"Failed to put {nameof(PooledSocket)} {i} in Pool");
+                            }
 
                             // cannot connect to the server
                             if (!this.isAlive)
@@ -342,7 +349,14 @@ internal async Task InitPoolAsync()
                     {
                         for (int i = 0; i < this.minItems; i++)
                         {
-                            this.freeItems.Push(await this.CreateSocketAsync());
+                            try
+                            {
+                                _freeItems.Push(await CreateSocketAsync());
+                            }
+                            catch(Exception ex)
+                            {
+                                _logger.LogError(ex, $"Failed to put {nameof(PooledSocket)} {i} in Pool");
+                            }
 
                             // cannot connect to the server
                             if (!this.isAlive)
@@ -432,7 +446,7 @@ public IPooledSocketResult Acquire()
                 }
 
                 // do we have free items?
-                if (this.freeItems.TryPop(out retval))
+                if (_freeItems.TryPop(out retval))
                 {
                     #region [ get it from the pool         ]
 
@@ -538,7 +552,7 @@ public async Task<IPooledSocketResult> AcquireAsync()
                 }
 
                 // do we have free items?
-                if (this.freeItems.TryPop(out retval))
+                if (_freeItems.TryPop(out retval))
                 {
                     #region [ get it from the pool         ]
 
@@ -643,7 +657,7 @@ private void ReleaseSocket(PooledSocket socket)
                         try
                         {
                             // mark the item as free
-                            this.freeItems.Push(socket);
+                            _freeItems.Push(socket);
                         }
                         finally
                         {
@@ -679,7 +693,7 @@ private void ReleaseSocket(PooledSocket socket)
                 {
                     try
                     {
-                        // one of our previous sockets has died, so probably all of them 
+                        // one of our previous sockets has died, so probably all of them
                         // are dead. so, kill the socket (this will eventually clear the pool as well)
                         socket.Destroy();
                     }
@@ -716,7 +730,7 @@ public void Dispose()
 
                     PooledSocket ps;
 
-                    while (this.freeItems.TryPop(out ps))
+                    while (_freeItems.TryPop(out ps))
                     {
                         try { ps.Destroy(); }
                         catch { }
@@ -725,7 +739,7 @@ public void Dispose()
                     this.ownerNode = null;
                     _semaphore.Dispose();
                     _semaphore = null;
-                    this.freeItems = null;
+                    _freeItems = null;
                 }
             }
 
@@ -904,7 +918,7 @@ protected virtual async Task<bool> ExecuteOperationAsync(IOperation op, Action<b
             var socket = (await this.AcquireAsync()).Value;
             if (socket == null) return false;
 
-            //key(string) to buffer(btye[]) 
+            //key(string) to buffer(btye[])
             var b = op.GetBuffer();
 
             try
@@ -982,20 +996,20 @@ event Action<IMemcachedNode> IMemcachedNode.Failed
 
 #region [ License information          ]
 /* ************************************************************
- * 
+ *
  *    Copyright (c) 2010 Attila Kisk? enyim.com
- *    
+ *
  *    Licensed under the Apache License, Version 2.0 (the "License");
  *    you may not use this file except in compliance with the License.
  *    You may obtain a copy of the License at
- *    
+ *
  *        http://www.apache.org/licenses/LICENSE-2.0
- *    
+ *
  *    Unless required by applicable law or agreed to in writing, software
  *    distributed under the License is distributed on an "AS IS" BASIS,
  *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  *    See the License for the specific language governing permissions and
  *    limitations under the License.
- *    
+ *
  * ************************************************************/
 #endregion