Merge pull request #191 from cnblogs/add-obsolete

cnblogs-dudu · web-flow · commit 81ff4485e360 · 2023-01-29T09:36:09.000+08:00
refactor: make a method as obsolete
diff --git a/src/Enyim.Caching/EnyimMemcachedServiceCollectionExtensions.cs b/src/Enyim.Caching/EnyimMemcachedServiceCollectionExtensions.cs
@@ -14,12 +14,14 @@ namespace Microsoft.Extensions.DependencyInjection
     public static class EnyimMemcachedServiceCollectionExtensions
     {
 #if NET6_0_OR_GREATER
+        [Obsolete("Calling BuildServiceProvider has side affects")]
         public static IServiceCollection AddEnyimMemcached(
             this IServiceCollection services,
             string sectionKey = "enyimMemcached",
             bool asDistributedCache = true)
         {
             var config = services.BuildServiceProvider().GetRequiredService<IConfiguration>();
+            config[""] = "";
             return services.AddEnyimMemcached(config.GetSection(sectionKey), asDistributedCache);
         }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -14,12 +14,14 @@ namespace Microsoft.Extensions.DependencyInjection`
`14`	`14`	`public static class EnyimMemcachedServiceCollectionExtensions`
`15`	`15`	`{`
`16`	`16`	`#if NET6_0_OR_GREATER`
	`17`	`+ [Obsolete("Calling BuildServiceProvider has side affects")]`
`17`	`18`	`public static IServiceCollection AddEnyimMemcached(`
`18`	`19`	`this IServiceCollection services,`
`19`	`20`	`string sectionKey = "enyimMemcached",`
`20`	`21`	`bool asDistributedCache = true)`
`21`	`22`	`{`
`22`	`23`	`var config = services.BuildServiceProvider().GetRequiredService<IConfiguration>();`
	`24`	`+ config[""] = "";`
`23`	`25`	`return services.AddEnyimMemcached(config.GetSection(sectionKey), asDistributedCache);`
`24`	`26`	`}`
`25`	`27`	`#endif`