Skip to content

Commit 46326e8

Browse files
committed
Makefile: simplify mod-{tidy,verify} targets.
Simplify go.mod tidying and verifying. Switch from explicit hand-crafted targets for handling submodules to discovering and handling them automatically. Signed-off-by: Krisztian Litkey <[email protected]>
1 parent 1f83d84 commit 46326e8

File tree

1 file changed

+16
-24
lines changed

1 file changed

+16
-24
lines changed

Makefile

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -64,30 +64,22 @@ $(BINARIES): bin/%:
6464
#
6565
# go module tidy and verify targets
6666
#
67-
.PHONY: mod-tidy $(CMD_MOD_TIDY_TARGETS) mod-tidy-root
68-
.PHONY: mod-verify $(CMD_MOD_VERIFY_TARGETS) mod-verify-root
69-
70-
CMD_MOD_TIDY_TARGETS := mod-tidy-cdi mod-tidy-validate
71-
CMD_MOD_VERIFY_TARGETS := mod-verify-cdi mod-verify-validate
72-
73-
mod-tidy-root:
74-
$(Q)echo "Running $@..."; \
75-
$(GO_CMD) mod tidy
76-
77-
$(CMD_MOD_TIDY_TARGETS): mod-tidy-%: mod-tidy-root
78-
$(Q)echo "Running $@... in $(abspath ./cmd/$(*))"; \
79-
(cd $(abspath ./cmd/$(*)) && $(GO_CMD) mod tidy)
80-
81-
mod-verify-root: mod-tidy-root
82-
$(Q)echo "Running $@..."; \
83-
$(GO_CMD) mod verify
84-
85-
$(CMD_MOD_VERIFY_TARGETS): mod-verify-%: mod-tidy-% mod-verify-root
86-
$(Q)echo "Running $@... in $(abspath ./cmd/$(*))"; \
87-
(cd $(abspath ./cmd/$(*)) && pwd && $(GO_CMD) mod verify)
88-
89-
mod-verify: $(CMD_MOD_VERIFY_TARGETS)
90-
mod-tidy: $(CMD_MOD_TIDY_TARGETS)
67+
.PHONY: mod-tidy
68+
.PHONY: mod-verify
69+
70+
mod-tidy:
71+
$(Q)for mod in $$(find . -name go.mod); do \
72+
echo "Tidying $$mod..."; ( \
73+
cd $$(dirname $$mod) && go mod tidy \
74+
) || exit 1; \
75+
done
76+
77+
mod-verify:
78+
$(Q)for mod in $$(find . -name go.mod); do \
79+
echo "Verifying $$mod..."; ( \
80+
cd $$(dirname $$mod) && go mod verify | sed 's/^/ /g' \
81+
) || exit 1; \
82+
done
9183

9284
#
9385
# cleanup targets

0 commit comments

Comments
 (0)