pkg/cdi: make registry use the default cache.

Make the registry use the default cache. Add a documentation note
about future plans to obsolete and eventually remove the registry
interface. Don't mark the registry obsoleted yet.

Signed-off-by: Krisztian Litkey <[email protected]>

Author: klihub

pkg/cdi/doc.go

@@ -35,7 +35,9 @@
 // available and instantiated the first time it is referenced directly
 // or indirectly. The most frequently used cache functions are available
 // as identically named package level functions which operate on the
-// default cache instance.
+// default cache instance. Moreover, the registry also operates on the
+// same default cache. We plan to deprecate the registry and eventually
+// remove it in a future release.
 //
 // # CDI Registry
 //

pkg/cdi/registry.go

@@ -122,15 +122,12 @@ var (
 // GetRegistry returns the CDI registry. If any options are given, those
 // are applied to the registry.
 func GetRegistry(options ...Option) Registry {
-	var new bool
 	initOnce.Do(func() {
-		reg = &registry{newCache(options...)}
-		new = true
+		reg = &registry{GetDefaultCache()}
 	})
-	if !new && len(options) > 0 {
+	if len(options) > 0 {
 		// We don't care about errors here
 		_ = reg.Configure(options...)
-		_ = reg.Refresh()
 	}
 	return reg
 }