Skip to content

Commit ec3b0f6

Browse files
authored
Add initial approvers for Traditional Chinese (#2003)
* Add initial approvers for Traditional Chinese Signed-off-by: Seokho Son <[email protected]> * Update settings.yml Signed-off-by: Seokho Son <[email protected]> --------- Signed-off-by: Seokho Son <[email protected]>
1 parent 85a2733 commit ec3b0f6

File tree

2 files changed

+31
-4
lines changed

2 files changed

+31
-4
lines changed

.github/settings.yml

Lines changed: 27 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ collaborators:
143143
- username: 92nqb
144144
permission: push
145145

146-
# l10n zh approvers
146+
# l10n zh-cn approvers
147147
- username: hanyuancheung
148148
permission: push
149149

@@ -176,6 +176,13 @@ collaborators:
176176
- username: waleed318
177177
permission: push
178178

179+
# l10n zh-tw approvers
180+
- username: pichuang
181+
permission: push
182+
183+
- username: ydFu
184+
permission: push
185+
179186

180187
branches:
181188

@@ -352,7 +359,7 @@ branches:
352359
enforce_admins: null
353360
required_linear_history: null
354361

355-
# l10n branch for zh contents only
362+
# l10n branch for zh-cn contents only
356363
- name: dev-zh
357364
protection:
358365
required_pull_request_reviews:
@@ -361,7 +368,7 @@ branches:
361368
required_status_checks: null
362369
restrictions:
363370
apps: []
364-
# zh approvers
371+
# zh-cn approvers
365372
users:
366373
- hanyuancheung
367374
- Jacob953
@@ -405,3 +412,20 @@ branches:
405412
teams: []
406413
enforce_admins: null
407414
required_linear_history: null
415+
416+
# l10n branch for zh-tw contents only
417+
- name: dev-tw
418+
protection:
419+
required_pull_request_reviews:
420+
required_approving_review_count: 2
421+
require_code_owner_reviews: true
422+
required_status_checks: null
423+
restrictions:
424+
apps: []
425+
# zh-tw approvers
426+
users:
427+
- pichuang
428+
- ydFu
429+
teams: []
430+
enforce_admins: null
431+
required_linear_history: null

CODEOWNERS

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,14 @@
3636
# Approvers for Spanish contents
3737
/content/es/ @raelga @ramrodo @electrocucaracha @krol3 @92nqb
3838

39-
# Approvers for Chinese contents
39+
# Approvers for Simplified Chinese contents
4040
/content/zh-cn/ @hanyuancheung @Jacob953 @Rocksnake @Submarinee
4141

4242
# Approvers for French contents
4343
/content/fr/ @huats @fydrah @Krast76 @sestegra
4444

4545
# Approvers for Urdu contents
4646
/content/ur/ @Saim-Safdar @waleed318
47+
48+
# Approvers for Traditional Chinese contents
49+
/content/zh-tw/ @pichuang @ydFu

0 commit comments

Comments
 (0)