Skip to content

Commit fd6c397

Browse files
authored
Merge pull request #333 from thisisobate/fix-ci
chore: fix CI errors
2 parents ca7bf07 + e57662b commit fd6c397

18 files changed

+259
-348
lines changed

.cspell.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,17 @@ words:
2424
- CLOTributor
2525
- CNCF
2626
- Docsy
27+
- dwelsch
2728
- keda
29+
- knative
2830
- kedacore
2931
- krook
32+
- mkdocs
3033
- nate
3134
- nvmrc
3235
- subpages
3336
- techdocs
3437
- toolkits
3538
- toto
3639
- triaging
40+
- Welsch

analyses/0001-contour.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ criterion’s definition.
4747
### Comments
4848

4949
- **Information Architecture**:
50-
5150
- Documentation is feature complete!
5251
- A clear "About" or "What is Contour?" page is missing. It partially exists
5352
on [Architecture](https://projectcontour.io/docs/v1.13.1/architecture) and
@@ -83,7 +82,6 @@ criterion’s definition.
8382
- What's the next doc I should read _after_ this to understand Contour and
8483
how to customize it for my use case?
8584
- **Content maintainability**:
86-
8785
- Your documentation is searchable, which is great!
8886
- However, because there are docs on your site that live _outside_ of the
8987
docs directory, the entire site needs to be searchable.
@@ -111,7 +109,6 @@ criterion’s definition.
111109
### Recommendations
112110

113111
- **Information Architecture**:
114-
115112
- The main issue with information architecture is titling.
116113
- **The guides section:** Having "Guides" as a top-level section which appears
117114
in the nav before documentation is a bit confusing. I recommend having
@@ -139,7 +136,6 @@ criterion’s definition.
139136
a small win and a great first issue.
140137

141138
- **New user content**:
142-
143139
- Work with a technical writer to revise your getting started page to provide
144140
a bit more background information about Contour for the true new learner and
145141
provide more "next steps" documentation.
@@ -221,7 +217,6 @@ website, and in the repo. Great job team!
221217

222218
- **Branding and design**: one extremely small styling suggestion which would
223219
make a great first issue:
224-
225220
- for `<h2>` elements on documentation pages, change the margin from
226221
`margin-bottom: 2rem` to `margin-top: 1rem; margin-bottom: 1rem` or
227222
(preferred) `margin-top: 1.5rem; margin-bottom: 0.5rem;`. In general it's
@@ -266,7 +261,6 @@ website, and in the repo. Great job team!
266261
The revised content could have the following structure, if desired:
267262

268263
- Getting started guide:
269-
270264
- Introduction to Project Contour
271265
- Project philosophy
272266
- Why choose Contour over another (less opinionated) ingress controller

analyses/0002-notary-project.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ Criteria:
7575

7676
- Is the documentation feature complete, as in each product feature is
7777
documented?
78-
7978
- As the project is in ongoing development, not every feature is completed and
8079
so there are some holes in the documentation.
8180
- The
@@ -86,14 +85,12 @@ Criteria:
8685

8786
- Are there step-by-step instructions (tasks, tutorials) documented for
8887
features?
89-
9088
- Since V2's documentation is so conceptual at this point (consisting mostly
9189
of specification), it may be best to leave it as is &mdash; linking to it
9290
directly during the development process, and planning documentation along
9391
side the development of the system as a whole.
9492

9593
- Is the “happy path”/most common use case documented?
96-
9794
- The V1 Getting Started Guide is very good. Will V2 be able to draw from it?
9895

9996
- If the documentation does not suffice, is there a clear escalation path for
@@ -181,7 +178,6 @@ Criteria
181178
### Comments & recommendations
182179

183180
- Most of the issues in this section are a function of not having a website yet.
184-
185181
- As the website build process starts, put together a skeleton IA that can be
186182
filled in as the project grows.
187183

@@ -190,7 +186,6 @@ Criteria
190186
https://prometheus.io/community/.
191187

192188
- There is no documentation for:
193-
194189
- Triaging docs issues
195190
- Clearly marking a way for new contributors to make code or documentation
196191
contributions (i.e. a “good first issue” label), and define what makes a

analyses/0003-krator.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ Criteria:
5454
### Comments
5555

5656
- **Information Architecture**:
57-
5857
- Documentation is currently in several locations and will need to be brought
5958
into one repo. The current resources are:
6059
- The project [README](https://github.com/krator-rs/krator)

analyses/0004-tremor.md

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ Scale:
5252
- **Information Architecture:** Project Tremor's documentation makes a number of
5353
individually small IA choices that culminate in a confusing experience for the
5454
user.
55-
5655
- The [Getting Started](https://www.tremor.rs/getting-started/) section covers
5756
a number of seemingly random topics, with some appearing to be focused on
5857
selling the project to new users (i.e.
@@ -112,7 +111,6 @@ Scale:
112111
- **New user content:** Project Tremor has a Getting Started section but it's a
113112
little disorganized as mentioned above. This makes it difficult for an actual
114113
new user to understand.
115-
116114
- [Starting Tremor for the first time](https://www.tremor.rs/getting-started/starting/)
117115
is the best part of the getting started guide. However, it mentions that
118116
there are "many ways" to install Tremor - it would be good to point users to
@@ -172,7 +170,6 @@ Scale:
172170

173171
- **Get specific about your Getting Started:** Getting Started Guides contain a
174172
very predictable set of content:
175-
176173
- In one paragraph or less, what is this piece of software
177174
- What prerequisite software (i.e. Kubernetes) and knowledge (i.e., Go) do I
178175
need on my system to launch this?
@@ -183,7 +180,6 @@ Scale:
183180

184181
- **Reorganize the Operations section and retitle it "Using Tremor"**:
185182
Additionally, move some topics from the existing Getting Started section:
186-
187183
- [Configuring Tremor](https://docs.tremor.rs/operations/configuration-walkthrough/)
188184
- [Walkthrough: Configure a Tremor Deployment](https://docs.tremor.rs/operations/configuration-walkthrough/)
189185
- [Connectivity: Onramps and Offramps](https://www.tremor.rs/getting-started/connectivity/)
@@ -207,7 +203,6 @@ Scale:
207203
- **Reorganize [Overview](https://docs.tremor.rs/overview/) with
208204
user-centeredness in mind**: I suggest creating a new section with the
209205
following content:
210-
211206
- The information on [The docs index](https://docs.tremor.rs/) as a page
212207
titled "Overview", with subpages:
213208
- [Architecture Overview](https://docs.tremor.rs/overview/) (note: you could
@@ -218,7 +213,6 @@ Scale:
218213

219214
- **Audit for colloquial/casual language, abbreviations, and other "basic"
220215
English:**
221-
222216
- This recommendation has less to do with casual language or abbreviations
223217
being _bad_, and more to do with the perception of professionalism for the
224218
project.
@@ -269,7 +263,6 @@ Scale:
269263
and
270264
[issues for new users are tagged](https://github.com/tremor-rs/tremor-www-docs/issues?q=is%3Aissue+is%3Aclosed).
271265
Great work!
272-
273266
- One thing to note is when tagging an issue
274267
[as a good first issue](https://github.com/tremor-rs/tremor-www-docs/issues/101),
275268
assume the reader knows nothing and must be hand-held through the entire
@@ -280,7 +273,6 @@ Scale:
280273
[Community](https://www.tremor.rs/community/) page exists but doesn't provide
281274
much guidance for new users. How do I get involved? When do community meetings
282275
happen? Where do I find the team on Discord or Slack?
283-
284276
- As mentioned above, [Development](https://docs.tremor.rs/development/) and
285277
[Governance](https://docs.tremor.rs/CodeOfConduct/) are targeted at
286278
contributor users and should be under the community section.
@@ -296,7 +288,6 @@ Scale:
296288

297289
- **Turn the Community page into a subsection and house Governance and
298290
Development documentation under it:**
299-
300291
- Specifically, move [Development](https://docs.tremor.rs/development/) to
301292
/community/development
302293
- Move
@@ -325,7 +316,6 @@ Scale:
325316
**Comments**
326317

327318
- **Branding and design:**
328-
329319
- On the whole, the Tremor docs site looks professional, if a little plain.
330320
- Because of the way the site deploys (from different repositories via GitHub
331321
pages), navigation is disjointed: if you're in the RFCs, you don't have the
@@ -340,7 +330,6 @@ Scale:
340330
content you can showcase about the project?
341331

342332
- **Case studies/social proof**: None available.
343-
344333
- Case studies/talks/generally showing that other projects use Tremor is one
345334
of the most powerful ways to gain new users. People love real-world examples
346335
of a codebase in action.

analyses/0005-fluxcd.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ Scale:
8989
high-level concepts better before beginning code: providing a bit more
9090
explanation up front, particularly around the object's required fields and
9191
what the expected values are. An example would be helpful for this audience.
92-
9392
- Items under the **Project** top level navigation section. At a glance I
9493
couldn't figure out how these were being pulled in via (I assume) the
9594
[Community repository](https://github.com/fluxcd/community), meaning they

analyses/0006-gateway-api.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ as well as where to find them.
9292
- The main task with information architecture is conceptualization and
9393
development as the documents are currently in different places. The following
9494
areas would establish a foundation:
95-
9695
- Introduction
9796
- Quick Start
9897
- Concepts
@@ -270,7 +269,6 @@ The [website](https://gateway-api.sigs.k8s.io/) is accessible via HTTPS.
270269
[Copyright notices](https://github.com/cncf/foundation/blob/master/copyright-notices.md).
271270

272271
- CNCF Branding elements
273-
274272
- “We are a Cloud Native Computing Foundation project.” or “We are a Cloud
275273
Native Computing Foundation sandbox project.” are present (depending on
276274
status)

analyses/0007-porter.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,14 +69,12 @@ Scale:
6969
- There appear to be two different operator quick starts (or is it the
7070
difference between desired state and operator? maybe the operator one needs to
7171
be in Get Started)
72-
7372
- https://getporter.org/quickstart/desired-state/
7473
- https://getporter.org/operator/quickstart/
7574

7675
- Mixins & Plugins sections duplicated in sidebar (and could potentially be
7776
organized under Concepts?)
7877
- Current info architecture
79-
8078
- root
8179
- Get started
8280
- Contribute

analyses/0008-backstage/backstage-analysis.md

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,11 @@ such, and pertain to legal requirements such as copyright and licensing issues.
118118

119119
| Criteria | 1 | 2 | 3 | 4 | 5 |
120120
| -------------------------- | --- | --- | --- | --- | --- |
121-
| Information architecture | | ✔︎ | | | |
122-
| New user content | | | | ✔︎ | |
123-
| Content maintainability | | | ✔︎ | | |
124-
| Content creation processes | | | ✔︎ | | |
125-
| Inclusive language | | | | ✔︎ | |
121+
| Information architecture | | ✔︎ | | | |
122+
| New user content | | | | ✔︎ | |
123+
| Content maintainability | | | ✔︎ | | |
124+
| Content creation processes | | | ✔︎ | | |
125+
| Inclusive language | | | | ✔︎ | |
126126

127127
Scale:
128128

@@ -352,10 +352,10 @@ these navigation aids are adequate.
352352

353353
| Criteria | 1 | 2 | 3 | 4 | 5 |
354354
| ----------------------------------------- | --- | --- | --- | --- | --- |
355-
| Communication methods documented | | | | ✔︎ | |
356-
| Beginner friendly issue backlog | | | | ✔︎ | |
357-
| “New contributor” getting started content | | | ✔︎ | | |
358-
| Project governance documentation | | | | | ✔︎ |
355+
| Communication methods documented | | | | ✔︎ | |
356+
| Beginner friendly issue backlog | | | | ✔︎ | |
357+
| “New contributor” getting started content | | | ✔︎ | | |
358+
| Project governance documentation | | | | | ✔︎ |
359359

360360
Scale:
361361

@@ -423,19 +423,19 @@ from the product documentation.
423423

424424
| Criteria | 1 | 2 | 3 | 4 | 5 |
425425
| ------------------------------------------- | --- | --- | --- | --- | --- |
426-
| Single source for all files | | | ✔︎ | | |
427-
| Meets min website req. (for maturity level) | | ✔︎ | | | |
428-
| Branding and design | | | | ✔︎ | |
429-
| Case studies/social proof | | | ✔︎ | | |
430-
| SEO, Analytics, and site-local search | | | | | ✔︎ |
431-
| Maintenance planning | | | ✔︎ | | |
432-
| A11y plan & implementation | | | | ✔︎ | |
433-
| Mobile-first plan & impl. | | | ✔︎ | | |
434-
| HTTPS access & HTTP redirect | | | | | ✔︎ |
435-
| Google Analytics 4 for production only | | | | | ✔︎ |
436-
| Indexing allowed for production server only | | | | | ✔︎ |
437-
| Intra-site / local search | | | | | ✔︎ |
438-
| Account custodians are documented | ✔︎ | | | | |
426+
| Single source for all files | | | ✔︎ | | |
427+
| Meets min website req. (for maturity level) | | ✔︎ | | | |
428+
| Branding and design | | | | ✔︎ | |
429+
| Case studies/social proof | | | ✔︎ | | |
430+
| SEO, Analytics, and site-local search | | | | | ✔︎ |
431+
| Maintenance planning | | | ✔︎ | | |
432+
| A11y plan & implementation | | | | ✔︎ | |
433+
| Mobile-first plan & impl. | | | ✔︎ | | |
434+
| HTTPS access & HTTP redirect | | | | | ✔︎ |
435+
| Google Analytics 4 for production only | | | | | ✔︎ |
436+
| Indexing allowed for production server only | | | | | ✔︎ |
437+
| Intra-site / local search | | | | | ✔︎ |
438+
| Account custodians are documented | ✔︎ | | | | |
439439

440440
Scale:
441441

analyses/0008-backstage/backstage-implementation.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ The following artifacts should be written and made findable for developers.
153153

154154
1. A getting started guide for developers. Provide a clear work path that
155155
describes how to:
156-
157156
1. Download and install any necessary software components
158157
1. Integrate Backstage with an existing development environment
159158

0 commit comments

Comments
 (0)