Improve coverage for #35.

Author: begarco

src/main/java/fr/cnes/sonar/plugins/icode/check/ICodeSensor.java

@@ -269,7 +269,7 @@ private List<String> getReportFiles(final Configuration config, final FileSystem
      * @param rule Key (i-Code) of the rule to check.
      * @return True if the rule is active and false if not or not exists.
      */
-    private boolean isRuleActive(final ActiveRules activeRules, final String rule) {
+    protected boolean isRuleActive(final ActiveRules activeRules, final String rule) {
         final RuleKey ruleKeyShell = RuleKey.of(ICodeRulesDefinition.getRepositoryKeyForLanguage(ShellLanguage.KEY), rule);
         final RuleKey ruleKeyF77 = RuleKey.of(ICodeRulesDefinition.getRepositoryKeyForLanguage(Fortran77Language.KEY), rule);
         final RuleKey ruleKeyF90 = RuleKey.of(ICodeRulesDefinition.getRepositoryKeyForLanguage(Fortran90Language.KEY), rule);

src/test/java/fr/cnes/sonar/plugins/icode/check/ICodeSensorTest.java

@@ -129,9 +129,8 @@ public void test_get_scanned_files() {
         final AnalysisProject project = new AnalysisProject();
         final AnalysisFile file = new AnalysisFile();
         final AnalysisFile file2 = new AnalysisFile();
-        final String key = bash_sh.key();
 
-        file.fileName = key;
+        file.fileName = "badaboum.sh";
         file2.fileName = "bash.sh";
 
         project.analysisFile = new AnalysisFile[]{file, file2};
@@ -175,4 +174,13 @@ public void test_save_issue_with_unknown_file() {
         Assert.assertEquals(0, context.allIssues().size());
     }
 
+    @Test
+    public void test_check_rules_activation() {
+        final ICodeSensor sensor = new ICodeSensor();
+
+        final boolean active = sensor.isRuleActive(context.activeRules(), "No rules are activated");
+
+        Assert.assertFalse(active);
+    }
+
 }

src/test/java/fr/cnes/sonar/plugins/icode/measures/ICodeMetricsProcessorTest.java

@@ -101,6 +101,24 @@ public void test_save_nominal_measures() {
         Assert.assertEquals(1, context.measures(key).size());
     }
 
+    @Test
+    public void test_save_line_of_comment_measures() {
+
+        rule.result = new Result();
+        rule.analysisRuleId = "SH.MET.LineOfComment";
+        rule.result.fileName = "bash.sh";
+        rule.result.resultValue = "3";
+        rule.result.resultLine = "3";
+        rule.result.resultTypePlace = "class";
+        rule.result.resultNamePlace = "yolo";
+        rule.result.resultId = "11";
+        rule.result.resultMessage = "Small file";
+        final String key = bash_sh.key();
+
+        ICodeMetricsProcessor.saveMeasure(context, files, rule);
+        Assert.assertEquals(1, context.measures(key).size());
+    }
+
     @Test
     public void test_save_shell_complexity_measures() {
 
@@ -137,6 +155,24 @@ public void test_save_other_measures() {
         Assert.assertEquals(0, context.measures(key).size());
     }
 
+    @Test
+    public void test_save_other_measures_on_inexistant_file() {
+
+        rule.result = new Result();
+        rule.analysisRuleId = "F90.MET.LineOfCode";
+        rule.result.fileName = "zoulou.sh";
+        rule.result.resultValue = "3";
+        rule.result.resultLine = "3";
+        rule.result.resultTypePlace = "class";
+        rule.result.resultNamePlace = "yolo";
+        rule.result.resultId = "11";
+        rule.result.resultMessage = "Small file";
+        final String key = bash_sh.key();
+
+        ICodeMetricsProcessor.saveMeasure(context, files, rule);
+        Assert.assertEquals(0, context.measures(key).size());
+    }
+
     @Test
     public void test_compute_complexity() {